From: Peter Korsgaard <peter@korsgaard.com>
To: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Cc: Julien Olivain <ju.o@free.fr>
Subject: Re: [Buildroot] [PATCH next 1/1] package/kexec: fix link error when BR2_OPTIMIZE_0=y
Date: Wed, 07 Aug 2024 00:44:15 +0200 [thread overview]
Message-ID: <87a5hpp8zk.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <cdbb074b-4480-4a10-809a-b15030dc0a18@mind.be> (Arnout Vandecappelle via buildroot's message of "Fri, 12 Jul 2024 21:09:21 +0200")
>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:
> On 22/08/2023 21:23, Julien Olivain wrote:
>> When BR2_OPTIMIZE_0, -O0 is passed in compiler CFLAGS. This means no
>> code optimization will be performed.
>> kexec code uses a trick to detect unaligned accesses at link time
>> which needs at least dead-code-removal to work. See
>> put/get_unaligned() macros in kexec/kexec.h. This code was re-enabled
>> in upstream commit [1].
>> This commit sets at least -O1 (which include the sufficient
>> dead-code-removal) when BR2_OPTIMIZE_0=y, to fix those issues.
>> Fixes:
>> - http://autobuild.buildroot.org/results/8f8/8f8532f1dfbd71e52c51c00118934af9fa45e7cb
>> - http://autobuild.buildroot.org/results/528/528fd7baf9b0ad5549d22ec8e0623c5fa1f2d117
>> - http://autobuild.buildroot.org/results/499/499115439680adfb4b40042468e5bbb65d91ce6c
>> - ...and many others
>> [1]
>> https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=0723defb5308ac7fce296f8b596bff4df6803f01
>> Signed-off-by: Julien Olivain <ju.o@free.fr>
> Applied to master, thanks.
Committed to 2024.02.x and 2024.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-06 22:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 19:23 [Buildroot] [PATCH next 1/1] package/kexec: fix link error when BR2_OPTIMIZE_0=y Julien Olivain
2023-08-22 19:35 ` Thomas Petazzoni via buildroot
2023-08-22 20:08 ` Julien Olivain
2023-08-22 20:35 ` Thomas Petazzoni via buildroot
2023-08-22 20:42 ` Julien Olivain
2024-07-12 19:09 ` Arnout Vandecappelle via buildroot
2024-08-06 22:44 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5hpp8zk.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.