All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Manu <mbarriolinares@gmail.com>
Cc: alsa-devel@alsa-project.org, kernelnewbies@kernelnewbies.org
Subject: Re: ALSA: usb-audio: Adding mixer controls to Mbox3
Date: Mon, 06 May 2024 16:11:35 +0200	[thread overview]
Message-ID: <87a5l3ghd4.wl-tiwai@suse.de> (raw)
In-Reply-To: <CA+64nrt8gP5gJXaC=MS5AHjfZFSz=AvUT-CcRV9o2+zSenVXfg@mail.gmail.com>

On Wed, 01 May 2024 16:31:35 +0200,
Manu wrote:
> 
> Thank you for all your help, Takashi!
> 
> I would like to add the hardware mixer controls for Mbox3.
> I have already identified every control in the function "mbox3_setup_defaults"
> of "quirks.c", but I am unsure about the structure needed to make the controls
> appear in alsamixer (further investigation is required). I would appreciate any
> help you or anyone else can provide.

I believe it'd be helpful if you can show some mock up or any examples
you wanted to try (or had in your head).  If the question was about
the complexity or too many code to add there, you can split to another
file, too.


thanks,

Takashi

> 
> Manuel Barrio Linares
> 
> 
> On Wed, May 1, 2024 at 4:55 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Tue, 30 Apr 2024 19:10:18 +0200,
> > Manuel Barrio Linares wrote:
> > >
> > > This adds support for all sample rates supported by the
> > > hardware,Digidesign Mbox 3 supports: {44100, 48000, 88200, 96000}
> > >
> > > Fixes syncing clock issues that presented as pops. To test this, without
> > > this patch playing 440hz tone produces pops.
> > >
> > > Clock is now synced between playback and capture interfaces so no more
> > > latency drift issue when using pipewire pro-profile.
> > > (https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3900)
> > >
> > > Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>
> >
> > Applied to for-next branch now.  Thanks!
> >
> >
> > Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Manu <mbarriolinares@gmail.com>
Cc: alsa-devel@alsa-project.org, kernelnewbies@kernelnewbies.org
Subject: Re: ALSA: usb-audio: Adding mixer controls to Mbox3
Date: Mon, 06 May 2024 16:11:35 +0200	[thread overview]
Message-ID: <87a5l3ghd4.wl-tiwai@suse.de> (raw)
In-Reply-To: <CA+64nrt8gP5gJXaC=MS5AHjfZFSz=AvUT-CcRV9o2+zSenVXfg@mail.gmail.com>

On Wed, 01 May 2024 16:31:35 +0200,
Manu wrote:
> 
> Thank you for all your help, Takashi!
> 
> I would like to add the hardware mixer controls for Mbox3.
> I have already identified every control in the function "mbox3_setup_defaults"
> of "quirks.c", but I am unsure about the structure needed to make the controls
> appear in alsamixer (further investigation is required). I would appreciate any
> help you or anyone else can provide.

I believe it'd be helpful if you can show some mock up or any examples
you wanted to try (or had in your head).  If the question was about
the complexity or too many code to add there, you can split to another
file, too.


thanks,

Takashi

> 
> Manuel Barrio Linares
> 
> 
> On Wed, May 1, 2024 at 4:55 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Tue, 30 Apr 2024 19:10:18 +0200,
> > Manuel Barrio Linares wrote:
> > >
> > > This adds support for all sample rates supported by the
> > > hardware,Digidesign Mbox 3 supports: {44100, 48000, 88200, 96000}
> > >
> > > Fixes syncing clock issues that presented as pops. To test this, without
> > > this patch playing 440hz tone produces pops.
> > >
> > > Clock is now synced between playback and capture interfaces so no more
> > > latency drift issue when using pipewire pro-profile.
> > > (https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3900)
> > >
> > > Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>
> >
> > Applied to for-next branch now.  Thanks!
> >
> >
> > Takashi

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply	other threads:[~2024-05-06 14:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28  0:57 [PATCH] ALSA: usb-audio: Add sampling rates support for Mbox3 ManuLinares
2024-04-29 12:11 ` Takashi Iwai
2024-04-29 12:13   ` Takashi Iwai
2024-04-29 19:35     ` [PATCH v2] " Manuel Barrio Linares
2024-04-30  7:34       ` Takashi Iwai
2024-04-30 17:10         ` [PATCH v3] " Manuel Barrio Linares
2024-05-01  7:55           ` Takashi Iwai
2024-05-01 14:31             ` ALSA: usb-audio: Adding mixer controls to Mbox3 Manu
2024-05-06 14:11               ` Takashi Iwai [this message]
2024-05-06 14:11                 ` Takashi Iwai
2024-05-06 21:32             ` [PATCH v4] ALSA: usb-audio: Add sampling rates support for Mbox3 Manuel Barrio Linares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5l3ghd4.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=mbarriolinares@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.