All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	Song Yoong Siang <yoong.siang.song@intel.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Stanislav Fomichev <sdf@google.com>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	Florian Bezdeka <florian.bezdeka@siemens.com>,
	Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Mykola Lysenko <mykolal@fb.com>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
	xdp-hints@xdp-project.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	linux-kselftest@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [xdp-hints] Re: [Intel-wired-lan] [PATCH iwl-next, v3 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet
Date: Thu, 07 Mar 2024 14:38:32 +0100	[thread overview]
Message-ID: <87a5nago13.fsf@kurt.kurt.home> (raw)
In-Reply-To: <Zein8XvWkqj8VrHs@boxer>

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

Hi Maciej,

On Wed Mar 06 2024, Maciej Fijalkowski wrote:
> On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote:
>> -	tstamp->skb = NULL;
>> +	/* Copy the tx hardware timestamp into xdp metadata or skb */
>> +	if (tstamp->buffer_type == IGC_TX_BUFFER_TYPE_XSK)
>
> I believe this should also be protected with xp_tx_metadata_enabled()
> check. We recently had following bugfix, PTAL:
>
> https://lore.kernel.org/bpf/20240222-stmmac_xdp-v2-1-4beee3a037e4@linutronix.de/
>
> I'll take a deeper look at patch tomorrow, might be the case that you've
> addressed that or you were aware of this issue but anyways wanted to bring
> it up. Just check that you don't break standard XDP/AF_XDP traffic :)

This one doesn't crash standard AF_XDP traffic. Don't know why, but it
seems to work.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
	Song Yoong Siang <yoong.siang.song@intel.com>
Cc: linux-kselftest@vger.kernel.org,
	Florian Bezdeka <florian.bezdeka@siemens.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Stanislav Fomichev <sdf@google.com>,
	Yonghong Song <yonghong.song@linux.dev>,
	Shuah Khan <shuah@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
	xdp-hints@xdp-project.net, Daniel Borkmann <daniel@iogearbox.net>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	John Fastabend <john.fastabend@gmail.com>,
	intel-wired-lan@lists.osuosl.org,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eduard Zingerman <eddyz87@gmail.com>,
	Jiri Olsa <jolsa@kernel.org>,
	bpf@vger.kernel.org, Martin KaFai Lau <martin.lau@linux.dev>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [xdp-hints] Re:  [PATCH iwl-next, v3 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet
Date: Thu, 07 Mar 2024 14:38:32 +0100	[thread overview]
Message-ID: <87a5nago13.fsf@kurt.kurt.home> (raw)
In-Reply-To: <Zein8XvWkqj8VrHs@boxer>

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

Hi Maciej,

On Wed Mar 06 2024, Maciej Fijalkowski wrote:
> On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote:
>> -	tstamp->skb = NULL;
>> +	/* Copy the tx hardware timestamp into xdp metadata or skb */
>> +	if (tstamp->buffer_type == IGC_TX_BUFFER_TYPE_XSK)
>
> I believe this should also be protected with xp_tx_metadata_enabled()
> check. We recently had following bugfix, PTAL:
>
> https://lore.kernel.org/bpf/20240222-stmmac_xdp-v2-1-4beee3a037e4@linutronix.de/
>
> I'll take a deeper look at patch tomorrow, might be the case that you've
> addressed that or you were aware of this issue but anyways wanted to bring
> it up. Just check that you don't break standard XDP/AF_XDP traffic :)

This one doesn't crash standard AF_XDP traffic. Don't know why, but it
seems to work.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2024-03-07 13:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03  8:32 [PATCH iwl-next,v3 0/2] XDP Tx Hardware Timestamp for igc driver Song Yoong Siang
2024-03-03  8:32 ` [Intel-wired-lan] [PATCH iwl-next, v3 " Song Yoong Siang
2024-03-03  8:32 ` [PATCH iwl-next,v3 1/2] selftests/bpf: xdp_hw_metadata reduce sleep interval Song Yoong Siang
2024-03-03  8:32   ` [Intel-wired-lan] [PATCH iwl-next, v3 " Song Yoong Siang
2024-03-03  8:32 ` [PATCH iwl-next,v3 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet Song Yoong Siang
2024-03-03  8:32   ` [Intel-wired-lan] [PATCH iwl-next, v3 " Song Yoong Siang
2024-03-06 17:29   ` Maciej Fijalkowski
2024-03-06 17:29     ` Maciej Fijalkowski
2024-03-07 13:38     ` Kurt Kanzenbach [this message]
2024-03-07 13:38       ` [Intel-wired-lan] [xdp-hints] " Kurt Kanzenbach
2024-03-08  3:39       ` [xdp-hints] Re: [Intel-wired-lan] " Song, Yoong Siang
2024-03-08  3:39         ` [Intel-wired-lan] [xdp-hints] " Song, Yoong Siang
2024-03-04 14:10 ` [PATCH iwl-next,v3 0/2] XDP Tx Hardware Timestamp for igc driver patchwork-bot+netdevbpf
2024-03-04 14:10   ` [Intel-wired-lan] [PATCH iwl-next, v3 " patchwork-bot+netdevbpf
2024-03-04 14:19   ` [xdp-hints] Re: [PATCH iwl-next,v3 " Daniel Borkmann
2024-03-04 14:19     ` [Intel-wired-lan] [xdp-hints] Re: [PATCH iwl-next, v3 " Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5nago13.fsf@kurt.kurt.home \
    --to=kurt@linutronix.de \
    --cc=andrii@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@google.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=haoluo@google.com \
    --cc=hawk@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=sdf@google.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=vinicius.gomes@intel.com \
    --cc=xdp-hints@xdp-project.net \
    --cc=yonghong.song@linux.dev \
    --cc=yoong.siang.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.