* [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()
@ 2023-05-17 18:33 ` Hamza Mahfooz
0 siblings, 0 replies; 23+ messages in thread
From: Hamza Mahfooz @ 2023-05-17 18:33 UTC (permalink / raw)
To: amd-gfx
Cc: Hamza Mahfooz, Christophe JAILLET, Harry Wentland, Leo Li,
Rodrigo Siqueira, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Qingqing Zhuo, Aurabindo Pillai,
Hans de Goede, Hersen Wu, Stylon Wang, Jun Lei, Wenjing Liu,
Leon Huang, Mike Hsieh, Cruise Hung, Nasir Osman, pengfuyuan,
dri-devel, linux-kernel
get_available_dsc_slices() returns the number of indices set, and all of
the users of get_available_dsc_slices() don't cross the returned bound
when iterating over available_slices[]. So, the memset() in
get_available_dsc_slices() is redundant and can be dropped.
Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
index b9a05bb025db..58dd62cce4bb 100644
--- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
+++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
@@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
{
int idx = 0;
- memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
-
if (slice_caps.bits.NUM_SLICES_1)
available_slices[idx++] = 1;
--
2.40.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()
@ 2023-05-17 18:33 ` Hamza Mahfooz
0 siblings, 0 replies; 23+ messages in thread
From: Hamza Mahfooz @ 2023-05-17 18:33 UTC (permalink / raw)
To: amd-gfx
Cc: Wenjing Liu, dri-devel, Hamza Mahfooz, Jun Lei, Nasir Osman,
Rodrigo Siqueira, Aurabindo Pillai, Stylon Wang, Leo Li,
pengfuyuan, Christophe JAILLET, Cruise Hung, Mike Hsieh,
Hans de Goede, Qingqing Zhuo, Pan, Xinhui, linux-kernel,
Leon Huang, Alex Deucher, Hersen Wu, Christian König
get_available_dsc_slices() returns the number of indices set, and all of
the users of get_available_dsc_slices() don't cross the returned bound
when iterating over available_slices[]. So, the memset() in
get_available_dsc_slices() is redundant and can be dropped.
Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
index b9a05bb025db..58dd62cce4bb 100644
--- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
+++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
@@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
{
int idx = 0;
- memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
-
if (slice_caps.bits.NUM_SLICES_1)
available_slices[idx++] = 1;
--
2.40.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()
2023-05-17 18:33 ` Hamza Mahfooz
(?)
@ 2023-05-17 18:33 ` Hamza Mahfooz
-1 siblings, 0 replies; 23+ messages in thread
From: Hamza Mahfooz @ 2023-05-17 18:33 UTC (permalink / raw)
To: amd-gfx
Cc: Tom Rix, dri-devel, Hamza Mahfooz, David Airlie, Nasir Osman,
kernel test robot, Rodrigo Siqueira, Aurabindo Pillai,
Harry Wentland, Stylon Wang, Leo Li, Wenjing Liu, pengfuyuan,
Hersen Wu, Cruise Hung, Mike Hsieh, Hans de Goede, Qingqing Zhuo,
Pan, Xinhui, linux-kernel, Leon Huang, Daniel Vetter,
Alex Deucher, Christian König
set_abm_event() is never actually used. So, drop it.
Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Tom Rix <trix@redhat.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 --
2 files changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
index a66f83a61402..2fb9572ce25d 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
@@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
return ret;
}
-static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
- unsigned int hdr_mode, unsigned int panel_inst)
-{
- bool ret = false;
- unsigned int feature_support;
-
- feature_support = abm_feature_support(abm, panel_inst);
-
- return ret;
-}
-
static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
unsigned int backlight_pwm_u16_16,
unsigned int frame_ramp,
@@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
.init_abm_config = dmub_abm_init_config_ex,
.set_abm_pause = dmub_abm_set_pause_ex,
.set_pipe_ex = dmub_abm_set_pipe_ex,
- .set_abm_event = dmub_abm_set_event_ex,
.set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
};
diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
index db5cf9acafe6..d2190a3320f6 100644
--- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
+++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
@@ -59,8 +59,6 @@ struct abm_funcs {
unsigned int otg_inst,
unsigned int option,
unsigned int panel_inst);
- bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
- unsigned int hdr_mode, unsigned int panel_inst);
};
#endif
--
2.40.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()
@ 2023-05-17 18:33 ` Hamza Mahfooz
0 siblings, 0 replies; 23+ messages in thread
From: Hamza Mahfooz @ 2023-05-17 18:33 UTC (permalink / raw)
To: amd-gfx
Cc: Hamza Mahfooz, kernel test robot, Tom Rix, Harry Wentland, Leo Li,
Rodrigo Siqueira, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Qingqing Zhuo, Aurabindo Pillai,
Hans de Goede, Hersen Wu, Stylon Wang, Wenjing Liu, Leon Huang,
Mike Hsieh, Cruise Hung, Nasir Osman, pengfuyuan, dri-devel,
linux-kernel
set_abm_event() is never actually used. So, drop it.
Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Tom Rix <trix@redhat.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 --
2 files changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
index a66f83a61402..2fb9572ce25d 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
@@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
return ret;
}
-static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
- unsigned int hdr_mode, unsigned int panel_inst)
-{
- bool ret = false;
- unsigned int feature_support;
-
- feature_support = abm_feature_support(abm, panel_inst);
-
- return ret;
-}
-
static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
unsigned int backlight_pwm_u16_16,
unsigned int frame_ramp,
@@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
.init_abm_config = dmub_abm_init_config_ex,
.set_abm_pause = dmub_abm_set_pause_ex,
.set_pipe_ex = dmub_abm_set_pipe_ex,
- .set_abm_event = dmub_abm_set_event_ex,
.set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
};
diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
index db5cf9acafe6..d2190a3320f6 100644
--- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
+++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
@@ -59,8 +59,6 @@ struct abm_funcs {
unsigned int otg_inst,
unsigned int option,
unsigned int panel_inst);
- bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
- unsigned int hdr_mode, unsigned int panel_inst);
};
#endif
--
2.40.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()
@ 2023-05-17 18:33 ` Hamza Mahfooz
0 siblings, 0 replies; 23+ messages in thread
From: Hamza Mahfooz @ 2023-05-17 18:33 UTC (permalink / raw)
To: amd-gfx
Cc: Tom Rix, dri-devel, Hamza Mahfooz, Nasir Osman, kernel test robot,
Rodrigo Siqueira, Aurabindo Pillai, Stylon Wang, Leo Li,
Wenjing Liu, pengfuyuan, Hersen Wu, Cruise Hung, Mike Hsieh,
Hans de Goede, Qingqing Zhuo, Pan, Xinhui, linux-kernel,
Leon Huang, Alex Deucher, Christian König
set_abm_event() is never actually used. So, drop it.
Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Tom Rix <trix@redhat.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 --
2 files changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
index a66f83a61402..2fb9572ce25d 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
@@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
return ret;
}
-static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
- unsigned int hdr_mode, unsigned int panel_inst)
-{
- bool ret = false;
- unsigned int feature_support;
-
- feature_support = abm_feature_support(abm, panel_inst);
-
- return ret;
-}
-
static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
unsigned int backlight_pwm_u16_16,
unsigned int frame_ramp,
@@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
.init_abm_config = dmub_abm_init_config_ex,
.set_abm_pause = dmub_abm_set_pause_ex,
.set_pipe_ex = dmub_abm_set_pipe_ex,
- .set_abm_event = dmub_abm_set_event_ex,
.set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
};
diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
index db5cf9acafe6..d2190a3320f6 100644
--- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
+++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
@@ -59,8 +59,6 @@ struct abm_funcs {
unsigned int otg_inst,
unsigned int option,
unsigned int panel_inst);
- bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
- unsigned int hdr_mode, unsigned int panel_inst);
};
#endif
--
2.40.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()
2023-05-17 18:33 ` Hamza Mahfooz
(?)
@ 2023-05-18 0:03 ` Rodrigo Siqueira Jordao
-1 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:03 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Tom Rix, dri-devel, David Airlie, Nasir Osman, kernel test robot,
Wenjing Liu, Aurabindo Pillai, Harry Wentland, Stylon Wang,
Leo Li, pengfuyuan, Hersen Wu, Cruise Hung, Mike Hsieh,
Hans de Goede, Qingqing Zhuo, Pan, Xinhui, linux-kernel,
Leon Huang, Daniel Vetter, Alex Deucher, Christian König
On 5/17/23 12:33, Hamza Mahfooz wrote:
> set_abm_event() is never actually used. So, drop it.
>
> Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
> drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 --
> 2 files changed, 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> index a66f83a61402..2fb9572ce25d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> @@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
> return ret;
> }
>
> -static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> - unsigned int hdr_mode, unsigned int panel_inst)
> -{
> - bool ret = false;
> - unsigned int feature_support;
> -
> - feature_support = abm_feature_support(abm, panel_inst);
> -
> - return ret;
> -}
> -
> static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
> unsigned int backlight_pwm_u16_16,
> unsigned int frame_ramp,
> @@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
> .init_abm_config = dmub_abm_init_config_ex,
> .set_abm_pause = dmub_abm_set_pause_ex,
> .set_pipe_ex = dmub_abm_set_pipe_ex,
> - .set_abm_event = dmub_abm_set_event_ex,
> .set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
> };
>
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> index db5cf9acafe6..d2190a3320f6 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> @@ -59,8 +59,6 @@ struct abm_funcs {
> unsigned int otg_inst,
> unsigned int option,
> unsigned int panel_inst);
> - bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> - unsigned int hdr_mode, unsigned int panel_inst);
> };
>
> #endif
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()
@ 2023-05-18 0:03 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:03 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: kernel test robot, Tom Rix, Harry Wentland, Leo Li, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Qingqing Zhuo, Aurabindo Pillai, Hans de Goede, Hersen Wu,
Stylon Wang, Wenjing Liu, Leon Huang, Mike Hsieh, Cruise Hung,
Nasir Osman, pengfuyuan, dri-devel, linux-kernel
On 5/17/23 12:33, Hamza Mahfooz wrote:
> set_abm_event() is never actually used. So, drop it.
>
> Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
> drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 --
> 2 files changed, 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> index a66f83a61402..2fb9572ce25d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> @@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
> return ret;
> }
>
> -static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> - unsigned int hdr_mode, unsigned int panel_inst)
> -{
> - bool ret = false;
> - unsigned int feature_support;
> -
> - feature_support = abm_feature_support(abm, panel_inst);
> -
> - return ret;
> -}
> -
> static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
> unsigned int backlight_pwm_u16_16,
> unsigned int frame_ramp,
> @@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
> .init_abm_config = dmub_abm_init_config_ex,
> .set_abm_pause = dmub_abm_set_pause_ex,
> .set_pipe_ex = dmub_abm_set_pipe_ex,
> - .set_abm_event = dmub_abm_set_event_ex,
> .set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
> };
>
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> index db5cf9acafe6..d2190a3320f6 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> @@ -59,8 +59,6 @@ struct abm_funcs {
> unsigned int otg_inst,
> unsigned int option,
> unsigned int panel_inst);
> - bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> - unsigned int hdr_mode, unsigned int panel_inst);
> };
>
> #endif
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event()
@ 2023-05-18 0:03 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:03 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Tom Rix, dri-devel, Nasir Osman, kernel test robot, Wenjing Liu,
Aurabindo Pillai, Stylon Wang, Leo Li, pengfuyuan, Hersen Wu,
Cruise Hung, Mike Hsieh, Hans de Goede, Qingqing Zhuo,
Pan, Xinhui, linux-kernel, Leon Huang, Alex Deucher,
Christian König
On 5/17/23 12:33, Hamza Mahfooz wrote:
> set_abm_event() is never actually used. So, drop it.
>
> Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------
> drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 --
> 2 files changed, 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> index a66f83a61402..2fb9572ce25d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c
> @@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op
> return ret;
> }
>
> -static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> - unsigned int hdr_mode, unsigned int panel_inst)
> -{
> - bool ret = false;
> - unsigned int feature_support;
> -
> - feature_support = abm_feature_support(abm, panel_inst);
> -
> - return ret;
> -}
> -
> static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm,
> unsigned int backlight_pwm_u16_16,
> unsigned int frame_ramp,
> @@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = {
> .init_abm_config = dmub_abm_init_config_ex,
> .set_abm_pause = dmub_abm_set_pause_ex,
> .set_pipe_ex = dmub_abm_set_pipe_ex,
> - .set_abm_event = dmub_abm_set_event_ex,
> .set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex,
> };
>
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> index db5cf9acafe6..d2190a3320f6 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h
> @@ -59,8 +59,6 @@ struct abm_funcs {
> unsigned int otg_inst,
> unsigned int option,
> unsigned int panel_inst);
> - bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode,
> - unsigned int hdr_mode, unsigned int panel_inst);
> };
>
> #endif
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
2023-05-17 18:33 ` Hamza Mahfooz
(?)
@ 2023-05-17 18:33 ` Hamza Mahfooz
-1 siblings, 0 replies; 23+ messages in thread
From: Hamza Mahfooz @ 2023-05-17 18:33 UTC (permalink / raw)
To: amd-gfx
Cc: Wenjing Liu, dri-devel, Hamza Mahfooz, Jun Lei, David Airlie,
Nasir Osman, kernel test robot, Rodrigo Siqueira,
Aurabindo Pillai, Harry Wentland, Stylon Wang, Leo Li, pengfuyuan,
Hersen Wu, Mike Hsieh, Hans de Goede, Qingqing Zhuo, Pan, Xinhui,
linux-kernel, Leon Huang, Daniel Vetter, Alex Deucher,
Christian König
Since, we are only interested in having
drm_edid_override_connector_update(), update the value of
connector->edid_blob_ptr. We don't care about the return value of
drm_edid_override_connector_update() here. So, drop count.
Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 14b296e1d0f6..5a2d04f47276 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
/* if connector->edid_override valid, pass
* it to edid_override to edid_blob_ptr
*/
- int count;
- count = drm_edid_override_connector_update(&aconnector->base);
+ drm_edid_override_connector_update(&aconnector->base);
if (!aconnector->base.edid_blob_ptr) {
DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
--
2.40.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
@ 2023-05-17 18:33 ` Hamza Mahfooz
0 siblings, 0 replies; 23+ messages in thread
From: Hamza Mahfooz @ 2023-05-17 18:33 UTC (permalink / raw)
To: amd-gfx
Cc: Hamza Mahfooz, kernel test robot, Harry Wentland, Leo Li,
Rodrigo Siqueira, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Qingqing Zhuo, Aurabindo Pillai,
Hans de Goede, Hersen Wu, Stylon Wang, Jun Lei, Leon Huang,
Wenjing Liu, Mike Hsieh, pengfuyuan, Nasir Osman, dri-devel,
linux-kernel
Since, we are only interested in having
drm_edid_override_connector_update(), update the value of
connector->edid_blob_ptr. We don't care about the return value of
drm_edid_override_connector_update() here. So, drop count.
Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 14b296e1d0f6..5a2d04f47276 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
/* if connector->edid_override valid, pass
* it to edid_override to edid_blob_ptr
*/
- int count;
- count = drm_edid_override_connector_update(&aconnector->base);
+ drm_edid_override_connector_update(&aconnector->base);
if (!aconnector->base.edid_blob_ptr) {
DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
--
2.40.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
@ 2023-05-17 18:33 ` Hamza Mahfooz
0 siblings, 0 replies; 23+ messages in thread
From: Hamza Mahfooz @ 2023-05-17 18:33 UTC (permalink / raw)
To: amd-gfx
Cc: Wenjing Liu, dri-devel, Hamza Mahfooz, Jun Lei, Nasir Osman,
kernel test robot, Rodrigo Siqueira, Aurabindo Pillai,
Stylon Wang, Leo Li, pengfuyuan, Hersen Wu, Mike Hsieh,
Hans de Goede, Qingqing Zhuo, Pan, Xinhui, linux-kernel,
Leon Huang, Alex Deucher, Christian König
Since, we are only interested in having
drm_edid_override_connector_update(), update the value of
connector->edid_blob_ptr. We don't care about the return value of
drm_edid_override_connector_update() here. So, drop count.
Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 14b296e1d0f6..5a2d04f47276 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
/* if connector->edid_override valid, pass
* it to edid_override to edid_blob_ptr
*/
- int count;
- count = drm_edid_override_connector_update(&aconnector->base);
+ drm_edid_override_connector_update(&aconnector->base);
if (!aconnector->base.edid_blob_ptr) {
DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
--
2.40.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
2023-05-17 18:33 ` Hamza Mahfooz
(?)
@ 2023-05-18 0:04 ` Rodrigo Siqueira Jordao
-1 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:04 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Stylon Wang, Mike Hsieh, kernel test robot, pengfuyuan, Leo Li,
David Airlie, Qingqing Zhuo, Pan, Xinhui, Wenjing Liu,
linux-kernel, dri-devel, Leon Huang, Hans de Goede,
Aurabindo Pillai, Hersen Wu, Daniel Vetter, Alex Deucher, Jun Lei,
Harry Wentland, Christian König, Nasir Osman
On 5/17/23 12:33, Hamza Mahfooz wrote:
> Since, we are only interested in having
> drm_edid_override_connector_update(), update the value of
> connector->edid_blob_ptr. We don't care about the return value of
> drm_edid_override_connector_update() here. So, drop count.
>
> Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 14b296e1d0f6..5a2d04f47276 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
> /* if connector->edid_override valid, pass
> * it to edid_override to edid_blob_ptr
> */
> - int count;
>
> - count = drm_edid_override_connector_update(&aconnector->base);
> + drm_edid_override_connector_update(&aconnector->base);
>
> if (!aconnector->base.edid_blob_ptr) {
> DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
@ 2023-05-18 0:04 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:04 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: kernel test robot, Harry Wentland, Leo Li, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Qingqing Zhuo, Aurabindo Pillai, Hans de Goede, Hersen Wu,
Stylon Wang, Jun Lei, Leon Huang, Wenjing Liu, Mike Hsieh,
pengfuyuan, Nasir Osman, dri-devel, linux-kernel
On 5/17/23 12:33, Hamza Mahfooz wrote:
> Since, we are only interested in having
> drm_edid_override_connector_update(), update the value of
> connector->edid_blob_ptr. We don't care about the return value of
> drm_edid_override_connector_update() here. So, drop count.
>
> Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 14b296e1d0f6..5a2d04f47276 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
> /* if connector->edid_override valid, pass
> * it to edid_override to edid_blob_ptr
> */
> - int count;
>
> - count = drm_edid_override_connector_update(&aconnector->base);
> + drm_edid_override_connector_update(&aconnector->base);
>
> if (!aconnector->base.edid_blob_ptr) {
> DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
@ 2023-05-18 0:04 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:04 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Stylon Wang, Mike Hsieh, kernel test robot, pengfuyuan, Leo Li,
Qingqing Zhuo, Pan, Xinhui, Wenjing Liu, linux-kernel, dri-devel,
Leon Huang, Hans de Goede, Aurabindo Pillai, Hersen Wu,
Alex Deucher, Jun Lei, Christian König, Nasir Osman
On 5/17/23 12:33, Hamza Mahfooz wrote:
> Since, we are only interested in having
> drm_edid_override_connector_update(), update the value of
> connector->edid_blob_ptr. We don't care about the return value of
> drm_edid_override_connector_update() here. So, drop count.
>
> Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 14b296e1d0f6..5a2d04f47276 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
> /* if connector->edid_override valid, pass
> * it to edid_override to edid_blob_ptr
> */
> - int count;
>
> - count = drm_edid_override_connector_update(&aconnector->base);
> + drm_edid_override_connector_update(&aconnector->base);
>
> if (!aconnector->base.edid_blob_ptr) {
> DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
2023-05-17 18:33 ` Hamza Mahfooz
@ 2023-08-22 11:43 ` Jani Nikula
-1 siblings, 0 replies; 23+ messages in thread
From: Jani Nikula @ 2023-08-22 11:43 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Stylon Wang, Mike Hsieh, kernel test robot, Hans de Goede, Leo Li,
Rodrigo Siqueira, Qingqing Zhuo, Pan, Xinhui, Wenjing Liu,
linux-kernel, dri-devel, Leon Huang, pengfuyuan, Aurabindo Pillai,
Hersen Wu, Hamza Mahfooz, Alex Deucher, Jun Lei,
Christian König, Nasir Osman
On Wed, 17 May 2023, Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
> Since, we are only interested in having
> drm_edid_override_connector_update(), update the value of
> connector->edid_blob_ptr. We don't care about the return value of
> drm_edid_override_connector_update() here. So, drop count.
>
> Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
The *real* problems with that commit are:
1) It uses drm_edid_override_connector_update() *at all*. Its
documentation says:
Only to be used from drm_helper_probe_single_connector_modes()
as a fallback for when DDC probe failed during drm_get_edid()
and caused the override/firmware EDID to be skipped.
2) It messes with edid_blob_ptr directly. All drivers should stop doing
that. It just complicates all the logic in the overrides and the
property updates.
BR,
Jani.
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 14b296e1d0f6..5a2d04f47276 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
> /* if connector->edid_override valid, pass
> * it to edid_override to edid_blob_ptr
> */
> - int count;
>
> - count = drm_edid_override_connector_update(&aconnector->base);
> + drm_edid_override_connector_update(&aconnector->base);
>
> if (!aconnector->base.edid_blob_ptr) {
> DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
@ 2023-08-22 11:43 ` Jani Nikula
0 siblings, 0 replies; 23+ messages in thread
From: Jani Nikula @ 2023-08-22 11:43 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Wenjing Liu, dri-devel, Hamza Mahfooz, Jun Lei, Nasir Osman,
kernel test robot, Rodrigo Siqueira, Aurabindo Pillai,
Stylon Wang, Leo Li, pengfuyuan, Hersen Wu, Mike Hsieh,
Hans de Goede, Qingqing Zhuo, Pan, Xinhui, linux-kernel,
Leon Huang, Alex Deucher, Christian König
On Wed, 17 May 2023, Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
> Since, we are only interested in having
> drm_edid_override_connector_update(), update the value of
> connector->edid_blob_ptr. We don't care about the return value of
> drm_edid_override_connector_update() here. So, drop count.
>
> Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
The *real* problems with that commit are:
1) It uses drm_edid_override_connector_update() *at all*. Its
documentation says:
Only to be used from drm_helper_probe_single_connector_modes()
as a fallback for when DDC probe failed during drm_get_edid()
and caused the override/firmware EDID to be skipped.
2) It messes with edid_blob_ptr directly. All drivers should stop doing
that. It just complicates all the logic in the overrides and the
property updates.
BR,
Jani.
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 14b296e1d0f6..5a2d04f47276 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
> /* if connector->edid_override valid, pass
> * it to edid_override to edid_blob_ptr
> */
> - int count;
>
> - count = drm_edid_override_connector_update(&aconnector->base);
> + drm_edid_override_connector_update(&aconnector->base);
>
> if (!aconnector->base.edid_blob_ptr) {
> DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()
2023-05-17 18:33 ` Hamza Mahfooz
(?)
@ 2023-05-18 0:01 ` Rodrigo Siqueira Jordao
-1 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:01 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: dri-devel, Jun Lei, David Airlie, Nasir Osman, Wenjing Liu,
Aurabindo Pillai, Harry Wentland, Stylon Wang, Leo Li, pengfuyuan,
Christophe JAILLET, Cruise Hung, Mike Hsieh, Hans de Goede,
Qingqing Zhuo, Pan, Xinhui, linux-kernel, Leon Huang,
Daniel Vetter, Alex Deucher, Hersen Wu, Christian König
On 5/17/23 12:33, Hamza Mahfooz wrote:
> get_available_dsc_slices() returns the number of indices set, and all of
> the users of get_available_dsc_slices() don't cross the returned bound
> when iterating over available_slices[]. So, the memset() in
> get_available_dsc_slices() is redundant and can be dropped.
>
> Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> index b9a05bb025db..58dd62cce4bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> @@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
> {
> int idx = 0;
>
> - memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
> -
> if (slice_caps.bits.NUM_SLICES_1)
> available_slices[idx++] = 1;
>
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()
@ 2023-05-18 0:01 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:01 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Christophe JAILLET, Harry Wentland, Leo Li, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Qingqing Zhuo, Aurabindo Pillai, Hans de Goede, Hersen Wu,
Stylon Wang, Jun Lei, Wenjing Liu, Leon Huang, Mike Hsieh,
Cruise Hung, Nasir Osman, pengfuyuan, dri-devel, linux-kernel
On 5/17/23 12:33, Hamza Mahfooz wrote:
> get_available_dsc_slices() returns the number of indices set, and all of
> the users of get_available_dsc_slices() don't cross the returned bound
> when iterating over available_slices[]. So, the memset() in
> get_available_dsc_slices() is redundant and can be dropped.
>
> Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> index b9a05bb025db..58dd62cce4bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> @@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
> {
> int idx = 0;
>
> - memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
> -
> if (slice_caps.bits.NUM_SLICES_1)
> available_slices[idx++] = 1;
>
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()
@ 2023-05-18 0:01 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 23+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-05-18 0:01 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: dri-devel, Jun Lei, Nasir Osman, Wenjing Liu, Aurabindo Pillai,
Stylon Wang, Leo Li, pengfuyuan, Christophe JAILLET, Cruise Hung,
Mike Hsieh, Hans de Goede, Qingqing Zhuo, Pan, Xinhui,
linux-kernel, Leon Huang, Alex Deucher, Hersen Wu,
Christian König
On 5/17/23 12:33, Hamza Mahfooz wrote:
> get_available_dsc_slices() returns the number of indices set, and all of
> the users of get_available_dsc_slices() don't cross the returned bound
> when iterating over available_slices[]. So, the memset() in
> get_available_dsc_slices() is redundant and can be dropped.
>
> Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> index b9a05bb025db..58dd62cce4bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> @@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
> {
> int idx = 0;
>
> - memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
> -
> if (slice_caps.bits.NUM_SLICES_1)
> available_slices[idx++] = 1;
>
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()
2023-05-17 18:33 ` Hamza Mahfooz
(?)
@ 2023-05-18 6:28 ` Marion & Christophe JAILLET
-1 siblings, 0 replies; 23+ messages in thread
From: Marion & Christophe JAILLET @ 2023-05-18 6:28 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Wenjing Liu, dri-devel, Jun Lei, David Airlie, Nasir Osman,
Rodrigo Siqueira, Aurabindo Pillai, Harry Wentland, Stylon Wang,
Leo Li, pengfuyuan, Hersen Wu, Cruise Hung, Mike Hsieh,
Hans de Goede, Qingqing Zhuo, Pan, Xinhui, linux-kernel,
Leon Huang, Daniel Vetter, Alex Deucher, Christian König
Le 17/05/2023 à 20:33, Hamza Mahfooz a écrit :
> get_available_dsc_slices() returns the number of indices set, and all of
> the users of get_available_dsc_slices() don't cross the returned bound
> when iterating over available_slices[]. So, the memset() in
> get_available_dsc_slices() is redundant and can be dropped.
>
> Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> index b9a05bb025db..58dd62cce4bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> @@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
> {
> int idx = 0;
>
> - memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
> -
> if (slice_caps.bits.NUM_SLICES_1)
> available_slices[idx++] = 1;
>
Thanks for it, it went off my radar.
FWIW:
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()
@ 2023-05-18 6:28 ` Marion & Christophe JAILLET
0 siblings, 0 replies; 23+ messages in thread
From: Marion & Christophe JAILLET @ 2023-05-18 6:28 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Qingqing Zhuo, Aurabindo Pillai, Hans de Goede, Hersen Wu,
Stylon Wang, Jun Lei, Wenjing Liu, Leon Huang, Mike Hsieh,
Cruise Hung, Nasir Osman, pengfuyuan, dri-devel, linux-kernel
Le 17/05/2023 à 20:33, Hamza Mahfooz a écrit :
> get_available_dsc_slices() returns the number of indices set, and all of
> the users of get_available_dsc_slices() don't cross the returned bound
> when iterating over available_slices[]. So, the memset() in
> get_available_dsc_slices() is redundant and can be dropped.
>
> Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> index b9a05bb025db..58dd62cce4bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> @@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
> {
> int idx = 0;
>
> - memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
> -
> if (slice_caps.bits.NUM_SLICES_1)
> available_slices[idx++] = 1;
>
Thanks for it, it went off my radar.
FWIW:
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices()
@ 2023-05-18 6:28 ` Marion & Christophe JAILLET
0 siblings, 0 replies; 23+ messages in thread
From: Marion & Christophe JAILLET @ 2023-05-18 6:28 UTC (permalink / raw)
To: Hamza Mahfooz, amd-gfx
Cc: Wenjing Liu, dri-devel, Jun Lei, Nasir Osman, Rodrigo Siqueira,
Aurabindo Pillai, Stylon Wang, Leo Li, pengfuyuan, Hersen Wu,
Cruise Hung, Mike Hsieh, Hans de Goede, Qingqing Zhuo,
Pan, Xinhui, linux-kernel, Leon Huang, Alex Deucher,
Christian König
Le 17/05/2023 à 20:33, Hamza Mahfooz a écrit :
> get_available_dsc_slices() returns the number of indices set, and all of
> the users of get_available_dsc_slices() don't cross the returned bound
> when iterating over available_slices[]. So, the memset() in
> get_available_dsc_slices() is redundant and can be dropped.
>
> Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)")
> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> index b9a05bb025db..58dd62cce4bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> @@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av
> {
> int idx = 0;
>
> - memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE);
> -
> if (slice_caps.bits.NUM_SLICES_1)
> available_slices[idx++] = 1;
>
Thanks for it, it went off my radar.
FWIW:
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
^ permalink raw reply [flat|nested] 23+ messages in thread