All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rohit Pidaparthi <rohitpid@gmail.com>
Cc: alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.com,
	luke@ljones.dev, sbinding@opensource.cirrus.com
Subject: Re: [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop
Date: Mon, 21 Aug 2023 12:45:11 +0200	[thread overview]
Message-ID: <87a5uk8yiw.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAGmPKz5OeC6UVBif6ySevZEvaY_XwKh7A29K7k_Yq_D0CQJkCA@mail.gmail.com>

On Sat, 19 Aug 2023 12:18:48 +0200,
Rohit Pidaparthi wrote:
> 
> >From 4f14cdad4f526f45747c4f0b71e24a46ebe3885c Mon Sep 17 00:00:00 2001
> From: Rohit Pidaparthi <rohitpid@gmail.com>
> Date: Sat, 19 Aug 2023 02:15:16 -0700
> Subject: [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop
> 
> The Asus Zenbook Pro 14 UX6404 (1043:1863) needs binding to the
> CS35L41 codec over spi1 rather than spi0. This is similar to
> existing quirks for many ASUS Laptops.
> 
> Signed-off-by: Rohit Pidaparthi <rohitpid@gmail.com>

The patch isn't applicable cleanly, likely your mailer broke the
tabs and spaces.  Could you resubmit properly?

Also, the quirk table entries are sorted in PCI SSID order.  Please
put the new entry at the right position.


thanks,

Takashi

> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index dc7b7a407638..c44464b1619f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9681,6 +9681,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>        SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022",
> ALC289_FIXUP_ASUS_GA401),
>        SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE),
>        SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402", ALC245_FIXUP_CS35L41_SPI_2),
> +     SND_PCI_QUIRK(0x1043, 0x1863, "ASUS UX6404", ALC245_FIXUP_CS35L41_SPI_2),
>        SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15",
> ALC289_FIXUP_ASUS_GA502),
>        SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
>        SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15",
> ALC294_FIXUP_ASUS_GU502_PINS),
> --
> 2.39.2
> 

  reply	other threads:[~2023-08-21 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19 10:18 [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop Rohit Pidaparthi
2023-08-21 10:45 ` Takashi Iwai [this message]
2023-08-23  8:35   ` Rohit Pidaparthi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5uk8yiw.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=luke@ljones.dev \
    --cc=perex@perex.cz \
    --cc=rohitpid@gmail.com \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.