[PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop

[PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop

[Rohit Pidaparthi]

>From 4f14cdad4f526f45747c4f0b71e24a46ebe3885c Mon Sep 17 00:00:00 2001
From: Rohit Pidaparthi <rohitpid@gmail.com>
Date: Sat, 19 Aug 2023 02:15:16 -0700
Subject: [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop

The Asus Zenbook Pro 14 UX6404 (1043:1863) needs binding to the
CS35L41 codec over spi1 rather than spi0. This is similar to
existing quirks for many ASUS Laptops.

Signed-off-by: Rohit Pidaparthi <rohitpid@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index dc7b7a407638..c44464b1619f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9681,6 +9681,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
       SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022",
ALC289_FIXUP_ASUS_GA401),
       SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE),
       SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402", ALC245_FIXUP_CS35L41_SPI_2),
+     SND_PCI_QUIRK(0x1043, 0x1863, "ASUS UX6404", ALC245_FIXUP_CS35L41_SPI_2),
       SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15",
ALC289_FIXUP_ASUS_GA502),
       SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
       SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15",
ALC294_FIXUP_ASUS_GU502_PINS),
--
2.39.2

Re: [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop

[Takashi Iwai]

On Sat, 19 Aug 2023 12:18:48 +0200,
Rohit Pidaparthi wrote:
> 
> >From 4f14cdad4f526f45747c4f0b71e24a46ebe3885c Mon Sep 17 00:00:00 2001
> From: Rohit Pidaparthi <rohitpid@gmail.com>
> Date: Sat, 19 Aug 2023 02:15:16 -0700
> Subject: [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop
> 
> The Asus Zenbook Pro 14 UX6404 (1043:1863) needs binding to the
> CS35L41 codec over spi1 rather than spi0. This is similar to
> existing quirks for many ASUS Laptops.
> 
> Signed-off-by: Rohit Pidaparthi <rohitpid@gmail.com>

The patch isn't applicable cleanly, likely your mailer broke the
tabs and spaces.  Could you resubmit properly?

Also, the quirk table entries are sorted in PCI SSID order.  Please
put the new entry at the right position.


thanks,

Takashi

> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index dc7b7a407638..c44464b1619f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9681,6 +9681,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>        SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022",
> ALC289_FIXUP_ASUS_GA401),
>        SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE),
>        SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402", ALC245_FIXUP_CS35L41_SPI_2),
> +     SND_PCI_QUIRK(0x1043, 0x1863, "ASUS UX6404", ALC245_FIXUP_CS35L41_SPI_2),
>        SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15",
> ALC289_FIXUP_ASUS_GA502),
>        SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
>        SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15",
> ALC294_FIXUP_ASUS_GU502_PINS),
> --
> 2.39.2
> 

Re: [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop

[Rohit Pidaparthi]

Dear Takashi,

Thanks for the feedback. I will submit a patch shortly, sorry for the delay.

Best,
Rohit

On Mon, Aug 21, 2023 at 3:45 AM Takashi Iwai <tiwai@suse.de> wrote:

> On Sat, 19 Aug 2023 12:18:48 +0200,
> Rohit Pidaparthi wrote:
> >
> > >From 4f14cdad4f526f45747c4f0b71e24a46ebe3885c Mon Sep 17 00:00:00 2001
> > From: Rohit Pidaparthi <rohitpid@gmail.com>
> > Date: Sat, 19 Aug 2023 02:15:16 -0700
> > Subject: [PATCH] fix: Add quirk for Asus Zenbook Pro 14 UX6404 laptop
> >
> > The Asus Zenbook Pro 14 UX6404 (1043:1863) needs binding to the
> > CS35L41 codec over spi1 rather than spi0. This is similar to
> > existing quirks for many ASUS Laptops.
> >
> > Signed-off-by: Rohit Pidaparthi <rohitpid@gmail.com>
>
> The patch isn't applicable cleanly, likely your mailer broke the
> tabs and spaces.  Could you resubmit properly?
>
> Also, the quirk table entries are sorted in PCI SSID order.  Please
> put the new entry at the right position.
>
>
> thanks,
>
> Takashi
>
> > ---
> > sound/pci/hda/patch_realtek.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c
> b/sound/pci/hda/patch_realtek.c
> > index dc7b7a407638..c44464b1619f 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -9681,6 +9681,7 @@ static const struct snd_pci_quirk
> alc269_fixup_tbl[] = {
> >        SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022",
> > ALC289_FIXUP_ASUS_GA401),
> >        SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420",
> ALC256_FIXUP_ASUS_HPE),
> >        SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402",
> ALC245_FIXUP_CS35L41_SPI_2),
> > +     SND_PCI_QUIRK(0x1043, 0x1863, "ASUS UX6404",
> ALC245_FIXUP_CS35L41_SPI_2),
> >        SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15",
> > ALC289_FIXUP_ASUS_GA502),
> >        SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402",
> ALC287_FIXUP_CS35L41_I2C_2),
> >        SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15",
> > ALC294_FIXUP_ASUS_GU502_PINS),
> > --
> > 2.39.2
> >
>