All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Heng Qi <hengqi@linux.alibaba.com>,
	virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org,
	Parav Pandit <parav@nvidia.com>,
	Alvaro Karsz <alvaro.karsz@solid-run.com>,
	David Edmondson <david.edmondson@oracle.com>,
	Jason Wang <jasowang@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-comment] Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation
Date: Tue, 11 Apr 2023 12:51:22 +0200	[thread overview]
Message-ID: <87a5zek7yt.fsf@redhat.com> (raw)
In-Reply-To: <20230411063059-mutt-send-email-mst@kernel.org>

On Tue, Apr 11 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Tue, Apr 11, 2023 at 10:05:11AM +0200, Cornelia Huck wrote:
>> On Thu, Mar 23 2023, Heng Qi <hengqi@linux.alibaba.com> wrote:
>> 
>> > Hi all! If after reviewing it you feel it meets the necessary 
>> > requirements, I kindly request a vote.
>> >
>> > Thanks a lot!
>> >
>> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/166
>> 
>> So this has been voted upon and accepted, but we have further discussion
>> downthread.
>> 
>> Should we merge the voted-upon version now and do further changes on
>> top, or wait for the discussion to conclude first so that we can merge
>> all of it in one go?
>
> I think we should merge as is. vqn/idx/id are not new discussions
> and have been going on before voting took place, so the TC
> was informed. Parav is working on making tree-wide changes
> around vq index applying this will not make his work
> measureably harder.

I had not looked at the discussion in detail and was unsure whether it
was covering something new... I went ahead and applied it.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Heng Qi <hengqi@linux.alibaba.com>,
	virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org,
	Parav Pandit <parav@nvidia.com>,
	Alvaro Karsz <alvaro.karsz@solid-run.com>,
	David Edmondson <david.edmondson@oracle.com>,
	Jason Wang <jasowang@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation
Date: Tue, 11 Apr 2023 12:51:22 +0200	[thread overview]
Message-ID: <87a5zek7yt.fsf@redhat.com> (raw)
In-Reply-To: <20230411063059-mutt-send-email-mst@kernel.org>

On Tue, Apr 11 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Tue, Apr 11, 2023 at 10:05:11AM +0200, Cornelia Huck wrote:
>> On Thu, Mar 23 2023, Heng Qi <hengqi@linux.alibaba.com> wrote:
>> 
>> > Hi all! If after reviewing it you feel it meets the necessary 
>> > requirements, I kindly request a vote.
>> >
>> > Thanks a lot!
>> >
>> > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/166
>> 
>> So this has been voted upon and accepted, but we have further discussion
>> downthread.
>> 
>> Should we merge the voted-upon version now and do further changes on
>> top, or wait for the discussion to conclude first so that we can merge
>> all of it in one go?
>
> I think we should merge as is. vqn/idx/id are not new discussions
> and have been going on before voting took place, so the TC
> was informed. Parav is working on making tree-wide changes
> around vq index applying this will not make his work
> measureably harder.

I had not looked at the discussion in detail and was unsure whether it
was covering something new... I went ahead and applied it.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-04-11 10:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 15:24 [virtio-comment] [PATCH v14] virtio-net: support the virtqueue coalescing moderation Heng Qi
2023-03-23 15:24 ` [virtio-dev] " Heng Qi
2023-03-23 15:38 ` [virtio-comment] " Heng Qi
2023-03-23 15:38   ` Heng Qi
2023-04-11  8:05   ` [virtio-comment] " Cornelia Huck
2023-04-11  8:05     ` Cornelia Huck
2023-04-11  8:42     ` [virtio-comment] " Heng Qi
2023-04-11  8:42       ` Heng Qi
2023-04-11 10:32     ` [virtio-comment] " Michael S. Tsirkin
2023-04-11 10:32       ` Michael S. Tsirkin
2023-04-11 10:51       ` Cornelia Huck [this message]
2023-04-11 10:51         ` Cornelia Huck
2023-04-04 16:29 ` [virtio-comment] " Halil Pasic
2023-04-04 16:29   ` Halil Pasic
2023-04-04 16:32   ` [virtio-comment] " Parav Pandit
2023-04-04 16:32     ` Parav Pandit
2023-04-04 17:44     ` [virtio-comment] " Michael S. Tsirkin
2023-04-04 17:44       ` Michael S. Tsirkin
2023-04-04 19:39       ` [virtio-comment] " Parav Pandit
2023-04-04 19:39         ` Parav Pandit
2023-04-04 20:14         ` [virtio-comment] " Michael S. Tsirkin
2023-04-04 20:14           ` Michael S. Tsirkin
2023-04-04 20:50           ` [virtio-comment] " Parav Pandit
2023-04-04 20:50             ` Parav Pandit
2023-04-05  9:12             ` [virtio-comment] " Michael S. Tsirkin
2023-04-05  9:12               ` Michael S. Tsirkin
2023-04-05 14:54               ` [virtio-comment] " Halil Pasic
2023-04-05 14:54                 ` Halil Pasic
2023-04-11 10:37                 ` [virtio-comment] " Michael S. Tsirkin
2023-04-11 10:37                   ` Michael S. Tsirkin
2023-04-07 11:45   ` [virtio-comment] " Michael S. Tsirkin
2023-04-07 11:45     ` [virtio-dev] " Michael S. Tsirkin
2023-04-10 13:33   ` Heng Qi
2023-04-10 13:33     ` Heng Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5zek7yt.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=alvaro.karsz@solid-run.com \
    --cc=david.edmondson@oracle.com \
    --cc=hengqi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.