All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>, Shuah Khan <shuah@kernel.org>,
	alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa - pcm-test: Don't include diagnostic message in test name
Date: Fri, 24 Mar 2023 07:50:54 +0100	[thread overview]
Message-ID: <87a602hcc1.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230323-alsa-pcm-test-names-v1-1-8be67a8885ff@kernel.org>

On Thu, 23 Mar 2023 19:48:28 +0100,
Mark Brown wrote:
> 
> When reporting errors or skips we currently include the diagnostic message
> indicating why we're failing or skipping. This isn't ideal since KTAP
> defines the entire print as the test name, so if there's an error then test
> systems won't detect the test as being the same one as a passing test. Move
> the diagnostic to a separate ksft_print_msg() to avoid this issue, the test
> name part will always be the same for passes, fails and skips and the
> diagnostic information is still displayed.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Thanks, applied now.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Shuah Khan <shuah@kernel.org>,
	alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa - pcm-test: Don't include diagnostic message in test name
Date: Fri, 24 Mar 2023 07:50:54 +0100	[thread overview]
Message-ID: <87a602hcc1.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230323-alsa-pcm-test-names-v1-1-8be67a8885ff@kernel.org>

On Thu, 23 Mar 2023 19:48:28 +0100,
Mark Brown wrote:
> 
> When reporting errors or skips we currently include the diagnostic message
> indicating why we're failing or skipping. This isn't ideal since KTAP
> defines the entire print as the test name, so if there's an error then test
> systems won't detect the test as being the same one as a passing test. Move
> the diagnostic to a separate ksft_print_msg() to avoid this issue, the test
> name part will always be the same for passes, fails and skips and the
> diagnostic information is still displayed.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Thanks, applied now.


Takashi

  reply	other threads:[~2023-03-24  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 18:48 [PATCH] kselftest/alsa - pcm-test: Don't include diagnostic message in test name Mark Brown
2023-03-24  6:50 ` Takashi Iwai [this message]
2023-03-24  6:50   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a602hcc1.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.