From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Greg KH" <gregkh@linuxfoundation.org>
Cc: Jim Cromie <jim.cromie@gmail.com>,
daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, jbaron@akamai.com,
seanpaul@chromium.org, dri-devel@lists.freedesktop.org,
joe@perches.com, intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation
Date: Fri, 21 Oct 2022 12:18:17 +0300 [thread overview]
Message-ID: <87a65pfsbq.fsf@intel.com> (raw)
In-Reply-To: <Y1Fyuh12g/gt3Izn@intel.com>
On Thu, 20 Oct 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Sat, Sep 24, 2022 at 03:02:34PM +0200, Greg KH wrote:
>> On Sun, Sep 11, 2022 at 11:28:43PM -0600, Jim Cromie wrote:
>> > hi Greg, Dan, Jason, DRM-folk,
>> >
>> > heres follow-up to V6:
>> > rebased on driver-core/driver-core-next for -v6 applied bits (thanks)
>> > rework drm_debug_enabled{_raw,_instrumented,} per Dan.
>> >
>> > It excludes:
>> > nouveau parts (immature)
>> > tracefs parts (I missed --to=Steve on v6)
>> > split _ddebug_site and de-duplicate experiment (way unready)
>> >
>> > IOW, its the remaining commits of V6 on which Dan gave his Reviewed-by.
>> >
>> > If these are good to apply, I'll rebase and repost the rest separately.
>>
>> All now queued up, thanks.
>
> This stuff broke i915 debugs. When I first load i915 no debug prints are
> produced. If I then go fiddle around in /sys/module/drm/parameters/debug
> the debug prints start to suddenly work.
Wait what? I always assumed the default behaviour would stay the same,
which is usually how we roll. It's a regression in my books. We've got a
CI farm that's not very helpful in terms of dmesg logging right now
because of this.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Greg KH" <gregkh@linuxfoundation.org>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, jbaron@akamai.com,
seanpaul@chromium.org, dri-devel@lists.freedesktop.org,
joe@perches.com, intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v7 0/9] dyndbg: drm.debug adaptation
Date: Fri, 21 Oct 2022 12:18:17 +0300 [thread overview]
Message-ID: <87a65pfsbq.fsf@intel.com> (raw)
In-Reply-To: <Y1Fyuh12g/gt3Izn@intel.com>
On Thu, 20 Oct 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Sat, Sep 24, 2022 at 03:02:34PM +0200, Greg KH wrote:
>> On Sun, Sep 11, 2022 at 11:28:43PM -0600, Jim Cromie wrote:
>> > hi Greg, Dan, Jason, DRM-folk,
>> >
>> > heres follow-up to V6:
>> > rebased on driver-core/driver-core-next for -v6 applied bits (thanks)
>> > rework drm_debug_enabled{_raw,_instrumented,} per Dan.
>> >
>> > It excludes:
>> > nouveau parts (immature)
>> > tracefs parts (I missed --to=Steve on v6)
>> > split _ddebug_site and de-duplicate experiment (way unready)
>> >
>> > IOW, its the remaining commits of V6 on which Dan gave his Reviewed-by.
>> >
>> > If these are good to apply, I'll rebase and repost the rest separately.
>>
>> All now queued up, thanks.
>
> This stuff broke i915 debugs. When I first load i915 no debug prints are
> produced. If I then go fiddle around in /sys/module/drm/parameters/debug
> the debug prints start to suddenly work.
Wait what? I always assumed the default behaviour would stay the same,
which is usually how we roll. It's a regression in my books. We've got a
CI farm that's not very helpful in terms of dmesg logging right now
because of this.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-10-21 9:18 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 5:28 [PATCH v7 0/9] dyndbg: drm.debug adaptation Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 5:28 ` [PATCH v7 1/9] drm_print: condense enum drm_debug_category Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 10:17 ` Jani Nikula
2022-09-12 10:17 ` Jani Nikula
2022-09-12 10:17 ` [Intel-gfx] " Jani Nikula
2022-09-13 15:57 ` jim.cromie
2022-09-13 15:57 ` jim.cromie
2022-09-13 15:57 ` [Intel-gfx] " jim.cromie
2022-09-12 5:28 ` [PATCH v7 2/9] drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 10:29 ` Jani Nikula
2022-09-12 10:29 ` Jani Nikula
2022-09-12 10:29 ` [Intel-gfx] " Jani Nikula
2022-09-12 21:11 ` jim.cromie
2022-09-12 21:11 ` jim.cromie
2022-09-12 21:11 ` [Intel-gfx] " jim.cromie
2022-09-12 5:28 ` [PATCH v7 3/9] drm_print: interpose drm_*dbg with forwarding macros Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 5:28 ` [PATCH v7 4/9] drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 5:28 ` [PATCH v7 5/9] drm-print.h: include dyndbg header Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 5:28 ` [PATCH v7 6/9] drm-print: add drm_dbg_driver to improve namespace symmetry Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 5:28 ` [PATCH v7 7/9] drm_print: optimize drm_debug_enabled for jump-label Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 5:28 ` [PATCH v7 8/9] drm_print: prefer bare printk KERN_DEBUG on generic fn Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 5:28 ` [PATCH v7 9/9] drm_print: add _ddebug descriptor to drm_*dbg prototypes Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` Jim Cromie
2022-09-12 5:28 ` [Intel-gfx] " Jim Cromie
2022-09-12 5:37 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for dyndbg: drm.debug adaptation Patchwork
2022-09-24 13:02 ` [PATCH v7 0/9] " Greg KH
2022-09-24 13:02 ` Greg KH
2022-09-24 13:02 ` Greg KH
2022-09-24 13:02 ` [Intel-gfx] " Greg KH
2022-10-20 16:09 ` Ville Syrjälä
2022-10-20 16:09 ` Ville Syrjälä
2022-10-20 16:09 ` [Intel-gfx] " Ville Syrjälä
2022-10-21 9:18 ` Jani Nikula [this message]
2022-10-21 9:18 ` Jani Nikula
2022-10-27 15:08 ` Jason Baron
2022-10-27 15:08 ` Jason Baron
2022-10-27 15:37 ` jim.cromie
2022-10-27 15:37 ` jim.cromie
2022-10-27 15:37 ` jim.cromie
2022-10-27 15:58 ` Ville Syrjälä
2022-10-27 15:58 ` Ville Syrjälä
2022-10-27 15:58 ` Ville Syrjälä
2022-10-27 19:55 ` jim.cromie
2022-10-27 19:55 ` jim.cromie
2022-10-27 19:55 ` jim.cromie
2022-10-27 20:09 ` Ville Syrjälä
2022-10-27 20:09 ` Ville Syrjälä
2022-10-27 20:09 ` Ville Syrjälä
2022-10-30 14:42 ` jim.cromie
2022-10-30 14:42 ` jim.cromie
2022-10-30 14:42 ` jim.cromie
2022-10-31 13:07 ` Ville Syrjälä
2022-10-31 13:07 ` Ville Syrjälä
2022-10-31 13:07 ` Ville Syrjälä
2022-10-31 22:11 ` jim.cromie
2022-10-31 22:11 ` jim.cromie
2022-10-31 22:11 ` jim.cromie
2022-11-01 0:20 ` Jason Baron
2022-11-01 0:20 ` Jason Baron
2022-11-01 0:20 ` Jason Baron
2022-11-01 8:52 ` Ville Syrjälä
2022-11-01 8:52 ` Ville Syrjälä
2022-11-01 8:52 ` Ville Syrjälä
2022-11-01 8:52 ` Ville Syrjälä
2022-11-01 13:09 ` jim.cromie
2022-11-01 13:09 ` jim.cromie
2022-11-01 13:09 ` jim.cromie
2022-11-11 22:17 ` [PATCH 0/7] DYNAMIC_DEBUG fixups for rc Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` [Intel-gfx] " Jim Cromie
2022-11-11 22:17 ` [PATCH 1/7] drm: mark drm.debug-on-dyndbg as BROKEN for now Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` [Intel-gfx] " Jim Cromie
2022-11-14 12:20 ` Ville Syrjälä
2022-11-14 12:20 ` Ville Syrjälä
2022-11-17 6:29 ` Greg KH
2022-11-17 6:29 ` Greg KH
2022-11-17 6:29 ` Greg KH
2022-11-17 6:29 ` [Intel-gfx] " Greg KH
2022-11-11 22:17 ` [PATCH 2/7] drm_print: fixup improve stale comment Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` [Intel-gfx] " Jim Cromie
2022-11-11 22:17 ` [PATCH 3/7] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` [Intel-gfx] " Jim Cromie
2022-11-11 22:17 ` [PATCH 4/7] test-dyndbg: show that DEBUG enables prdbgs at compiletime Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` [Intel-gfx] " Jim Cromie
2022-11-11 22:17 ` [PATCH 5/7] dyndbg: fix readback value on LEVEL_NAMES interfaces Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` [Intel-gfx] " Jim Cromie
2022-11-11 22:17 ` [PATCH 6/7] dyndbg: clone DECLARE_DYNDBG_CLASSMAP to REFERENCE_DYNDBG_CLASSMAP Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` [Intel-gfx] " Jim Cromie
2022-11-11 22:17 ` [PATCH 7/7] dyndbg: replace classmap list with a vector Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` Jim Cromie
2022-11-11 22:17 ` [Intel-gfx] " Jim Cromie
2022-11-17 6:29 ` [PATCH 0/7] DYNAMIC_DEBUG fixups for rc Greg KH
2022-11-17 6:29 ` Greg KH
2022-11-17 6:29 ` Greg KH
2022-11-17 6:29 ` [Intel-gfx] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a65pfsbq.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.