All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915/hwmon: Add HWMON energy support
Date: Mon, 20 Jun 2022 23:41:50 -0700	[thread overview]
Message-ID: <87a6a6v7pt.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <e05838e5-979a-8561-174d-e06a50afafb9@roeck-us.net>

On Mon, 20 Jun 2022 14:04:53 -0700, Guenter Roeck wrote:
>
> > @@ -141,9 +282,12 @@ i915_power1_max_default_show(struct device *dev, struct device_attribute *attr,
> >     static SENSOR_DEVICE_ATTR(power1_max_default, 0444,
> >			  i915_power1_max_default_show, NULL, 0);
> > +static SENSOR_DEVICE_ATTR(energy1_input, 0444,
> > +			  i915_energy1_input_show, NULL, 0);
> >     static struct attribute *hwmon_attributes[] = {
> >	&sensor_dev_attr_power1_max_default.dev_attr.attr,
> > +	&sensor_dev_attr_energy1_input.dev_attr.attr,
>
> Why not use HWMON_E_INPUT ?

Agreed, we will investigate switching to this. I also had a similar comment
about this here:

https://patchwork.freedesktop.org/patch/487020/?series=104278&rev=1

Thanks.
--
Ashutosh

WARNING: multiple messages have this Message-ID (diff)
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Badal Nilawar <badal.nilawar@intel.com>,
	intel-gfx@lists.freedesktop.org, anshuman.gupta@intel.com,
	jon.ewins@intel.com, riana.tauro@intel.com,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/i915/hwmon: Add HWMON energy support
Date: Mon, 20 Jun 2022 23:41:50 -0700	[thread overview]
Message-ID: <87a6a6v7pt.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <e05838e5-979a-8561-174d-e06a50afafb9@roeck-us.net>

On Mon, 20 Jun 2022 14:04:53 -0700, Guenter Roeck wrote:
>
> > @@ -141,9 +282,12 @@ i915_power1_max_default_show(struct device *dev, struct device_attribute *attr,
> >     static SENSOR_DEVICE_ATTR(power1_max_default, 0444,
> >			  i915_power1_max_default_show, NULL, 0);
> > +static SENSOR_DEVICE_ATTR(energy1_input, 0444,
> > +			  i915_energy1_input_show, NULL, 0);
> >     static struct attribute *hwmon_attributes[] = {
> >	&sensor_dev_attr_power1_max_default.dev_attr.attr,
> > +	&sensor_dev_attr_energy1_input.dev_attr.attr,
>
> Why not use HWMON_E_INPUT ?

Agreed, we will investigate switching to this. I also had a similar comment
about this here:

https://patchwork.freedesktop.org/patch/487020/?series=104278&rev=1

Thanks.
--
Ashutosh

  reply	other threads:[~2022-06-21  6:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20 20:46 [Intel-gfx] [PATCH 0/4] drm/i915: Add HWMON support Badal Nilawar
2022-06-20 20:46 ` Badal Nilawar
2022-06-20 20:46 ` [Intel-gfx] [PATCH 1/4] drm/i915/hwmon: Add HWMON infrastructure patch Badal Nilawar
2022-06-20 20:46   ` Badal Nilawar
2022-06-20 20:46 ` [Intel-gfx] [PATCH 2/4] drm/i915/hwmon: Add HWMON current voltage support Badal Nilawar
2022-06-20 20:46   ` Badal Nilawar
2022-06-20 21:06   ` [Intel-gfx] " Guenter Roeck
2022-06-20 21:06     ` Guenter Roeck
2022-06-20 20:46 ` [Intel-gfx] [PATCH 3/4] drm/i915/hwmon: Add HWMON power sensor support Badal Nilawar
2022-06-20 20:46   ` Badal Nilawar
2022-06-20 20:58   ` [Intel-gfx] " Guenter Roeck
2022-06-20 20:58     ` Guenter Roeck
2022-06-21  6:41     ` [Intel-gfx] " Dixit, Ashutosh
2022-06-21  6:41       ` Dixit, Ashutosh
2022-06-21 17:44       ` [Intel-gfx] " Guenter Roeck
2022-06-21 17:44         ` Guenter Roeck
2022-06-21 19:29         ` [Intel-gfx] " Dixit, Ashutosh
2022-06-21 19:29           ` Dixit, Ashutosh
2022-06-21 21:26           ` [Intel-gfx] " Guenter Roeck
2022-06-21 21:26             ` Guenter Roeck
2022-06-20 20:46 ` [Intel-gfx] [PATCH 4/4] drm/i915/hwmon: Add HWMON energy support Badal Nilawar
2022-06-20 20:46   ` Badal Nilawar
2022-06-20 21:04   ` [Intel-gfx] " Guenter Roeck
2022-06-20 21:04     ` Guenter Roeck
2022-06-21  6:41     ` Dixit, Ashutosh [this message]
2022-06-21  6:41       ` Dixit, Ashutosh
2022-06-21  0:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add HWMON support (rev2) Patchwork
2022-06-21  0:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-06-21 16:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6a6v7pt.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.