All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Anilkumar Kolli <akolli@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Seevalamuthu Mariappan <seevalam@codeaurora.org>
Subject: Re: [PATCH v2] ath11k: Change qcn9074 fw to operate in mode-2
Date: Thu, 09 Dec 2021 12:36:28 +0200	[thread overview]
Message-ID: <87a6ha3w0j.fsf@codeaurora.org> (raw)
In-Reply-To: <1638971390-7160-1-git-send-email-akolli@codeaurora.org> (Anilkumar Kolli's message of "Wed, 8 Dec 2021 19:19:50 +0530")

Anilkumar Kolli <akolli@codeaurora.org> writes:

> From: Seevalamuthu Mariappan <seevalam@codeaurora.org>
>
> In mode-2 QCN9074 firmware uses 15MB of host memory and firmware
> request 1MB size segements in QMI, whereas in mode-0 firmware
> uses 45MB of host memory and each segment is of 2MB size.
> In mode-2 firmware operates with reduced number of vdevs and peers.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01838-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Seevalamuthu Mariappan <seevalam@codeaurora.org>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>

[...]

> --- a/drivers/net/wireless/ath/ath11k/hw.h
> +++ b/drivers/net/wireless/ath/ath11k/hw.h
> @@ -12,9 +12,9 @@
>  /* Target configuration defines */
>  
>  /* Num VDEVS per radio */
> -#define TARGET_NUM_VDEVS	(16 + 1)
> +#define TARGET_NUM_VDEVS	(ab->hw_params.num_vdevs)
>  
> -#define TARGET_NUM_PEERS_PDEV	(512 + TARGET_NUM_VDEVS)
> +#define TARGET_NUM_PEERS_PDEV	(ab->hw_params.num_peers + TARGET_NUM_VDEVS)
>  
>  /* Num of peers for Single Radio mode */
>  #define TARGET_NUM_PEERS_SINGLE		(TARGET_NUM_PEERS_PDEV)
> @@ -26,7 +26,7 @@
>  #define TARGET_NUM_PEERS_DBS_SBS	(3 * TARGET_NUM_PEERS_PDEV)
>  
>  /* Max num of stations (per radio) */
> -#define TARGET_NUM_STATIONS	512
> +#define TARGET_NUM_STATIONS	(ab->hw_params.num_peers)

Don't know how I missed this previously, but the macros should be
converted to FOO(ab). I'll send v3.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Anilkumar Kolli <akolli@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Seevalamuthu Mariappan <seevalam@codeaurora.org>
Subject: Re: [PATCH v2] ath11k: Change qcn9074 fw to operate in mode-2
Date: Thu, 09 Dec 2021 12:36:28 +0200	[thread overview]
Message-ID: <87a6ha3w0j.fsf@codeaurora.org> (raw)
In-Reply-To: <1638971390-7160-1-git-send-email-akolli@codeaurora.org> (Anilkumar Kolli's message of "Wed, 8 Dec 2021 19:19:50 +0530")

Anilkumar Kolli <akolli@codeaurora.org> writes:

> From: Seevalamuthu Mariappan <seevalam@codeaurora.org>
>
> In mode-2 QCN9074 firmware uses 15MB of host memory and firmware
> request 1MB size segements in QMI, whereas in mode-0 firmware
> uses 45MB of host memory and each segment is of 2MB size.
> In mode-2 firmware operates with reduced number of vdevs and peers.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01838-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Seevalamuthu Mariappan <seevalam@codeaurora.org>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>

[...]

> --- a/drivers/net/wireless/ath/ath11k/hw.h
> +++ b/drivers/net/wireless/ath/ath11k/hw.h
> @@ -12,9 +12,9 @@
>  /* Target configuration defines */
>  
>  /* Num VDEVS per radio */
> -#define TARGET_NUM_VDEVS	(16 + 1)
> +#define TARGET_NUM_VDEVS	(ab->hw_params.num_vdevs)
>  
> -#define TARGET_NUM_PEERS_PDEV	(512 + TARGET_NUM_VDEVS)
> +#define TARGET_NUM_PEERS_PDEV	(ab->hw_params.num_peers + TARGET_NUM_VDEVS)
>  
>  /* Num of peers for Single Radio mode */
>  #define TARGET_NUM_PEERS_SINGLE		(TARGET_NUM_PEERS_PDEV)
> @@ -26,7 +26,7 @@
>  #define TARGET_NUM_PEERS_DBS_SBS	(3 * TARGET_NUM_PEERS_PDEV)
>  
>  /* Max num of stations (per radio) */
> -#define TARGET_NUM_STATIONS	512
> +#define TARGET_NUM_STATIONS	(ab->hw_params.num_peers)

Don't know how I missed this previously, but the macros should be
converted to FOO(ab). I'll send v3.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2021-12-09 10:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 13:49 [PATCH v2] ath11k: Change qcn9074 fw to operate in mode-2 Anilkumar Kolli
2021-12-08 13:49 ` Anilkumar Kolli
2021-12-09 10:36 ` Kalle Valo [this message]
2021-12-09 10:36   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6ha3w0j.fsf@codeaurora.org \
    --to=kvalo@kernel.org \
    --cc=akolli@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=seevalam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.