Re: [PATCH v5 01/14] irqchip: Provide platform_device to of_irq_init_cb_t

From: Marc Zyngier <maz@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM
	BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...),
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	linux-arm-kernel@lists.infradead.org (moderated list:ARM
	SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS),
	devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
	FLATTENED DEVICE TREE)
Subject: Re: [PATCH v5 01/14] irqchip: Provide platform_device to of_irq_init_cb_t
Date: Wed, 20 Oct 2021 11:56:06 +0100	[thread overview]
Message-ID: <87a6j4c6d5.wl-maz@kernel.org> (raw)
In-Reply-To: <20211019215855.1920099-2-f.fainelli@gmail.com>

AOn Tue, 19 Oct 2021 22:58:42 +0100,
Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
> Provide the platform device mapping to the interrupt controller node to
> the of_irq_init_cb_t callback such that drivers can make use of it.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/irqchip/irqchip.c  | 2 +-
>  drivers/irqchip/qcom-pdc.c | 3 ++-
>  drivers/of/irq.c           | 2 +-
>  include/linux/of_irq.h     | 5 ++++-
>  4 files changed, 8 insertions(+), 4 deletions(-)
>

[...]

> diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
> index aaf219bd0354..89acc8b089f0 100644
> --- a/include/linux/of_irq.h
> +++ b/include/linux/of_irq.h
> @@ -9,7 +9,10 @@
>  #include <linux/ioport.h>
>  #include <linux/of.h>
>  
> -typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *);
> +struct platform_device;
> +
> +typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *,
> +				struct platform_device *);
>  
>  /*
>   * Workarounds only applied to 32bit powermac machines

As pointed out in my reply to your v4 [1], this does break all users
of IRQCHIP_DECLARE(). You can see that by applying [2].

	M.

[1] https://lore.kernel.org/r/87tuhcnlwt.wl-maz@kernel.org
[2] https://lore.kernel.org/r/20211020104527.3066268-1-maz@kernel.org

-- 
Without deviation from the norm, progress is not possible.