All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, Laurent Vivier <lvivier@redhat.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org,
	linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v2 1/7] README.md: add guideline for header guards format
Date: Wed, 09 Jun 2021 15:19:06 +0000	[thread overview]
Message-ID: <87a6nz12xh.fsf@redhat.com> (raw)
In-Reply-To: <4884a501-939e-a343-7cb3-a31d2f59914f@redhat.com>

On Wed, Jun 09 2021, David Hildenbrand <david@redhat.com> wrote:

> On 09.06.21 16:37, Cornelia Huck wrote:
>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>> ---
>>   README.md | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>> 
>> diff --git a/README.md b/README.md
>> index 24d4bdaaee0d..687ff50d0af1 100644
>> --- a/README.md
>> +++ b/README.md
>> @@ -156,6 +156,15 @@ Exceptions:
>>   
>>     - While the kernel standard requires 80 columns, we allow up to 120.
>>   
>> +Header guards:
>> +
>> +Please try to adhere to adhere to the following patterns when adding
>> +"#ifndef <...> #define <...>" header guards:
>> +    ./lib:             _HEADER_H_
>> +    ./lib/<ARCH>:      _ARCH_HEADER_H_
>> +    ./lib/<ARCH>/asm:  _ASMARCH_HEADER_H_
>
> I'd have used _ARCH_ASM_HEADER_H_

I had that first, but the pattern I ended up using caused way less churn
(this is basically what arm[64] uses.)

>
> Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
	linux-s390@vger.kernel.org, Janosch Frank <frankja@linux.ibm.com>,
	kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH v2 1/7] README.md: add guideline for header guards format
Date: Wed, 09 Jun 2021 17:19:06 +0200	[thread overview]
Message-ID: <87a6nz12xh.fsf@redhat.com> (raw)
In-Reply-To: <4884a501-939e-a343-7cb3-a31d2f59914f@redhat.com>

On Wed, Jun 09 2021, David Hildenbrand <david@redhat.com> wrote:

> On 09.06.21 16:37, Cornelia Huck wrote:
>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>> ---
>>   README.md | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>> 
>> diff --git a/README.md b/README.md
>> index 24d4bdaaee0d..687ff50d0af1 100644
>> --- a/README.md
>> +++ b/README.md
>> @@ -156,6 +156,15 @@ Exceptions:
>>   
>>     - While the kernel standard requires 80 columns, we allow up to 120.
>>   
>> +Header guards:
>> +
>> +Please try to adhere to adhere to the following patterns when adding
>> +"#ifndef <...> #define <...>" header guards:
>> +    ./lib:             _HEADER_H_
>> +    ./lib/<ARCH>:      _ARCH_HEADER_H_
>> +    ./lib/<ARCH>/asm:  _ASMARCH_HEADER_H_
>
> I'd have used _ARCH_ASM_HEADER_H_

I had that first, but the pattern I ended up using caused way less churn
(this is basically what arm[64] uses.)

>
> Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks!

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>, Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, Laurent Vivier <lvivier@redhat.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org,
	linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v2 1/7] README.md: add guideline for header guards format
Date: Wed, 09 Jun 2021 17:19:06 +0200	[thread overview]
Message-ID: <87a6nz12xh.fsf@redhat.com> (raw)
In-Reply-To: <4884a501-939e-a343-7cb3-a31d2f59914f@redhat.com>

On Wed, Jun 09 2021, David Hildenbrand <david@redhat.com> wrote:

> On 09.06.21 16:37, Cornelia Huck wrote:
>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>> ---
>>   README.md | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>> 
>> diff --git a/README.md b/README.md
>> index 24d4bdaaee0d..687ff50d0af1 100644
>> --- a/README.md
>> +++ b/README.md
>> @@ -156,6 +156,15 @@ Exceptions:
>>   
>>     - While the kernel standard requires 80 columns, we allow up to 120.
>>   
>> +Header guards:
>> +
>> +Please try to adhere to adhere to the following patterns when adding
>> +"#ifndef <...> #define <...>" header guards:
>> +    ./lib:             _HEADER_H_
>> +    ./lib/<ARCH>:      _ARCH_HEADER_H_
>> +    ./lib/<ARCH>/asm:  _ASMARCH_HEADER_H_
>
> I'd have used _ARCH_ASM_HEADER_H_

I had that first, but the pattern I ended up using caused way less churn
(this is basically what arm[64] uses.)

>
> Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks!


  reply	other threads:[~2021-06-09 15:19 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 14:37 [kvm-unit-tests PATCH v2 0/7] unify header guards Cornelia Huck
2021-06-09 14:37 ` Cornelia Huck
2021-06-09 14:37 ` Cornelia Huck
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 1/7] README.md: add guideline for header guards format Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:45   ` David Hildenbrand
2021-06-09 14:45     ` David Hildenbrand
2021-06-09 14:45     ` David Hildenbrand
2021-06-09 15:19     ` Cornelia Huck [this message]
2021-06-09 15:19       ` Cornelia Huck
2021-06-09 15:19       ` Cornelia Huck
2021-06-09 15:00   ` Laurent Vivier
2021-06-09 15:00     ` Laurent Vivier
2021-06-09 15:00     ` Laurent Vivier
2021-06-14  9:01   ` Andrew Jones
2021-06-14  9:01     ` Andrew Jones
2021-06-14  9:01     ` Andrew Jones
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 2/7] lib: unify header guards Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:45   ` David Hildenbrand
2021-06-09 14:45     ` David Hildenbrand
2021-06-09 14:45     ` David Hildenbrand
2021-06-09 15:13   ` Laurent Vivier
2021-06-09 15:13     ` Laurent Vivier
2021-06-09 15:13     ` Laurent Vivier
2021-06-09 15:37     ` Cornelia Huck
2021-06-09 15:37       ` Cornelia Huck
2021-06-09 15:37       ` Cornelia Huck
2021-06-09 15:49       ` Laurent Vivier
2021-06-09 15:49         ` Laurent Vivier
2021-06-09 15:49         ` Laurent Vivier
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 3/7] asm-generic: " Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:46   ` David Hildenbrand
2021-06-09 14:46     ` David Hildenbrand
2021-06-09 14:46     ` David Hildenbrand
2021-06-09 15:15   ` Laurent Vivier
2021-06-09 15:15     ` Laurent Vivier
2021-06-09 15:15     ` Laurent Vivier
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 4/7] arm: " Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:46   ` David Hildenbrand
2021-06-09 14:46     ` David Hildenbrand
2021-06-09 14:46     ` David Hildenbrand
2021-06-09 15:24   ` Laurent Vivier
2021-06-09 15:24     ` Laurent Vivier
2021-06-09 15:24     ` Laurent Vivier
2021-06-09 15:47     ` Cornelia Huck
2021-06-09 15:47       ` Cornelia Huck
2021-06-09 15:47       ` Cornelia Huck
2021-06-09 15:51       ` Laurent Vivier
2021-06-09 15:51         ` Laurent Vivier
2021-06-09 15:51         ` Laurent Vivier
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 5/7] powerpc: " Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:47   ` David Hildenbrand
2021-06-09 14:47     ` David Hildenbrand
2021-06-09 14:47     ` David Hildenbrand
2021-06-09 14:59   ` Laurent Vivier
2021-06-09 14:59     ` Laurent Vivier
2021-06-09 14:59     ` Laurent Vivier
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 6/7] s390x: " Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:48   ` David Hildenbrand
2021-06-09 14:48     ` David Hildenbrand
2021-06-09 14:48     ` David Hildenbrand
2021-06-09 14:37 ` [kvm-unit-tests PATCH v2 7/7] x86: " Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:37   ` Cornelia Huck
2021-06-09 14:49   ` David Hildenbrand
2021-06-09 14:49     ` David Hildenbrand
2021-06-09 14:49     ` David Hildenbrand
2021-06-10 12:17 ` [kvm-unit-tests PATCH v2 0/7] " Paolo Bonzini
2021-06-10 12:17   ` Paolo Bonzini
2021-06-10 12:17   ` Paolo Bonzini
2021-06-10 13:04   ` Cornelia Huck
2021-06-10 13:04     ` Cornelia Huck
2021-06-10 13:04     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6nz12xh.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=drjones@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-s390@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.