From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: kernel test robot <lkp@intel.com>,
Balbir Singh <sblbir@amazon.com>,
kbuild-all@lists.01.org,
Sparse Mailing-list <linux-sparse@vger.kernel.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: Re: [tglx-devel:x86/l1dflush 7/9] arch/x86/mm/tlb.c:354:13: sparse: sparse: incorrect type in initializer (different address spaces)
Date: Tue, 27 Apr 2021 21:54:01 +0200 [thread overview]
Message-ID: <87a6pjo65i.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAHk-=wiJ7_LCn19AGj+8mS5bV1jr4S1_6errsnfoZc0PdCNp9A@mail.gmail.com>
On Tue, Apr 27 2021 at 10:00, Linus Torvalds wrote:
> On Mon, Apr 26, 2021 at 11:37 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>> > > 354 if (this_cpu_read(cpu_info.smt_active)) {
>>
>> That's a valid construct and the kernel of full of percpuvar.member reads/writes.
>
> Hmm. "cpu_info" doesn't seem to be marked as a percpu data structure.
>
> Is this perhaps a UP config? Because we have:
>
> extern struct cpuinfo_x86 boot_cpu_data;
> ...
> #ifdef CONFIG_SMP
> DECLARE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info);
> #define cpu_data(cpu) per_cpu(cpu_info, cpu)
> #else
> #define cpu_info boot_cpu_data
> #define cpu_data(cpu) boot_cpu_data
> #endif
>
> and notice how if CONFIG_SMP isn't set, 'cpu_info' just turns into a
> regular non-percpu thing.
>
> But the sparse checking doesn't go away just because it's compiled for UP.
Duh yes. I'm a moron.
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: kbuild-all@lists.01.org
Subject: Re: [tglx-devel:x86/l1dflush 7/9] arch/x86/mm/tlb.c:354:13: sparse: sparse: incorrect type in initializer (different address spaces)
Date: Tue, 27 Apr 2021 21:54:01 +0200 [thread overview]
Message-ID: <87a6pjo65i.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAHk-=wiJ7_LCn19AGj+8mS5bV1jr4S1_6errsnfoZc0PdCNp9A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Tue, Apr 27 2021 at 10:00, Linus Torvalds wrote:
> On Mon, Apr 26, 2021 at 11:37 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>> > > 354 if (this_cpu_read(cpu_info.smt_active)) {
>>
>> That's a valid construct and the kernel of full of percpuvar.member reads/writes.
>
> Hmm. "cpu_info" doesn't seem to be marked as a percpu data structure.
>
> Is this perhaps a UP config? Because we have:
>
> extern struct cpuinfo_x86 boot_cpu_data;
> ...
> #ifdef CONFIG_SMP
> DECLARE_PER_CPU_READ_MOSTLY(struct cpuinfo_x86, cpu_info);
> #define cpu_data(cpu) per_cpu(cpu_info, cpu)
> #else
> #define cpu_info boot_cpu_data
> #define cpu_data(cpu) boot_cpu_data
> #endif
>
> and notice how if CONFIG_SMP isn't set, 'cpu_info' just turns into a
> regular non-percpu thing.
>
> But the sparse checking doesn't go away just because it's compiled for UP.
Duh yes. I'm a moron.
next prev parent reply other threads:[~2021-04-27 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 3:00 [tglx-devel:x86/l1dflush 7/9] arch/x86/mm/tlb.c:354:13: sparse: sparse: incorrect type in initializer (different address spaces) kernel test robot
2021-04-27 6:37 ` Thomas Gleixner
2021-04-27 6:37 ` Thomas Gleixner
2021-04-27 17:00 ` Linus Torvalds
2021-04-27 17:00 ` Linus Torvalds
2021-04-27 19:23 ` Luc Van Oostenryck
2021-04-27 19:23 ` Luc Van Oostenryck
2021-04-27 19:54 ` Thomas Gleixner [this message]
2021-04-27 19:54 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6pjo65i.ffs@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=sblbir@amazon.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.