* Re: [PATCH v2 02/15] usb: dwc2: Add support for dwc2 host/device clock gating.
[not found] <20201011135122.71764A0061@mailhost.synopsys.com>
@ 2020-10-27 8:22 ` Felipe Balbi
2020-10-27 10:26 ` Artur Petrosyan
0 siblings, 1 reply; 2+ messages in thread
From: Felipe Balbi @ 2020-10-27 8:22 UTC (permalink / raw)
To: Artur Petrosyan, Greg Kroah-Hartman, Minas Harutyunyan, linux-usb
Cc: John Youn, Artur Petrosyan
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Artur Petrosyan <Arthur.Petrosyan@synopsys.com> writes:
> If core doesn't support hibernation or partial power
> down power saving options, you can still use clock
> gating on all the clocks to reduce power consumption
> considerably.
>
> - Added control functions for dwc2 host/device mode clock gating.
> - Moved "bus_suspended" flag to "dwc2_hsotg" struct because we
> need to set that flag in case when the driver is built in
> peripheral mode.
similarly to previous patch, it seems like this could be broken down
into two or more patches. Think about doing really small, incremental
changes that are obviously correct.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 02/15] usb: dwc2: Add support for dwc2 host/device clock gating.
2020-10-27 8:22 ` [PATCH v2 02/15] usb: dwc2: Add support for dwc2 host/device clock gating Felipe Balbi
@ 2020-10-27 10:26 ` Artur Petrosyan
0 siblings, 0 replies; 2+ messages in thread
From: Artur Petrosyan @ 2020-10-27 10:26 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Minas Harutyunyan,
linux-usb@vger.kernel.org
Cc: John Youn
Hi Felipe,
On 10/27/2020 12:22, Felipe Balbi wrote:
> Artur Petrosyan <Arthur.Petrosyan@synopsys.com> writes:
>
>> If core doesn't support hibernation or partial power
>> down power saving options, you can still use clock
>> gating on all the clocks to reduce power consumption
>> considerably.
>>
>> - Added control functions for dwc2 host/device mode clock gating.
>> - Moved "bus_suspended" flag to "dwc2_hsotg" struct because we
>> need to set that flag in case when the driver is built in
>> peripheral mode.
>
> similarly to previous patch, it seems like this could be broken down
> into two or more patches. Think about doing really small, incremental
> changes that are obviously correct.
>
Ok sure thank you very much I will break the patch down. Most probably I
will create two patches based on this one for host and another for device.
Regards,
Artur
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201011135122.71764A0061@mailhost.synopsys.com>
2020-10-27 8:22 ` [PATCH v2 02/15] usb: dwc2: Add support for dwc2 host/device clock gating Felipe Balbi
2020-10-27 10:26 ` Artur Petrosyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.