All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: "Linus Lüssing" <ll@simonwunderlich.de>,
	"Simon Wunderlich" <sw@simonwunderlich.de>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
	"Ben Greear" <greearb@candelatech.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode
Date: Fri, 15 Nov 2019 13:56:45 +0200	[thread overview]
Message-ID: <87a78xwdxe.fsf@codeaurora.org> (raw)
In-Reply-To: <20191115105612.8531-1-linus.luessing@c0d3.blue> ("Linus \=\?utf-8\?Q\?L\=C3\=BCssing\=22's\?\= message of "Fri, 15 Nov 2019 11:56:12 +0100")

Linus Lüssing <linus.luessing@c0d3.blue> writes:

> From: Linus Lüssing <ll@simonwunderlich.de>
>
> So far, frames were forwarded regardless of the FCS correctness leading
> to userspace applications listening on the monitor mode interface to
> receive potentially broken frames, even with the "fcsfail" flag unset.
>
> By default, with the "fcsfail" flag of a monitor mode interface
> unset, frames with FCS errors should be dropped. With this patch, the
> fcsfail flag is taken into account correctly.
>
> Cc: Simon Wunderlich <sw@simonwunderlich.de>
> Signed-off-by: Linus Lüssing <ll@simonwunderlich.de>

ath10k patches go ath-next branch, not net-next. So to avoid confusion
please don't mark ath10k patches as "net-next", please.

> ---
> This was tested on an Open Mesh A41 device, featuring a QCA4019. And
> with this firmware:
>
> https://www.candelatech.com/downloads/ath10k-4019-10-4b/firmware-5-ct-full-community-12.bin-lede.011

I'll add this testing information to the commit log. (No need to resend
just because of commit log changes)

> But from looking at the code it seems that the vanilla ath10k has the
> same issue, therefore submitting it here.

So this should work with the Qualcomm firmware as well, right?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: ath10k@lists.infradead.org,
	"David S . Miller" <davem@davemloft.net>,
	"Ben Greear" <greearb@candelatech.com>,
	"Simon Wunderlich" <sw@simonwunderlich.de>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Linus Lüssing" <ll@simonwunderlich.de>
Subject: Re: [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode
Date: Fri, 15 Nov 2019 13:56:45 +0200	[thread overview]
Message-ID: <87a78xwdxe.fsf@codeaurora.org> (raw)
In-Reply-To: <20191115105612.8531-1-linus.luessing@c0d3.blue> ("Linus \=\?utf-8\?Q\?L\=C3\=BCssing\=22's\?\= message of "Fri, 15 Nov 2019 11:56:12 +0100")

Linus Lüssing <linus.luessing@c0d3.blue> writes:

> From: Linus Lüssing <ll@simonwunderlich.de>
>
> So far, frames were forwarded regardless of the FCS correctness leading
> to userspace applications listening on the monitor mode interface to
> receive potentially broken frames, even with the "fcsfail" flag unset.
>
> By default, with the "fcsfail" flag of a monitor mode interface
> unset, frames with FCS errors should be dropped. With this patch, the
> fcsfail flag is taken into account correctly.
>
> Cc: Simon Wunderlich <sw@simonwunderlich.de>
> Signed-off-by: Linus Lüssing <ll@simonwunderlich.de>

ath10k patches go ath-next branch, not net-next. So to avoid confusion
please don't mark ath10k patches as "net-next", please.

> ---
> This was tested on an Open Mesh A41 device, featuring a QCA4019. And
> with this firmware:
>
> https://www.candelatech.com/downloads/ath10k-4019-10-4b/firmware-5-ct-full-community-12.bin-lede.011

I'll add this testing information to the commit log. (No need to resend
just because of commit log changes)

> But from looking at the code it seems that the vanilla ath10k has the
> same issue, therefore submitting it here.

So this should work with the Qualcomm firmware as well, right?

-- 
Kalle Valo

  reply	other threads:[~2019-11-15 11:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 10:56 [PATCH net-next v2] ath10k: fix RX of frames with broken FCS in monitor mode Linus Lüssing
2019-11-15 10:56 ` Linus Lüssing
2019-11-15 11:56 ` Kalle Valo [this message]
2019-11-15 11:56   ` Kalle Valo
2019-11-25 12:14 ` Kalle Valo
2019-11-25 12:14 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a78xwdxe.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=greearb@candelatech.com \
    --cc=linus.luessing@c0d3.blue \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ll@simonwunderlich.de \
    --cc=netdev@vger.kernel.org \
    --cc=sw@simonwunderlich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.