From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: anthony.wong@canonical.com, dri-devel@lists.freedesktop.org,
Mario.Limonciello@dell.com
Subject: Re: OLED panel brightness support
Date: Mon, 29 Jul 2019 11:34:39 +0300 [thread overview]
Message-ID: <87a7cxp7c0.fsf@intel.com> (raw)
In-Reply-To: <20190725115909.GA15868@phenom.ffwll.local>
On Thu, 25 Jul 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Jul 25, 2019 at 03:35:40PM +0800, Kai-Heng Feng wrote:
>> The next question is, how do we change the brightness level for OLED
>> displays? Is changing gamma value a good way to do it?
>
> There's no overall amplifier knob to set general brightness on these?
Usually there would be. There's no backlight, it's just the OLED
brightness, so you'd need to talk to the panel itself. On eDP this would
be accomplished by using DPCD, on command mode DSI by using DCS
commands. VESA specifies the DPCD commands to use, and we have some
level of support for that in i915 (granted, should be one level higher
in drm core, but I digress).
It's just that at least in the case of the referenced bug, it doesn't
seem to use the standard DPCD commands. To support that, someone would
have to acquire the panel specs or reverse engineer the proprietary
stuff. And then you'd have to mess the driver to do things differently
to cater for individual proprietary panels.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-29 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 10:46 OLED panel brightness support Kai-Heng Feng
2019-07-24 11:48 ` Daniel Vetter
[not found] ` <30f693a33f5a45ce84673fd8d7cecc7a@AUSX13MPC105.AMER.DELL.COM>
2019-07-25 7:35 ` Kai-Heng Feng
2019-07-25 11:59 ` Daniel Vetter
2019-07-25 13:12 ` Sam Ravnborg
2019-07-25 14:02 ` Daniel Vetter
2019-07-25 14:24 ` Sam Ravnborg
2019-07-29 8:34 ` Jani Nikula [this message]
2019-07-29 8:26 ` Jani Nikula
2019-07-29 8:43 ` Kai-Heng Feng
2019-07-29 9:19 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7cxp7c0.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=anthony.wong@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kai.heng.feng@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.