From: Jani Nikula <jani.nikula@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
dri-devel@lists.freedesktop.org
Cc: Anthony Wong <anthony.wong@canonical.com>,
Mario Limonciello <mario.limonciello@dell.com>
Subject: Re: OLED panel brightness support
Date: Mon, 29 Jul 2019 11:26:30 +0300 [thread overview]
Message-ID: <87d0htp7pl.fsf@intel.com> (raw)
In-Reply-To: <28D3097A-5295-4445-BD73-1A338EFA546D@canonical.com>
On Tue, 23 Jul 2019, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> Hi,
>
> Currently, OLED panel brightness [1] is not supported.
As a general statement this is not true, and not backed up by the
referenced bug. We just don't know how brightness is controlled on that
particular laptop, because it apparently uses a properietary mechanism.
If it used the brightness control mechamism specified in the VESA eDP
spec, it should work just fine with the i915 aux backlight support, and
we should also export the regular backlight sysfs for this.
BR,
Jani.
> We have a similar Dell system that also affect by lack of OLED brightness
> support.
>
> I’ve investigated both kernel and user space but I haven’t found a good
> general solution yet.
> Dell systems use EDID descriptor 4 as Dell specific descriptor, which
> reports its panel type and we can know it’s an OLED panel or not.
>
> My initial thought is to add a new attribute “oled" in drm_sysfs.c [2] to
> let userspace like clutter [3] to control the brightness.
> However other DEs may need to implement their own OLED brightness support
> which isn’t ideal.
>
> So I’d like to know if there’s any good way to support OLED brightness in
> good old backlight sysfs, to let userspace keep to the current interface.
>
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=97883
> [2] https://pastebin.ubuntu.com/p/QYrRBppVT9/
> [3]
> https://gitlab.gnome.org/GNOME/clutter/blob/master/clutter/clutter-brightness-contrast-effect.c#L559
>
> Kai-Heng
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-29 8:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 10:46 OLED panel brightness support Kai-Heng Feng
2019-07-24 11:48 ` Daniel Vetter
[not found] ` <30f693a33f5a45ce84673fd8d7cecc7a@AUSX13MPC105.AMER.DELL.COM>
2019-07-25 7:35 ` Kai-Heng Feng
2019-07-25 11:59 ` Daniel Vetter
2019-07-25 13:12 ` Sam Ravnborg
2019-07-25 14:02 ` Daniel Vetter
2019-07-25 14:24 ` Sam Ravnborg
2019-07-29 8:34 ` Jani Nikula
2019-07-29 8:26 ` Jani Nikula [this message]
2019-07-29 8:43 ` Kai-Heng Feng
2019-07-29 9:19 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0htp7pl.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=anthony.wong@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kai.heng.feng@canonical.com \
--cc=mario.limonciello@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.