All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Dmitry Osipenko <digetx@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Jianguo Sun <sunjianguo1@huawei.com>,
	James Hogan <jhogan@kernel.org>, Alban Bedel <albeu@free.fr>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Alex Elder <elder@linaro.org>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: [4/5] usb: host: Add XHCI driver for Broadcom STB SoCs
Date: Thu, 27 Sep 2018 08:57:09 +0300	[thread overview]
Message-ID: <87a7o3scsq.fsf@linux.intel.com> (raw)

Hi,

Al Cooper <alcooperx@gmail.com> writes:

> This driver enables USB XHCI on Broadcom ARM STB SoCs.
> The drivers depend on a matching "brcm,brcmstb-usb-phy"
> Broadcom STB USB Phy driver.
>
> The standard platform driver can't be used because of differences
> in PHY and Clock handling. The standard PHY handling in hcd.c will
> do a phy_exit/phy_init on suspend/resume and this will end up
> shutting down the PHYs to the point that the host controller
> registers are no longer accessible and will cause suspend to crash.
> The clocks specified in device tree for these drivers are not
> available in mainline so instead of returning EPROBE_DEFER when
> the specified clock is not found and eventually failing probe,
> the clock pointer is set to NULL which disables all clock handling.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
>  drivers/usb/host/xhci-brcm.c | 294 +++++++++++++++++++++++++++++++++++++++++++

this looks a lot like xhci-plat.c, why don't you use that instead?

- 
balbi

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Al Cooper <alcooperx@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Dmitry Osipenko <digetx@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Jianguo Sun <sunjianguo1@huawei.com>,
	James Hogan <jhogan@kernel.org>, Alban Bedel <albeu@free.fr>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Alex Elder <elder@linaro.org>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-usb@vger.kernel.org, dev
Subject: Re: [PATCH 4/5] usb: host: Add XHCI driver for Broadcom STB SoCs
Date: Thu, 27 Sep 2018 08:57:09 +0300	[thread overview]
Message-ID: <87a7o3scsq.fsf@linux.intel.com> (raw)
In-Reply-To: <1538000414-24873-5-git-send-email-alcooperx@gmail.com>


Hi,

Al Cooper <alcooperx@gmail.com> writes:

> This driver enables USB XHCI on Broadcom ARM STB SoCs.
> The drivers depend on a matching "brcm,brcmstb-usb-phy"
> Broadcom STB USB Phy driver.
>
> The standard platform driver can't be used because of differences
> in PHY and Clock handling. The standard PHY handling in hcd.c will
> do a phy_exit/phy_init on suspend/resume and this will end up
> shutting down the PHYs to the point that the host controller
> registers are no longer accessible and will cause suspend to crash.
> The clocks specified in device tree for these drivers are not
> available in mainline so instead of returning EPROBE_DEFER when
> the specified clock is not found and eventually failing probe,
> the clock pointer is set to NULL which disables all clock handling.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
>  drivers/usb/host/xhci-brcm.c | 294 +++++++++++++++++++++++++++++++++++++++++++

this looks a lot like xhci-plat.c, why don't you use that instead?

- 
balbi

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: Al Cooper <alcooperx@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Dmitry Osipenko <digetx@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Jianguo Sun <sunjianguo1@huawei.com>,
	James Hogan <jhogan@kernel.org>, Alban Bedel <albeu@free.fr>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Avi Fishman <avifishman70@gmail.com>,
	Alex Elder <elder@linaro.org>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 4/5] usb: host: Add XHCI driver for Broadcom STB SoCs
Date: Thu, 27 Sep 2018 08:57:09 +0300	[thread overview]
Message-ID: <87a7o3scsq.fsf@linux.intel.com> (raw)
In-Reply-To: <1538000414-24873-5-git-send-email-alcooperx@gmail.com>


Hi,

Al Cooper <alcooperx@gmail.com> writes:

> This driver enables USB XHCI on Broadcom ARM STB SoCs.
> The drivers depend on a matching "brcm,brcmstb-usb-phy"
> Broadcom STB USB Phy driver.
>
> The standard platform driver can't be used because of differences
> in PHY and Clock handling. The standard PHY handling in hcd.c will
> do a phy_exit/phy_init on suspend/resume and this will end up
> shutting down the PHYs to the point that the host controller
> registers are no longer accessible and will cause suspend to crash.
> The clocks specified in device tree for these drivers are not
> available in mainline so instead of returning EPROBE_DEFER when
> the specified clock is not found and eventually failing probe,
> the clock pointer is set to NULL which disables all clock handling.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
>  drivers/usb/host/xhci-brcm.c | 294 +++++++++++++++++++++++++++++++++++++++++++

this looks a lot like xhci-plat.c, why don't you use that instead?

- 
balbi

             reply	other threads:[~2018-09-27  5:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27  5:57 Felipe Balbi [this message]
2018-09-27  5:57 ` [PATCH 4/5] usb: host: Add XHCI driver for Broadcom STB SoCs Felipe Balbi
2018-09-27  5:57 ` Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2018-10-15 18:22 [1/5] dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document Rob Herring
2018-10-15 18:22 ` [PATCH 1/5] " Rob Herring
2018-10-15 18:22 ` Rob Herring
2018-09-27  9:08 [2/5] usb: host: Add OHCI driver for Broadcom STB SoCs Arnd Bergmann
2018-09-27  9:08 ` [PATCH 2/5] " Arnd Bergmann
2018-09-27  9:08 ` Arnd Bergmann
2018-09-27  5:51 [4/5] usb: host: Add XHCI " Chunfeng Yun
2018-09-27  5:51 ` [PATCH 4/5] " Chunfeng Yun
2018-09-27  5:51 ` Chunfeng Yun
2018-09-26 22:20 [5/5] usb: host: Enable building of new Broadcom STB USB drivers Alan Cooper
2018-09-26 22:20 ` [PATCH 5/5] " Al Cooper
2018-09-26 22:20 ` Al Cooper
2018-09-26 22:20 [4/5] usb: host: Add XHCI driver for Broadcom STB SoCs Alan Cooper
2018-09-26 22:20 ` [PATCH 4/5] " Al Cooper
2018-09-26 22:20 ` Al Cooper
2018-09-26 22:20 [3/5] usb: host: Add EHCI " Alan Cooper
2018-09-26 22:20 ` [PATCH 3/5] " Al Cooper
2018-09-26 22:20 ` Al Cooper
2018-09-26 22:20 [2/5] usb: host: Add OHCI " Alan Cooper
2018-09-26 22:20 ` [PATCH 2/5] " Al Cooper
2018-09-26 22:20 ` Al Cooper
2018-09-26 22:20 [1/5] dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document Alan Cooper
2018-09-26 22:20 ` [PATCH 1/5] " Al Cooper
2018-09-26 22:20 ` Al Cooper
2018-09-26 22:20 [PATCH 0/5] Add XHCI, EHCI and OHCI drivers for Broadcom STB SoCs Al Cooper
2018-09-26 22:20 ` Al Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7o3scsq.fsf@linux.intel.com \
    --to=felipe.balbi@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=albeu@free.fr \
    --cc=alcooperx@gmail.com \
    --cc=arnd@arndb.de \
    --cc=avifishman70@gmail.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=elder@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathias.nyman@intel.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=sunjianguo1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.