From: Juan Quintela <quintela@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: patches@linaro.org, qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, Shannon Zhao <zhaoshenglong@huawei.com>
Subject: Re: [Qemu-arm] [PATCH for-3.0 v2 2/5] hw/intc/arm_gicv3_common: Combine duplicate .subsections in vmstate_gicv3_cpu
Date: Tue, 07 Aug 2018 16:34:18 +0200 [thread overview]
Message-ID: <87a7py2ql1.fsf@trasno.org> (raw)
In-Reply-To: <20180806123445.1459-3-peter.maydell@linaro.org> (Peter Maydell's message of "Mon, 6 Aug 2018 13:34:42 +0100")
Peter Maydell <peter.maydell@linaro.org> wrote:
> Commit 6692aac411199064 accidentally introduced a second initialization
> of the .subsections field of vmstate_gicv3_cpu, instead of adding
> the new subsection to the existing list. The effect of this was
> probably that migration of GICv3 with virtualization enabled was
> broken (or alternatively that migration of ICC_SRE_EL1 was broken,
> depending on which of the two initializers the compiler used).
> Combine the two into a single list.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Shannon Zhao <zhaoshenglong@huawei.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-3.0 v2 2/5] hw/intc/arm_gicv3_common: Combine duplicate .subsections in vmstate_gicv3_cpu
Date: Tue, 07 Aug 2018 16:34:18 +0200 [thread overview]
Message-ID: <87a7py2ql1.fsf@trasno.org> (raw)
In-Reply-To: <20180806123445.1459-3-peter.maydell@linaro.org> (Peter Maydell's message of "Mon, 6 Aug 2018 13:34:42 +0100")
Peter Maydell <peter.maydell@linaro.org> wrote:
> Commit 6692aac411199064 accidentally introduced a second initialization
> of the .subsections field of vmstate_gicv3_cpu, instead of adding
> the new subsection to the existing list. The effect of this was
> probably that migration of GICv3 with virtualization enabled was
> broken (or alternatively that migration of ICC_SRE_EL1 was broken,
> depending on which of the two initializers the compiler used).
> Combine the two into a single list.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2018-08-07 14:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 12:34 [Qemu-arm] [PATCH for-3.0 v2 0/5] Arm migration fixes for 3.0 Peter Maydell
2018-08-06 12:34 ` [Qemu-devel] " Peter Maydell
2018-08-06 12:34 ` [Qemu-arm] [PATCH for-3.0 v2 1/5] hw/intc/arm_gicv3_common: Give no-migration-shift-bug subsection a needed function Peter Maydell
2018-08-06 12:34 ` [Qemu-devel] " Peter Maydell
2018-08-07 14:34 ` [Qemu-arm] " Juan Quintela
2018-08-07 14:34 ` [Qemu-devel] " Juan Quintela
2018-08-06 12:34 ` [Qemu-arm] [PATCH for-3.0 v2 2/5] hw/intc/arm_gicv3_common: Combine duplicate .subsections in vmstate_gicv3_cpu Peter Maydell
2018-08-06 12:34 ` [Qemu-devel] " Peter Maydell
2018-08-07 14:34 ` Juan Quintela [this message]
2018-08-07 14:34 ` Juan Quintela
2018-08-06 12:34 ` [Qemu-arm] [PATCH for-3.0 v2 3/5] target/arm: Add dummy needed functions to M profile vmstate subsections Peter Maydell
2018-08-06 12:34 ` [Qemu-devel] " Peter Maydell
2018-08-07 14:40 ` [Qemu-arm] " Juan Quintela
2018-08-07 14:40 ` [Qemu-devel] " Juan Quintela
2018-08-07 14:45 ` [Qemu-arm] " Peter Maydell
2018-08-07 14:45 ` [Qemu-devel] " Peter Maydell
2018-08-07 14:50 ` Juan Quintela
2018-08-07 14:50 ` Juan Quintela
2018-08-06 12:34 ` [Qemu-arm] [PATCH for-3.0 v2 4/5] hw/intc/arm_gicv3_common: Move post_load hooks to top-level VMSD Peter Maydell
2018-08-06 12:34 ` [Qemu-devel] " Peter Maydell
2018-08-06 15:32 ` [Qemu-arm] " Dr. David Alan Gilbert
2018-08-06 15:32 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-08-07 14:41 ` [Qemu-arm] " Juan Quintela
2018-08-07 14:41 ` [Qemu-devel] " Juan Quintela
2018-08-06 12:34 ` [Qemu-arm] [PATCH for-3.0 v2 5/5] hw/intc/arm_gicv3_common: Move gicd shift bug handling to gicv3_post_load Peter Maydell
2018-08-06 12:34 ` [Qemu-devel] " Peter Maydell
2018-08-06 15:39 ` [Qemu-arm] " Dr. David Alan Gilbert
2018-08-06 15:39 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-08-06 14:06 ` [Qemu-arm] [Qemu-devel] [PATCH for-3.0 v2 0/5] Arm migration fixes for 3.0 Richard Henderson
2018-08-06 14:06 ` Richard Henderson
2018-08-06 16:50 ` [Qemu-arm] " Peter Maydell
2018-08-06 16:50 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7py2ql1.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.