All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Huang\, Ying" <ying.huang@intel.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Michal Hocko <mhocko@suse.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Shaohua Li <shli@kernel.org>, Hugh Dickins <hughd@google.com>,
	Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 6/6] swap, put_swap_page: Share more between huge/normal code path
Date: Sat, 14 Jul 2018 20:57:07 +0800	[thread overview]
Message-ID: <87a7qudlgc.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20180713201858.zj43xzsnxqk3ozks@ca-dmjordan1.us.oracle.com> (Daniel Jordan's message of "Fri, 13 Jul 2018 13:18:58 -0700")

Daniel Jordan <daniel.m.jordan@oracle.com> writes:

> On Fri, Jul 13, 2018 at 07:36:36AM +0800, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@intel.com>
>> 
>> In this patch, locking related code is shared between huge/normal code
>> path in put_swap_page() to reduce code duplication.  And `free_entries
>> == 0` case is merged into more general `free_entries !=
>> SWAPFILE_CLUSTER` case, because the new locking method makes it easy.
>
> Might be a bit easier to think about the two changes if they were split up.

I just think the second change appears too trivial to be a separate patch.

> Agree with Dave's comment from patch 1, but otherwise the series looks ok to
> me.  I like the nr_swap_entries macro, that's clever.

Thanks!

Best Regards,
Huang, Ying

WARNING: multiple messages have this Message-ID (diff)
From: "Huang\, Ying" <ying.huang@intel.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Michal Hocko <mhocko@suse.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	"Shaohua Li" <shli@kernel.org>, Hugh Dickins <hughd@google.com>,
	Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 6/6] swap, put_swap_page: Share more between huge/normal code path
Date: Sat, 14 Jul 2018 20:57:07 +0800	[thread overview]
Message-ID: <87a7qudlgc.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20180713201858.zj43xzsnxqk3ozks@ca-dmjordan1.us.oracle.com> (Daniel Jordan's message of "Fri, 13 Jul 2018 13:18:58 -0700")

Daniel Jordan <daniel.m.jordan@oracle.com> writes:

> On Fri, Jul 13, 2018 at 07:36:36AM +0800, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@intel.com>
>> 
>> In this patch, locking related code is shared between huge/normal code
>> path in put_swap_page() to reduce code duplication.  And `free_entries
>> == 0` case is merged into more general `free_entries !=
>> SWAPFILE_CLUSTER` case, because the new locking method makes it easy.
>
> Might be a bit easier to think about the two changes if they were split up.

I just think the second change appears too trivial to be a separate patch.

> Agree with Dave's comment from patch 1, but otherwise the series looks ok to
> me.  I like the nr_swap_entries macro, that's clever.

Thanks!

Best Regards,
Huang, Ying

  reply	other threads:[~2018-07-14 12:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 23:36 [PATCH 0/6] swap: THP optimizing refactoring Huang, Ying
2018-07-12 23:36 ` [PATCH 1/6] swap: Add comments to lock_cluster_or_swap_info() Huang, Ying
2018-07-13 10:48   ` Dave Hansen
2018-07-14  4:07     ` Huang, Ying
2018-07-14  4:07       ` Huang, Ying
2018-07-12 23:36 ` [PATCH 2/6] mm/swapfile.c: Replace some #ifdef with IS_ENABLED() Huang, Ying
2018-07-13 18:38   ` Daniel Jordan
2018-07-13 18:55     ` Daniel Jordan
2018-07-12 23:36 ` [PATCH 3/6] swap: Unify normal/huge code path in swap_page_trans_huge_swapped() Huang, Ying
2018-07-13 20:15   ` Daniel Jordan
2018-07-14 12:53     ` Huang, Ying
2018-07-14 12:53       ` Huang, Ying
2018-07-12 23:36 ` [PATCH 4/6] swap: Unify normal/huge code path in put_swap_page() Huang, Ying
2018-07-12 23:36 ` [PATCH 5/6] swap: Add __swap_entry_free_locked() Huang, Ying
2018-07-12 23:36 ` [PATCH 6/6] swap, put_swap_page: Share more between huge/normal code path Huang, Ying
2018-07-13 20:18   ` Daniel Jordan
2018-07-14 12:57     ` Huang, Ying [this message]
2018-07-14 12:57       ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7qudlgc.fsf@yhuang-dev.intel.com \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.