From: gregory.clement@bootlin.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net 3/3] ARM64: dts: marvell: armada-cp110: Add clocks for the xmdio node
Date: Wed, 25 Apr 2018 14:30:26 +0200 [thread overview]
Message-ID: <87a7treae5.fsf@bootlin.com> (raw)
In-Reply-To: <87muxrecnf.fsf@bootlin.com> (Gregory CLEMENT's message of "Wed, 25 Apr 2018 13:41:40 +0200")
Hi agin,
On mer., avril 25 2018, Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
> Hi Maxime,
>
> On mer., avril 25 2018, Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:
>
>> The Marvell XSMI controller needs 3 clocks to operate correctly :
>> - The MG clock (clk 5)
>> - The MG Core clock (clk 6)
>> - The GOP clock (clk 18)
>>
>> This commit adds them, to avoid system hangs when using these
>> interfaces.
>>
>> Fixes: c7e92def1ef4 ("clk: mvebu: cp110: Fix clock tree representation")
>> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
>
> This patch should not have been sent with the net prefix and should not
> be merge through the net subsystem.
>
> I will take care of it to avoid conflict in the devei tree file during
> the merge windows.
So, applied on mvebu/fixes
Thanks,
Gregory
>
> Thanks,
>
> Gregory
>
>> ---
>> arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> index 6c137ac656e9..ed2f1237ea1e 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> @@ -142,6 +142,8 @@
>> #size-cells = <0>;
>> compatible = "marvell,xmdio";
>> reg = <0x12a600 0x10>;
>> + clocks = <&CP110_LABEL(clk) 1 5>,
>> + <&CP110_LABEL(clk) 1 6>, <&CP110_LABEL(clk) 1 18>;
>> status = "disabled";
>> };
>>
>> --
>> 2.11.0
>>
>
> --
> Gregory Clement, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com
--
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com,
nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com,
mw@semihalf.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net 3/3] ARM64: dts: marvell: armada-cp110: Add clocks for the xmdio node
Date: Wed, 25 Apr 2018 14:30:26 +0200 [thread overview]
Message-ID: <87a7treae5.fsf@bootlin.com> (raw)
In-Reply-To: <87muxrecnf.fsf@bootlin.com> (Gregory CLEMENT's message of "Wed, 25 Apr 2018 13:41:40 +0200")
Hi agin,
On mer., avril 25 2018, Gregory CLEMENT <gregory.clement@bootlin.com> wrote:
> Hi Maxime,
>
> On mer., avril 25 2018, Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:
>
>> The Marvell XSMI controller needs 3 clocks to operate correctly :
>> - The MG clock (clk 5)
>> - The MG Core clock (clk 6)
>> - The GOP clock (clk 18)
>>
>> This commit adds them, to avoid system hangs when using these
>> interfaces.
>>
>> Fixes: c7e92def1ef4 ("clk: mvebu: cp110: Fix clock tree representation")
>> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
>
> This patch should not have been sent with the net prefix and should not
> be merge through the net subsystem.
>
> I will take care of it to avoid conflict in the devei tree file during
> the merge windows.
So, applied on mvebu/fixes
Thanks,
Gregory
>
> Thanks,
>
> Gregory
>
>> ---
>> arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> index 6c137ac656e9..ed2f1237ea1e 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> @@ -142,6 +142,8 @@
>> #size-cells = <0>;
>> compatible = "marvell,xmdio";
>> reg = <0x12a600 0x10>;
>> + clocks = <&CP110_LABEL(clk) 1 5>,
>> + <&CP110_LABEL(clk) 1 6>, <&CP110_LABEL(clk) 1 18>;
>> status = "disabled";
>> };
>>
>> --
>> 2.11.0
>>
>
> --
> Gregory Clement, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com
--
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-04-25 12:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 11:07 [PATCH net 0/3] net: mvpp2: Fix hangs when starting some interfaces on 7k/8k Maxime Chevallier
2018-04-25 11:07 ` Maxime Chevallier
2018-04-25 11:07 ` [PATCH net 1/3] net: mvpp2: Fix clk error path in mvpp2_probe Maxime Chevallier
2018-04-25 11:07 ` Maxime Chevallier
2018-04-25 11:07 ` Maxime Chevallier
2018-04-25 12:05 ` Gregory CLEMENT
2018-04-25 12:05 ` Gregory CLEMENT
2018-04-25 11:07 ` [PATCH net 2/3] net: mvpp2: Fix clock resource by adding missing mg_core_clk Maxime Chevallier
2018-04-25 11:07 ` Maxime Chevallier
2018-04-25 11:43 ` Gregory CLEMENT
2018-04-25 11:43 ` Gregory CLEMENT
2018-04-25 11:52 ` Maxime Chevallier
2018-04-25 11:52 ` Maxime Chevallier
2018-04-25 11:07 ` [PATCH net 3/3] ARM64: dts: marvell: armada-cp110: Add clocks for the xmdio node Maxime Chevallier
2018-04-25 11:07 ` Maxime Chevallier
2018-04-25 11:41 ` Gregory CLEMENT
2018-04-25 11:41 ` Gregory CLEMENT
2018-04-25 12:30 ` Gregory CLEMENT [this message]
2018-04-25 12:30 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7treae5.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.