From: Markus Armbruster <armbru@redhat.com>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag
Date: Thu, 18 Aug 2016 19:37:20 +0200 [thread overview]
Message-ID: <87a8gaou5r.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87inuyqbbn.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Thu, 18 Aug 2016 18:41:16 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> Dmitry Fleytman <dmitry@daynix.com> writes:
>
>>> On 18 Aug 2016, at 17:15, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
[...]
>>> @@ -601,7 +596,6 @@ static const VMStateDescription e1000e_vmstate = {
>>> VMSTATE_MSIX(parent_obj, E1000EState),
>>>
>>> VMSTATE_UINT32(ioaddr, E1000EState),
>>> - VMSTATE_UINT32(intr_state, E1000EState),
>
> We can still do this, because as Paolo pointed out, no released version
> of QEMU had this device.
Which means we better get this into 2.7.0. Thoughts?
>>> VMSTATE_UINT32(core.rxbuf_min_shift, E1000EState),
>>> VMSTATE_UINT8(core.rx_desc_len, E1000EState),
>>> VMSTATE_UINT32_ARRAY(core.rxbuf_sizes, E1000EState,
>>> --
>>> 2.1.0
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2016-08-18 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 14:15 [Qemu-devel] [PATCH] e1000e: remove internal interrupt flag Cao jin
2016-08-18 15:31 ` Dmitry Fleytman
2016-08-18 16:41 ` Markus Armbruster
2016-08-18 17:37 ` Markus Armbruster [this message]
2016-08-18 20:27 ` Dmitry Fleytman
2016-08-18 16:57 ` Paolo Bonzini
2016-08-19 2:14 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8gaou5r.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.