From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Nadav Haklai <nadavh@marvell.com>, Victor Gu <xigu@marvell.com>,
Romain Perier <romain.perier@free-electrons.com>,
Omri Itach <omrii@marvell.com>, Marcin Wojtas <mw@semihalf.com>,
Wilson Ding <dingwei@marvell.com>,
Hua Jing <jinghua@marvell.com>, Terry Zhou <bjzhou@marvell.com>
Subject: Re: [PATCH v2 1/6] dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700
Date: Mon, 11 Jul 2016 18:12:22 +0200 [thread overview]
Message-ID: <87a8hotaqh.fsf@free-electrons.com> (raw)
In-Reply-To: <20160708093156.4f235b85@free-electrons.com> (Thomas Petazzoni's message of "Fri, 8 Jul 2016 09:31:56 +0200")
Hi Thomas,
On ven., juil. 08 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 8 Jul 2016 00:37:46 +0200, Gregory CLEMENT wrote:
>
>> +gpio1: gpio@13800 {
>> + compatible = "marvell,mvebu-gpio-3700", "syscon", "simple-mfd";
>
> I find this compatible string not very consistent with what we do for
> other drivers, it should have been:
>
> marvell,armada-3700-gpio
Thanks for pointing this. We missed it during the last review. I agree
that using marvell,armada-3700-gpio is more appropriate, especially
because the gpio controller on Armada 37xx seems to be different that
the ones used on the other mvebu SoCs.
Gregory
>
> or something like that.
>
>
>> + xtalclk: xtal-clk {
>> + compatible = "marvell,armada-3700-xtal-clock";
>
> See here for example.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700
Date: Mon, 11 Jul 2016 18:12:22 +0200 [thread overview]
Message-ID: <87a8hotaqh.fsf@free-electrons.com> (raw)
In-Reply-To: <20160708093156.4f235b85@free-electrons.com> (Thomas Petazzoni's message of "Fri, 8 Jul 2016 09:31:56 +0200")
Hi Thomas,
On ven., juil. 08 2016, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 8 Jul 2016 00:37:46 +0200, Gregory CLEMENT wrote:
>
>> +gpio1: gpio at 13800 {
>> + compatible = "marvell,mvebu-gpio-3700", "syscon", "simple-mfd";
>
> I find this compatible string not very consistent with what we do for
> other drivers, it should have been:
>
> marvell,armada-3700-gpio
Thanks for pointing this. We missed it during the last review. I agree
that using marvell,armada-3700-gpio is more appropriate, especially
because the gpio controller on Armada 37xx seems to be different that
the ones used on the other mvebu SoCs.
Gregory
>
> or something like that.
>
>
>> + xtalclk: xtal-clk {
>> + compatible = "marvell,armada-3700-xtal-clock";
>
> See here for example.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-07-11 16:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 22:37 [PATCH v2 0/6] Add clock support for Armada 37xx SoCs Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` [PATCH v2 1/6] dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700 Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-08 7:31 ` Thomas Petazzoni
2016-07-08 7:31 ` Thomas Petazzoni
2016-07-11 16:12 ` Gregory CLEMENT [this message]
2016-07-11 16:12 ` Gregory CLEMENT
2016-07-07 22:37 ` [PATCH v2 2/6] clk: mvebu: Add the xtal clock for Armada 3700 SoC Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-08 17:32 ` Michael Turquette
2016-07-08 17:32 ` Michael Turquette
2016-07-08 17:32 ` Michael Turquette
2016-07-08 17:32 ` Michael Turquette
2016-07-12 10:42 ` Gregory CLEMENT
2016-07-12 10:42 ` Gregory CLEMENT
2016-07-09 23:34 ` Paul Gortmaker
2016-07-09 23:34 ` Paul Gortmaker
2016-07-12 10:43 ` Gregory CLEMENT
2016-07-12 10:43 ` Gregory CLEMENT
2016-07-12 10:43 ` Gregory CLEMENT
2016-07-07 22:37 ` [PATCH v2 3/6] dt-bindings: clock: add DT binding for the TBG clocks on Armada 3700 Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` [PATCH v2 4/6] clk: mvebu Add the time base generator clocks for " Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` [PATCH v2 5/6] dt-bindings: clock: add DT binding for the peripheral clocks on " Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` [PATCH v2 6/6] clk: mvebu: Add the peripheral clock driver for " Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-07 22:37 ` Gregory CLEMENT
2016-07-08 18:27 ` Michael Turquette
2016-07-08 18:27 ` Michael Turquette
2016-07-08 18:27 ` Michael Turquette
2016-07-08 18:27 ` Michael Turquette
2016-07-12 16:30 ` Gregory CLEMENT
2016-07-12 16:30 ` Gregory CLEMENT
2016-07-12 17:28 ` Michael Turquette
2016-07-12 17:28 ` Michael Turquette
2016-07-12 17:28 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8hotaqh.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=bjzhou@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=dingwei@marvell.com \
--cc=jason@lakedaemon.net \
--cc=jinghua@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=omrii@marvell.com \
--cc=robh+dt@kernel.org \
--cc=romain.perier@free-electrons.com \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=xigu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.