[PATCH 1/4] soc: dove: Let genpd deal with disabling of unused PM domains

[PATCH 1/4] soc: dove: Let genpd deal with disabling of unused PM domains

[Ulf Hansson]

Genpd tries from a late_initcall to disable unused PM domains, which makes
it unnecessary to also manage this from any earlier phase when for example
initializing a genpd.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/soc/dove/pmu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index 052aecf..abd0879 100644
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c
@@ -396,7 +396,6 @@ int __init dove_init_pmu(void)
 
 		__pmu_domain_register(domain, np);
 	}
-	pm_genpd_poweroff_unused();
 
 	/* Loss of the interrupt controller is not a fatal error. */
 	parent_irq = irq_of_parse_and_map(pmu->of_node, 0);
-- 
1.9.1

Re: [PATCH 1/4] soc: dove: Let genpd deal with disabling of unused PM domains

[Gregory CLEMENT]

Hi Ulf and Sebastian,
 
 On mar., oct. 06 2015, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> Genpd tries from a late_initcall to disable unused PM domains, which makes
> it unnecessary to also manage this from any earlier phase when for example
> initializing a genpd.

I can't test it and I didn't follow this part.

Sebastian could you have a look on this patch?

Thanks,

Gregory

>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  drivers/soc/dove/pmu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
> index 052aecf..abd0879 100644
> --- a/drivers/soc/dove/pmu.c
> +++ b/drivers/soc/dove/pmu.c
> @@ -396,7 +396,6 @@ int __init dove_init_pmu(void)
>  
>  		__pmu_domain_register(domain, np);
>  	}
> -	pm_genpd_poweroff_unused();
>  
>  	/* Loss of the interrupt controller is not a fatal error. */
>  	parent_irq = irq_of_parse_and_map(pmu->of_node, 0);
> -- 
> 1.9.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH 1/4] soc: dove: Let genpd deal with disabling of unused PM domains

[Russell King - ARM Linux]

On Thu, Oct 15, 2015 at 09:57:55AM +0200, Gregory CLEMENT wrote:
> Hi Ulf and Sebastian,
>  
>  On mar., oct. 06 2015, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> 
> > Genpd tries from a late_initcall to disable unused PM domains, which makes
> > it unnecessary to also manage this from any earlier phase when for example
> > initializing a genpd.
> 
> I can't test it and I didn't follow this part.
> 
> Sebastian could you have a look on this patch?

I'm probably the only one who can test the patch at the moment, having
the vmeta and etnaviv drivers merged in my tree which make use of this.
However, as ever, that tree is based on 4.2 and not 4.3-rc, so I'm
planning to test this _after_ 4.3 is released.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.