From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Hans Holmberg <hans.holmberg@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Howard Cochran <cochran@lexmark.com>,
Daniel Mack <zonque@gmail.com>, Tyler Hall <tylerwhall@gmail.com>
Subject: Re: [PATCH] gpiolib: of: allow of_gpiochip_find_and_xlate to find more than one chip per node
Date: Tue, 10 Feb 2015 18:08:26 +0100 [thread overview]
Message-ID: <87a90l7kz9.fsf@free.fr> (raw)
In-Reply-To: <CAAVeFu+F1oy4AZqWmMkGqiVxz5YF1y-qMxyHObWjjVXp8PuGcg@mail.gmail.com> (Alexandre Courbot's message of "Tue, 10 Feb 2015 17:50:22 +0900")
Alexandre Courbot <gnurou@gmail.com> writes:
> On Tue, Feb 10, 2015 at 5:48 PM, Hans Holmberg <hans.holmberg@intel.com> wrote:
>> The change:
>>
>> 7b8792bbdffdff3abda704f89c6a45ea97afdc62
>> gpiolib: of: Correct error handling in of_get_named_gpiod_flags
>>
>> assumed that only one gpio-chip is registred per of-node.
>> Some drivers register more than one chip per of-node, so
>> adjust the matching function of_gpiochip_find_and_xlate to
>> not stop looking for chips if a node-match is found and
>> the translation fails.
>>
>> Signed-off-by: Hans Holmberg <hans.holmberg@intel.com>
>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
(on arm pxa architecture)
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Hans Holmberg <hans.holmberg@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio\@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Howard Cochran <cochran@lexmark.com>,
Daniel Mack <zonque@gmail.com>, Tyler Hall <tylerwhall@gmail.com>
Subject: Re: [PATCH] gpiolib: of: allow of_gpiochip_find_and_xlate to find more than one chip per node
Date: Tue, 10 Feb 2015 18:08:26 +0100 [thread overview]
Message-ID: <87a90l7kz9.fsf@free.fr> (raw)
In-Reply-To: <CAAVeFu+F1oy4AZqWmMkGqiVxz5YF1y-qMxyHObWjjVXp8PuGcg@mail.gmail.com> (Alexandre Courbot's message of "Tue, 10 Feb 2015 17:50:22 +0900")
Alexandre Courbot <gnurou@gmail.com> writes:
> On Tue, Feb 10, 2015 at 5:48 PM, Hans Holmberg <hans.holmberg@intel.com> wrote:
>> The change:
>>
>> 7b8792bbdffdff3abda704f89c6a45ea97afdc62
>> gpiolib: of: Correct error handling in of_get_named_gpiod_flags
>>
>> assumed that only one gpio-chip is registred per of-node.
>> Some drivers register more than one chip per of-node, so
>> adjust the matching function of_gpiochip_find_and_xlate to
>> not stop looking for chips if a node-match is found and
>> the translation fails.
>>
>> Signed-off-by: Hans Holmberg <hans.holmberg@intel.com>
>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
(on arm pxa architecture)
Cheers.
--
Robert
next prev parent reply other threads:[~2015-02-10 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 8:48 [PATCH] gpiolib: of: allow of_gpiochip_find_and_xlate to find more than one chip per node Hans Holmberg
2015-02-10 8:50 ` Alexandre Courbot
2015-02-10 17:08 ` Robert Jarzmik [this message]
2015-02-10 17:08 ` Robert Jarzmik
2015-02-10 20:30 ` Tyler Hall
2015-02-18 17:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a90l7kz9.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=cochran@lexmark.com \
--cc=gnurou@gmail.com \
--cc=hans.holmberg@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tylerwhall@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.