All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] drm/panel: Changes for v3.20-rc1
@ 2015-01-23 13:56 Thierry Reding
  2015-01-26  9:07 ` Jani Nikula
  0 siblings, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2015-01-23 13:56 UTC (permalink / raw)
  To: Dave Airlie; +Cc: dri-devel

Hi Dave,

The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:

  Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)

are available in the git repository at:

  git://anongit.freedesktop.org/tegra/linux tags/drm/panel/for-3.20-rc1

for you to fetch changes up to c618c446adffebd4a0593f387952e450ac191a00:

  Documentation: bridge: Add documentation for ps8622 DT properties (2015-01-23 14:40:24 +0100)

Thanks,
Thierry

----------------------------------------------------------------
drm/panel: Changes for v3.20-rc1

This contains the long-awaited drm_bridge series that makes Chromebooks
work for people. I had thought this would've been perfect by now, but
then I go and build test it and the first thing it does is yell about a
recursive dependency. I fixed that up because I was feeling bad for not
getting around to look at this earlier.

Biseds that there is new support for two more panels, a couple of fixup
patches to the Sharp LQ101R1SX01 dual-channel DSI panel driver and a
potential NULL pointer dereference fix.

----------------------------------------------------------------
Ajay Kumar (11):
      drm/bridge: ptn3460: Few trivial cleanups
      drm/bridge: do not pass drm_bridge_funcs to drm_bridge_init
      drm/bridge: make bridge registration independent of drm flow
      drm/bridge: ptn3460: Convert to I2C driver model
      drm/exynos: dp: support drm_bridge
      drm/bridge: ptn3460: support drm_panel
      drm/bridge: ptn3460: probe connector at the end of bridge attach
      drm/bridge: ptn3460: use gpiod interface
      Documentation: drm: bridge: move to video/bridge
      Documentation: devicetree: Add vendor prefix for parade
      Documentation: bridge: Add documentation for ps8622 DT properties

Philipp Zabel (4):
      of: Add vendor prefix for Giantplus Technology Co., Ltd.
      drm/panel: simple: Add support for Giantplus GPG482739QS5
      of: Add vendor prefix for Shanghai AVIC Optoelectronics Co., Ltd.
      drm/panel: simple: Add AVIC TM070DDH03 panel support

Thierry Reding (4):
      drm/mipi-dsi: Avoid potential NULL pointer dereference
      drm/panel: sharp: lq101r1sx01: Add delay after display on
      drm/panel: sharp: lq101r1sx01: Respect power timings
      drm/panel: sharp: lq101r1sx01: Remove unneeded include

 .../devicetree/bindings/panel/avic,tm070ddh03.txt  |   7 +
 .../bindings/panel/giantplus,gpg482739qs5.txt      |   7 +
 .../devicetree/bindings/vendor-prefixes.txt        |   3 +
 .../devicetree/bindings/video/bridge/ps8622.txt    |  31 +++
 .../bindings/{drm => video}/bridge/ptn3460.txt     |  16 +-
 .../devicetree/bindings/video/exynos_dp.txt        |  12 +
 drivers/gpu/drm/Makefile                           |   2 +-
 drivers/gpu/drm/bridge/Kconfig                     |   3 +
 drivers/gpu/drm/bridge/ptn3460.c                   | 310 +++++++++++++--------
 drivers/gpu/drm/drm_bridge.c                       |  91 ++++++
 drivers/gpu/drm/drm_crtc.c                         |  70 -----
 drivers/gpu/drm/drm_mipi_dsi.c                     |   6 +-
 drivers/gpu/drm/exynos/exynos_dp_core.c            |  53 ++--
 drivers/gpu/drm/exynos/exynos_dp_core.h            |   1 +
 drivers/gpu/drm/msm/hdmi/hdmi.c                    |   4 +-
 drivers/gpu/drm/msm/hdmi/hdmi.h                    |   1 +
 drivers/gpu/drm/msm/hdmi/hdmi_bridge.c             |   7 +-
 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c    |  33 ++-
 drivers/gpu/drm/panel/panel-simple.c               |  57 ++++
 drivers/gpu/drm/sti/sti_hda.c                      |  11 +-
 drivers/gpu/drm/sti/sti_hdmi.c                     |  11 +-
 include/drm/bridge/ptn3460.h                       |   8 +
 include/drm/drm_crtc.h                             |  27 +-
 23 files changed, 503 insertions(+), 268 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/panel/avic,tm070ddh03.txt
 create mode 100644 Documentation/devicetree/bindings/panel/giantplus,gpg482739qs5.txt
 create mode 100644 Documentation/devicetree/bindings/video/bridge/ps8622.txt
 rename Documentation/devicetree/bindings/{drm => video}/bridge/ptn3460.txt (65%)
 create mode 100644 drivers/gpu/drm/drm_bridge.c
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [GIT PULL] drm/panel: Changes for v3.20-rc1
  2015-01-23 13:56 [GIT PULL] drm/panel: Changes for v3.20-rc1 Thierry Reding
@ 2015-01-26  9:07 ` Jani Nikula
  2015-01-26  9:53   ` Thierry Reding
  0 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2015-01-26  9:07 UTC (permalink / raw)
  To: Thierry Reding, Dave Airlie; +Cc: dri-devel

On Fri, 23 Jan 2015, Thierry Reding <thierry.reding@gmail.com> wrote:
> Thierry Reding (4):
>       drm/mipi-dsi: Avoid potential NULL pointer dereference

I can't find this one, has it been posted on the list?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [GIT PULL] drm/panel: Changes for v3.20-rc1
  2015-01-26  9:07 ` Jani Nikula
@ 2015-01-26  9:53   ` Thierry Reding
  2015-01-26 10:28     ` Jani Nikula
  0 siblings, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2015-01-26  9:53 UTC (permalink / raw)
  To: Jani Nikula; +Cc: dri-devel


[-- Attachment #1.1.1: Type: text/plain, Size: 542 bytes --]

On Mon, Jan 26, 2015 at 11:07:52AM +0200, Jani Nikula wrote:
> On Fri, 23 Jan 2015, Thierry Reding <thierry.reding@gmail.com> wrote:
> > Thierry Reding (4):
> >       drm/mipi-dsi: Avoid potential NULL pointer dereference
> 
> I can't find this one, has it been posted on the list?

I thought it had, but I can't find any record of that. It certainly was
reported on-list:

	Subject: re: drm/dsi: Add message to packet translator
	Message-ID: <20141216235305.GC31467@mwanda>

I've attached the patch for convenience.

Thierry

[-- Attachment #1.1.2: 0001-drm-mipi-dsi-Avoid-potential-NULL-pointer-dereferenc.patch --]
[-- Type: text/x-diff, Size: 1505 bytes --]

From 903c75cb0da218e3849fff3c2c17a9f2ab5705ba Mon Sep 17 00:00:00 2001
From: Thierry Reding <treding@nvidia.com>
Date: Fri, 5 Dec 2014 11:46:56 +0100
Subject: [PATCH] drm/mipi-dsi: Avoid potential NULL pointer dereference

The mipi_dsi_packet_create() function dereferences the msg pointer
before checking that it's valid. Move the dereference down to where it
is required to avoid potentially dereferencing a NULL pointer.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/drm_mipi_dsi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index c0644bb865f2..2d5ca8eec13a 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -323,8 +323,6 @@ EXPORT_SYMBOL(mipi_dsi_packet_format_is_long);
 int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
 			   const struct mipi_dsi_msg *msg)
 {
-	const u8 *tx = msg->tx_buf;
-
 	if (!packet || !msg)
 		return -EINVAL;
 
@@ -353,8 +351,10 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
 		packet->header[2] = (msg->tx_len >> 8) & 0xff;
 
 		packet->payload_length = msg->tx_len;
-		packet->payload = tx;
+		packet->payload = msg->tx_buf;
 	} else {
+		const u8 *tx = msg->tx_buf;
+
 		packet->header[1] = (msg->tx_len > 0) ? tx[0] : 0;
 		packet->header[2] = (msg->tx_len > 1) ? tx[1] : 0;
 	}
-- 
2.1.3


[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [GIT PULL] drm/panel: Changes for v3.20-rc1
  2015-01-26  9:53   ` Thierry Reding
@ 2015-01-26 10:28     ` Jani Nikula
  0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2015-01-26 10:28 UTC (permalink / raw)
  To: Thierry Reding; +Cc: dri-devel

On Mon, 26 Jan 2015, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Jan 26, 2015 at 11:07:52AM +0200, Jani Nikula wrote:
>> On Fri, 23 Jan 2015, Thierry Reding <thierry.reding@gmail.com> wrote:
>> > Thierry Reding (4):
>> >       drm/mipi-dsi: Avoid potential NULL pointer dereference
>> 
>> I can't find this one, has it been posted on the list?
>
> I thought it had, but I can't find any record of that. It certainly was
> reported on-list:
>
> 	Subject: re: drm/dsi: Add message to packet translator
> 	Message-ID: <20141216235305.GC31467@mwanda>
>
> I've attached the patch for convenience.

Ah, so not a very likely scenario. Looks good to me.

Thanks,
Jani.

>
> Thierry
> From 903c75cb0da218e3849fff3c2c17a9f2ab5705ba Mon Sep 17 00:00:00 2001
> From: Thierry Reding <treding@nvidia.com>
> Date: Fri, 5 Dec 2014 11:46:56 +0100
> Subject: [PATCH] drm/mipi-dsi: Avoid potential NULL pointer dereference
>
> The mipi_dsi_packet_create() function dereferences the msg pointer
> before checking that it's valid. Move the dereference down to where it
> is required to avoid potentially dereferencing a NULL pointer.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
> index c0644bb865f2..2d5ca8eec13a 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -323,8 +323,6 @@ EXPORT_SYMBOL(mipi_dsi_packet_format_is_long);
>  int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
>  			   const struct mipi_dsi_msg *msg)
>  {
> -	const u8 *tx = msg->tx_buf;
> -
>  	if (!packet || !msg)
>  		return -EINVAL;
>  
> @@ -353,8 +351,10 @@ int mipi_dsi_create_packet(struct mipi_dsi_packet *packet,
>  		packet->header[2] = (msg->tx_len >> 8) & 0xff;
>  
>  		packet->payload_length = msg->tx_len;
> -		packet->payload = tx;
> +		packet->payload = msg->tx_buf;
>  	} else {
> +		const u8 *tx = msg->tx_buf;
> +
>  		packet->header[1] = (msg->tx_len > 0) ? tx[0] : 0;
>  		packet->header[2] = (msg->tx_len > 1) ? tx[1] : 0;
>  	}
> -- 
> 2.1.3
>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [GIT PULL] drm/panel: Changes for v3.20-rc1
@ 2015-01-28  9:04 Thierry Reding
  0 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2015-01-28  9:04 UTC (permalink / raw)
  To: Dave Airlie; +Cc: dri-devel

Hi Dave,

The following changes since commit 21773f16f2cb3c056051c679da542f0b494252e2:

  Merge tag 'topic/atomic-core-2015-01-27' of git://anongit.freedesktop.org/drm-intel into drm-next (2015-01-28 09:34:27 +1000)

are available in the git repository at:

  git://anongit.freedesktop.org/tegra/linux tags/drm/panel/for-3.20-rc1

for you to fetch changes up to b5217bf4692218d202d3d2cd772864fa1e10be4d:

  drm/bridge: dw-hdmi: Adapt to bridge API change (2015-01-28 10:01:30 +0100)

This one is essentially the previous one, but rebased on drm-next and a
couple of fixups for the drm_bridge breakage. And one more fixup for the
dw-hdmi bridge that was posted earlier today.

Thanks,
Thierry

----------------------------------------------------------------
drm/panel: Changes for v3.20-rc1

This contains the long-awaited drm_bridge series that makes Chromebooks
work for people. I had thought this would've been perfect by now, but
then I go and build test it and the first thing it does is yell about a
recursive dependency. I fixed that up because I was feeling bad for not
getting around to look at this earlier.

Biseds that there is new support for two more panels, a couple of fixup
patches to the Sharp LQ101R1SX01 dual-channel DSI panel driver and a
potential NULL pointer dereference fix.

----------------------------------------------------------------
Ajay Kumar (11):
      drm/bridge: ptn3460: Few trivial cleanups
      drm/bridge: do not pass drm_bridge_funcs to drm_bridge_init
      drm/bridge: make bridge registration independent of drm flow
      drm/bridge: ptn3460: Convert to I2C driver model
      drm/exynos: dp: support drm_bridge
      drm/bridge: ptn3460: support drm_panel
      drm/bridge: ptn3460: probe connector at the end of bridge attach
      drm/bridge: ptn3460: use gpiod interface
      Documentation: drm: bridge: move to video/bridge
      Documentation: devicetree: Add vendor prefix for parade
      Documentation: bridge: Add documentation for ps8622 DT properties

Dan Carpenter (1):
      drm: Check the right variable when setting formats

Dave Airlie (1):
      drm/sti: fixup for bridge interface

Fabio Estevam (2):
      drm/bridge: dw-hdmi: Fix return error path
      drm/bridge: dw-hdmi: Adapt to bridge API change

Philipp Zabel (4):
      of: Add vendor prefix for Giantplus Technology Co., Ltd.
      drm/panel: simple: Add support for Giantplus GPG482739QS5
      of: Add vendor prefix for Shanghai AVIC Optoelectronics Co., Ltd.
      drm/panel: simple: Add AVIC TM070DDH03 panel support

Thierry Reding (4):
      drm/mipi-dsi: Avoid potential NULL pointer dereference
      drm/panel: sharp: lq101r1sx01: Add delay after display on
      drm/panel: sharp: lq101r1sx01: Respect power timings
      drm/panel: sharp: lq101r1sx01: Remove unneeded include

 .../devicetree/bindings/panel/avic,tm070ddh03.txt  |   7 +
 .../bindings/panel/giantplus,gpg482739qs5.txt      |   7 +
 .../devicetree/bindings/vendor-prefixes.txt        |   3 +
 .../devicetree/bindings/video/bridge/ps8622.txt    |  31 +++
 .../bindings/{drm => video}/bridge/ptn3460.txt     |  16 +-
 .../devicetree/bindings/video/exynos_dp.txt        |  12 +
 drivers/gpu/drm/Makefile                           |   2 +-
 drivers/gpu/drm/bridge/Kconfig                     |  13 +-
 drivers/gpu/drm/bridge/dw_hdmi.c                   |  13 +-
 drivers/gpu/drm/bridge/ptn3460.c                   | 310 +++++++++++++--------
 drivers/gpu/drm/drm_bridge.c                       |  91 ++++++
 drivers/gpu/drm/drm_crtc.c                         |  72 +----
 drivers/gpu/drm/drm_mipi_dsi.c                     |   6 +-
 drivers/gpu/drm/exynos/exynos_dp_core.c            |  53 ++--
 drivers/gpu/drm/exynos/exynos_dp_core.h            |   1 +
 drivers/gpu/drm/msm/hdmi/hdmi.c                    |   4 +-
 drivers/gpu/drm/msm/hdmi/hdmi.h                    |   1 +
 drivers/gpu/drm/msm/hdmi/hdmi_bridge.c             |   7 +-
 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c    |  33 ++-
 drivers/gpu/drm/panel/panel-simple.c               |  57 ++++
 drivers/gpu/drm/sti/sti_dvo.c                      |  29 +-
 drivers/gpu/drm/sti/sti_hda.c                      |  11 +-
 drivers/gpu/drm/sti/sti_hdmi.c                     |  11 +-
 include/drm/bridge/ptn3460.h                       |   8 +
 include/drm/drm_crtc.h                             |  27 +-
 25 files changed, 531 insertions(+), 294 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/panel/avic,tm070ddh03.txt
 create mode 100644 Documentation/devicetree/bindings/panel/giantplus,gpg482739qs5.txt
 create mode 100644 Documentation/devicetree/bindings/video/bridge/ps8622.txt
 rename Documentation/devicetree/bindings/{drm => video}/bridge/ptn3460.txt (65%)
 create mode 100644 drivers/gpu/drm/drm_bridge.c
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-28  9:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-23 13:56 [GIT PULL] drm/panel: Changes for v3.20-rc1 Thierry Reding
2015-01-26  9:07 ` Jani Nikula
2015-01-26  9:53   ` Thierry Reding
2015-01-26 10:28     ` Jani Nikula
  -- strict thread matches above, loose matches on Subject: below --
2015-01-28  9:04 Thierry Reding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.