All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: add modpram 'skip_otp' to ignore empty otp error during BMI
Date: Mon, 17 Nov 2014 16:41:47 +0200	[thread overview]
Message-ID: <87a93pq47o.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1415366205-11672-1-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Fri, 7 Nov 2014 18:46:44 +0530")

Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:

> This patch would help bring up wifi interface with default board
> data in case of failures in otp download. It is useful for initial
> caliberation.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>

[...]

> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -31,12 +31,15 @@
>  unsigned int ath10k_debug_mask;
>  static bool uart_print;
>  static unsigned int ath10k_p2p;
> +static bool skip_otp;
>  module_param_named(debug_mask, ath10k_debug_mask, uint, 0644);
>  module_param(uart_print, bool, 0644);
>  module_param_named(p2p, ath10k_p2p, uint, 0644);
> +module_param(skip_otp, bool, 0644);
>  MODULE_PARM_DESC(debug_mask, "Debugging mask");
>  MODULE_PARM_DESC(uart_print, "Uart target debugging");
>  MODULE_PARM_DESC(p2p, "Enable ath10k P2P support");
> +MODULE_PARM_DESC(skip_otp, "Skip otp failure for calibration in testmode");

I added back the newlines:

--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -32,10 +32,12 @@ unsigned int ath10k_debug_mask;
 static bool uart_print;
 static unsigned int ath10k_p2p;
 static bool skip_otp;
+
 module_param_named(debug_mask, ath10k_debug_mask, uint, 0644);
 module_param(uart_print, bool, 0644);
 module_param_named(p2p, ath10k_p2p, uint, 0644);
 module_param(skip_otp, bool, 0644);
+
 MODULE_PARM_DESC(debug_mask, "Debugging mask");
 MODULE_PARM_DESC(uart_print, "Uart target debugging");
 MODULE_PARM_DESC(p2p, "Enable ath10k P2P support");

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath10k: add modpram 'skip_otp' to ignore empty otp error during BMI
Date: Mon, 17 Nov 2014 16:41:47 +0200	[thread overview]
Message-ID: <87a93pq47o.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1415366205-11672-1-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Fri, 7 Nov 2014 18:46:44 +0530")

Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:

> This patch would help bring up wifi interface with default board
> data in case of failures in otp download. It is useful for initial
> caliberation.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>

[...]

> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -31,12 +31,15 @@
>  unsigned int ath10k_debug_mask;
>  static bool uart_print;
>  static unsigned int ath10k_p2p;
> +static bool skip_otp;
>  module_param_named(debug_mask, ath10k_debug_mask, uint, 0644);
>  module_param(uart_print, bool, 0644);
>  module_param_named(p2p, ath10k_p2p, uint, 0644);
> +module_param(skip_otp, bool, 0644);
>  MODULE_PARM_DESC(debug_mask, "Debugging mask");
>  MODULE_PARM_DESC(uart_print, "Uart target debugging");
>  MODULE_PARM_DESC(p2p, "Enable ath10k P2P support");
> +MODULE_PARM_DESC(skip_otp, "Skip otp failure for calibration in testmode");

I added back the newlines:

--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -32,10 +32,12 @@ unsigned int ath10k_debug_mask;
 static bool uart_print;
 static unsigned int ath10k_p2p;
 static bool skip_otp;
+
 module_param_named(debug_mask, ath10k_debug_mask, uint, 0644);
 module_param(uart_print, bool, 0644);
 module_param_named(p2p, ath10k_p2p, uint, 0644);
 module_param(skip_otp, bool, 0644);
+
 MODULE_PARM_DESC(debug_mask, "Debugging mask");
 MODULE_PARM_DESC(uart_print, "Uart target debugging");
 MODULE_PARM_DESC(p2p, "Enable ath10k P2P support");

-- 
Kalle Valo

  parent reply	other threads:[~2014-11-17 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 13:16 [PATCH 1/2] ath10k: add modpram 'skip_otp' to ignore empty otp error during BMI Rajkumar Manoharan
2014-11-07 13:16 ` Rajkumar Manoharan
2014-11-07 13:16 ` [PATCH 2/2] ath10k: Advertise support for AP mode channel width changes Rajkumar Manoharan
2014-11-07 13:16   ` Rajkumar Manoharan
2014-11-17 14:43   ` Kalle Valo
2014-11-17 14:43     ` Kalle Valo
2014-11-17 14:41 ` Kalle Valo [this message]
2014-11-17 14:41   ` [PATCH 1/2] ath10k: add modpram 'skip_otp' to ignore empty otp error during BMI Kalle Valo
2014-11-17 14:48 ` Kalle Valo
2014-11-17 14:48   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a93pq47o.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rmanohar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.