All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v4 1/5] ath10k:  provide firmware crash info via debugfs.
Date: Wed, 23 Jul 2014 20:37:23 +0300	[thread overview]
Message-ID: <87a980rn70.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1406133487-7541-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Wed, 23 Jul 2014 09:38:03 -0700")

greearb@candelatech.com writes:

> From: Ben Greear <greearb@candelatech.com>
>
> Store the firmware crash registers and last 128 or so
> firmware debug-log ids and present them to user-space
> via debugfs.
>
> Should help with figuring out why the firmware crashed.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v4:  Use _bh spinlock variants everywhere.
>
> For patch 0005:  Fix kmalloc/vfree problem. 

I see quite a few sparse and checkpatch warnings. But I think we can
ignore about LINUX_VERSION_CODE.

drivers/net/wireless/ath/ath10k/debug.c: In function 'ath10k_build_dump_file':
drivers/net/wireless/ath/ath10k/debug.c:685:2: warning: right shift count >= width of type [enabled by default]
drivers/net/wireless/ath/ath10k/debug.c:687:2: warning: right shift count >= width of type [enabled by default]
drivers/net/wireless/ath/ath10k/debug.c:685:49: warning: shift too big (32) for type long
drivers/net/wireless/ath/ath10k/debug.c:687:51: warning: shift too big (32) for type long
drivers/net/wireless/ath/ath10k/core.c:491:53: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/core.c:492:52: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/core.c:493:53: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/core.c:494:52: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/core.c:491: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/core.c:492: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/core.c:493: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/core.c:494: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/core.c:495: CHECK: multiple assignments should be avoided
drivers/net/wireless/ath/ath10k/debug.c:680: WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged
drivers/net/wireless/ath/ath10k/debug.c:696: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/debug.c:703: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/debug.c:725: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/debug.c:733: WARNING: line over 80 characters

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH v4 1/5] ath10k:  provide firmware crash info via debugfs.
Date: Wed, 23 Jul 2014 20:37:23 +0300	[thread overview]
Message-ID: <87a980rn70.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1406133487-7541-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Wed, 23 Jul 2014 09:38:03 -0700")

greearb@candelatech.com writes:

> From: Ben Greear <greearb@candelatech.com>
>
> Store the firmware crash registers and last 128 or so
> firmware debug-log ids and present them to user-space
> via debugfs.
>
> Should help with figuring out why the firmware crashed.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v4:  Use _bh spinlock variants everywhere.
>
> For patch 0005:  Fix kmalloc/vfree problem. 

I see quite a few sparse and checkpatch warnings. But I think we can
ignore about LINUX_VERSION_CODE.

drivers/net/wireless/ath/ath10k/debug.c: In function 'ath10k_build_dump_file':
drivers/net/wireless/ath/ath10k/debug.c:685:2: warning: right shift count >= width of type [enabled by default]
drivers/net/wireless/ath/ath10k/debug.c:687:2: warning: right shift count >= width of type [enabled by default]
drivers/net/wireless/ath/ath10k/debug.c:685:49: warning: shift too big (32) for type long
drivers/net/wireless/ath/ath10k/debug.c:687:51: warning: shift too big (32) for type long
drivers/net/wireless/ath/ath10k/core.c:491:53: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/core.c:492:52: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/core.c:493:53: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/core.c:494:52: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/core.c:491: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/core.c:492: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/core.c:493: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/core.c:494: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/core.c:495: CHECK: multiple assignments should be avoided
drivers/net/wireless/ath/ath10k/debug.c:680: WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged
drivers/net/wireless/ath/ath10k/debug.c:696: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/debug.c:703: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/debug.c:725: WARNING: line over 80 characters
drivers/net/wireless/ath/ath10k/debug.c:733: WARNING: line over 80 characters

-- 
Kalle Valo

  parent reply	other threads:[~2014-07-23 17:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 16:38 [PATCH v4 1/5] ath10k: provide firmware crash info via debugfs greearb
2014-07-23 16:38 ` greearb
2014-07-23 16:38 ` [PATCH v4 2/5] ath10k: save firmware debug log messages greearb
2014-07-23 16:38   ` greearb
2014-07-23 16:38 ` [PATCH v4 3/5] ath10k: save firmware stack upon firmware crash greearb
2014-07-23 16:38   ` greearb
2014-07-23 16:38 ` [PATCH v4 4/5] ath10k: Dump exception stack contents on " greearb
2014-07-23 16:38   ` greearb
2014-07-23 16:38 ` [PATCH v4 5/5] ath10k: save firmware RAM and ROM BSS sections on crash greearb
2014-07-23 16:38   ` greearb
2014-07-23 17:37 ` Kalle Valo [this message]
2014-07-23 17:37   ` [PATCH v4 1/5] ath10k: provide firmware crash info via debugfs Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a980rn70.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.