Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

[Markus Armbruster <armbru@redhat.com>]

Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:

> Following our discussion RE self asserting API calls, here is a spin of
> my proposal. This series obsoletes the need for _nofail variants for
> Error ** accepting APIs. Is also greately reduces the verbosity of calls
> sites that are currently asserting against errors.
>
> Patch 1 is the main event - addition of error_abort. The following
> patches then cleanup uses of _nofail and assert_no_error().
>
> To give it a smoke test, I introduce a (critical) bug into QOM:
[...]
>  32 files changed, 100 insertions(+), 143 deletions(-)

I like it.  Nice diffstat, too.

There are some _nofail functions left, but none of them can use
error_abort.

If anything assigns to error_abort, we're probably screwed.  No bright
idea how to prevent that at compile-time.