From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] alsa-lib: fix noMMU build
Date: Sat, 09 Mar 2013 21:15:33 +0100 [thread overview]
Message-ID: <87a9qc2uu2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1362853290-15592-3-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sat, 9 Mar 2013 19:21:27 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Add a patch to use vfork() instead of fork().
Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas> ---
Thomas> package/alsa-lib/alsa-lib-no-mmu.patch | 44 ++++++++++++++++++++++++++++++++
Thomas> package/alsa-lib/alsa-lib.mk | 1 +
Thomas> 2 files changed, 45 insertions(+)
Thomas> create mode 100644 package/alsa-lib/alsa-lib-no-mmu.patch
Thomas> diff --git a/package/alsa-lib/alsa-lib-no-mmu.patch b/package/alsa-lib/alsa-lib-no-mmu.patch
Thomas> new file mode 100644
Thomas> index 0000000..317676a
Thomas> --- /dev/null
Thomas> +++ b/package/alsa-lib/alsa-lib-no-mmu.patch
Thomas> @@ -0,0 +1,44 @@
Thomas> +Don't use fork() on noMMU platforms
Thomas> +
Thomas> +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas> +
Thomas> +Index: alsa-lib-1.0.26/configure.in
Thomas> +===================================================================
Thomas> +--- alsa-lib-1.0.26.orig/configure.in 2012-09-06 10:55:14.000000000 +0200
Thomas> ++++ alsa-lib-1.0.26/configure.in 2013-03-09 16:22:08.000000000 +0100
Thomas> +@@ -66,6 +66,8 @@
Thomas> + AM_CONDITIONAL(ALSA_HSEARCH_R, [test "x$HAVE_HSEARCH_R" != xyes])
Thomas> + AC_CHECK_FUNCS([uselocale])
Thomas> +
Thomas> ++AC_CHECK_FUNC([fork])
Thomas> ++
Thomas> + SAVE_LIBRARY_VERSION
Thomas> + AC_SUBST(LIBTOOL_VERSION_INFO)
Thomas> +
Thomas> +Index: alsa-lib-1.0.26/src/pcm/pcm_direct.c
Thomas> +===================================================================
Thomas> +--- alsa-lib-1.0.26.orig/src/pcm/pcm_direct.c 2012-09-06 10:55:14.000000000 +0200
Thomas> ++++ alsa-lib-1.0.26/src/pcm/pcm_direct.c 2013-03-09 16:22:51.000000000 +0100
Thomas> +@@ -424,13 +424,21 @@
Thomas> + close(dmix->server_fd);
Thomas> + return ret;
Thomas> + }
Thomas> +-
Thomas> ++
Thomas> ++#ifdef HAVE_FORK
Thomas> + ret = fork();
Thomas> ++#else
Thomas> ++ ret = vfork();
Are you sending this upstream? What's the reason for the HAVE_FORK
check? Why not just always use vfork() instead? That should work fine on
mmu as well (and be a tiny bit faster).
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-03-09 20:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 18:21 [Buildroot] Some misc fixes and improvements Thomas Petazzoni
2013-03-09 18:21 ` [Buildroot] [PATCH 1/5] aircrack-ng: disable on non-MMU systems Thomas Petazzoni
2013-03-09 20:11 ` Peter Korsgaard
2013-03-09 18:21 ` [Buildroot] [PATCH 2/5] alsa-lib: fix noMMU build Thomas Petazzoni
2013-03-09 20:15 ` Peter Korsgaard [this message]
2013-03-10 10:48 ` Thomas Petazzoni
2013-03-10 20:23 ` Peter Korsgaard
2013-03-09 18:21 ` [Buildroot] [PATCH 3/5] libglib2: don't build tests Thomas Petazzoni
2013-03-09 20:17 ` Peter Korsgaard
2013-03-09 18:21 ` [Buildroot] [PATCH 4/5] libglib2: fix noMMU build Thomas Petazzoni
2013-03-09 18:21 ` [Buildroot] [PATCH 5/5] libglib2: use system pcre when available Thomas Petazzoni
2013-03-09 20:18 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9qc2uu2.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.