All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] alsa-lib: fix noMMU build
Date: Sun, 10 Mar 2013 21:23:28 +0100	[thread overview]
Message-ID: <87ppz7ypfj.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20130310114842.4cd6647e@skate> (Thomas Petazzoni's message of "Sun, 10 Mar 2013 11:48:42 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Dear Peter Korsgaard,
 Thomas> On Sat, 09 Mar 2013 21:15:33 +0100, Peter Korsgaard wrote:

 >> Are you sending this upstream? What's the reason for the HAVE_FORK
 >> check? Why not just always use vfork() instead? That should work fine on
 >> mmu as well (and be a tiny bit faster).

 Thomas> I could possibly send this upstream, yes. The reason to use
 Thomas> HAVE_FORK is to not change the MMU code, which probably is
 Thomas> going to make the patch easier to get merged upstream, and also
 Thomas> because that's the way the Blackfin people handled the problem.

I would say just the opposite. As you know, you have to be careful
(because parent/child is sharing memory) when you convert from fork to
vfork, so as a maintainer I wouldn't like to only do it for a very small
subset of machines (that he probably cannot easily test himself).

Either the conversion is correct, and should be done for everyone so it
keeps working or it shouldn't be done.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-03-10 20:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09 18:21 [Buildroot] Some misc fixes and improvements Thomas Petazzoni
2013-03-09 18:21 ` [Buildroot] [PATCH 1/5] aircrack-ng: disable on non-MMU systems Thomas Petazzoni
2013-03-09 20:11   ` Peter Korsgaard
2013-03-09 18:21 ` [Buildroot] [PATCH 2/5] alsa-lib: fix noMMU build Thomas Petazzoni
2013-03-09 20:15   ` Peter Korsgaard
2013-03-10 10:48     ` Thomas Petazzoni
2013-03-10 20:23       ` Peter Korsgaard [this message]
2013-03-09 18:21 ` [Buildroot] [PATCH 3/5] libglib2: don't build tests Thomas Petazzoni
2013-03-09 20:17   ` Peter Korsgaard
2013-03-09 18:21 ` [Buildroot] [PATCH 4/5] libglib2: fix noMMU build Thomas Petazzoni
2013-03-09 18:21 ` [Buildroot] [PATCH 5/5] libglib2: use system pcre when available Thomas Petazzoni
2013-03-09 20:18   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppz7ypfj.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.