From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: Marek Vasut <marex@denx.de>,
alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Igor Grinberg <grinberg@compulab.co.il>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] ALSA: pxa27x: ac97 reset fixes
Date: Sun, 06 Jan 2013 21:33:55 +0100 [thread overview]
Message-ID: <87a9smaw5o.fsf@free.fr> (raw)
In-Reply-To: <1357499640-13871-1-git-send-email-mikedunn@newsguy.com> (Mike Dunn's message of "Sun, 6 Jan 2013 11:13:56 -0800")
Mike Dunn <mikedunn@newsguy.com> writes:
> AC97 reset is broken on the pxa27x. These patches fix it by addressing multiple
> problems:
> - cold reset fails because the GCR register is not set correctly
> - warm reset fails because some code used to work around a hardware bug is
> broken
> - the intent of the work-around code is obfuscated by unfortunate function
> naming
>
> This patch set replaces some earlier individual patches that had some problems.
> Thanks Robert and Igor.
Yes, this looks good. I'll test that one, but it does indeed look promising.
Igor, your opinion here ?
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] ALSA: pxa27x: ac97 reset fixes
Date: Sun, 06 Jan 2013 21:33:55 +0100 [thread overview]
Message-ID: <87a9smaw5o.fsf@free.fr> (raw)
In-Reply-To: <1357499640-13871-1-git-send-email-mikedunn@newsguy.com> (Mike Dunn's message of "Sun, 6 Jan 2013 11:13:56 -0800")
Mike Dunn <mikedunn@newsguy.com> writes:
> AC97 reset is broken on the pxa27x. These patches fix it by addressing multiple
> problems:
> - cold reset fails because the GCR register is not set correctly
> - warm reset fails because some code used to work around a hardware bug is
> broken
> - the intent of the work-around code is obfuscated by unfortunate function
> naming
>
> This patch set replaces some earlier individual patches that had some problems.
> Thanks Robert and Igor.
Yes, this looks good. I'll test that one, but it does indeed look promising.
Igor, your opinion here ?
Cheers.
--
Robert
next prev parent reply other threads:[~2013-01-06 20:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 19:13 [PATCH 0/4] ALSA: pxa27x: ac97 reset fixes Mike Dunn
2013-01-06 19:13 ` Mike Dunn
2013-01-06 19:13 ` [PATCH 1/4] ALSA: pxa2xx: fix ac97 cold reset Mike Dunn
2013-01-06 19:13 ` Mike Dunn
2013-01-07 9:16 ` Igor Grinberg
2013-01-07 9:16 ` Igor Grinberg
2013-01-07 13:36 ` Mike Dunn
2013-01-07 13:36 ` Mike Dunn
2013-01-07 13:57 ` Igor Grinberg
2013-01-07 13:57 ` Igor Grinberg
2013-01-07 14:19 ` Mike Dunn
2013-01-07 14:19 ` Mike Dunn
2013-01-07 15:28 ` Igor Grinberg
2013-01-07 15:28 ` Igor Grinberg
2013-01-06 19:13 ` [PATCH 2/4] ALSA: pxa27x: fix ac97 warm reset bug work-around code Mike Dunn
2013-01-06 19:13 ` Mike Dunn
2013-01-07 9:31 ` Igor Grinberg
2013-01-07 9:31 ` Igor Grinberg
2013-01-07 11:06 ` Russell King - ARM Linux
2013-01-07 11:06 ` Russell King - ARM Linux
2013-01-07 13:40 ` Mike Dunn
2013-01-07 13:40 ` Mike Dunn
2013-01-06 19:13 ` [PATCH 3/4] ALSA: pxa27x: ac97 controller driver requests gpio Mike Dunn
2013-01-06 19:13 ` Mike Dunn
2013-01-07 9:36 ` Igor Grinberg
2013-01-07 9:36 ` Igor Grinberg
2013-01-07 9:42 ` Igor Grinberg
2013-01-07 9:42 ` Igor Grinberg
2013-01-07 14:10 ` Mike Dunn
2013-01-07 14:10 ` Mike Dunn
2013-01-07 15:38 ` Igor Grinberg
2013-01-07 15:38 ` Igor Grinberg
2013-01-07 16:40 ` Mike Dunn
2013-01-07 16:40 ` Mike Dunn
2013-01-06 19:14 ` [PATCH 4/4] ALSA: pxa27x: rename pxa27x_assert_ac97() Mike Dunn
2013-01-06 19:14 ` Mike Dunn
2013-01-07 9:39 ` Igor Grinberg
2013-01-07 9:39 ` Igor Grinberg
2013-01-07 14:34 ` Mike Dunn
2013-01-07 14:34 ` Mike Dunn
2013-01-07 15:41 ` Igor Grinberg
2013-01-07 15:41 ` Igor Grinberg
2013-01-06 20:33 ` Robert Jarzmik [this message]
2013-01-06 20:33 ` [PATCH 0/4] ALSA: pxa27x: ac97 reset fixes Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9smaw5o.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric.y.miao@gmail.com \
--cc=grinberg@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=mikedunn@newsguy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.