From: Kevin Hilman <khilman@ti.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Vishwanath BS <vishwanath.bs@ti.com>
Subject: Re: [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4
Date: Tue, 19 Apr 2011 15:50:46 -0700 [thread overview]
Message-ID: <87aaflam9l.fsf@ti.com> (raw)
In-Reply-To: <1302787318-6650-1-git-send-email-jhnikula@gmail.com> (Jarkko Nikula's message of "Thu, 14 Apr 2011 16:21:58 +0300")
Jarkko Nikula <jhnikula@gmail.com> writes:
> Fix this typo as there is no dpll_mpu_ck for OMAP3 and code flow is clearly
> trying to set mpu_clk for OMAP4 for which this dpll_mpu_ck is available.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Thanks, applied to pm-wip/cpufreq branch.
Kevin
> ---
> arch/arm/mach-omap2/omap2plus-cpufreq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> index 8d472f6..d53ce23 100644
> --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
> +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> @@ -161,7 +161,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
> mpu_clk = clk_get(NULL, "virt_prcm_set");
> else if (cpu_is_omap34xx())
> mpu_clk = clk_get(NULL, "dpll1_ck");
> - else if (cpu_is_omap34xx())
> + else if (cpu_is_omap44xx())
> mpu_clk = clk_get(NULL, "dpll_mpu_ck");
>
> if (IS_ERR(mpu_clk))
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4
Date: Tue, 19 Apr 2011 15:50:46 -0700 [thread overview]
Message-ID: <87aaflam9l.fsf@ti.com> (raw)
In-Reply-To: <1302787318-6650-1-git-send-email-jhnikula@gmail.com> (Jarkko Nikula's message of "Thu, 14 Apr 2011 16:21:58 +0300")
Jarkko Nikula <jhnikula@gmail.com> writes:
> Fix this typo as there is no dpll_mpu_ck for OMAP3 and code flow is clearly
> trying to set mpu_clk for OMAP4 for which this dpll_mpu_ck is available.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Thanks, applied to pm-wip/cpufreq branch.
Kevin
> ---
> arch/arm/mach-omap2/omap2plus-cpufreq.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> index 8d472f6..d53ce23 100644
> --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
> +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> @@ -161,7 +161,7 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
> mpu_clk = clk_get(NULL, "virt_prcm_set");
> else if (cpu_is_omap34xx())
> mpu_clk = clk_get(NULL, "dpll1_ck");
> - else if (cpu_is_omap34xx())
> + else if (cpu_is_omap44xx())
> mpu_clk = clk_get(NULL, "dpll_mpu_ck");
>
> if (IS_ERR(mpu_clk))
next prev parent reply other threads:[~2011-04-19 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 13:21 [PATCH linux-omap-pm/pm-wip/cpufreq] OMAP2PLUS: cpufreq: Fix typo when attempting to set mpu_clk for OMAP4 Jarkko Nikula
2011-04-14 13:21 ` Jarkko Nikula
2011-04-14 15:02 ` Santosh Shilimkar
2011-04-14 15:02 ` Santosh Shilimkar
2011-04-19 22:50 ` Kevin Hilman [this message]
2011-04-19 22:50 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aaflam9l.fsf@ti.com \
--to=khilman@ti.com \
--cc=jhnikula@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.