From: Francisco Jerez <currojerez@riseup.net>
To: chris.nicholson@cnick.org.uk
Cc: airlied@linux.ie, bskeggs@redhat.com, madman2003@gmail.com,
koriakin@0x04.net, tacconet@libero.it,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Gpu: drm: fix buffer overflow in nouveau_bios.c
Date: Sat, 20 Feb 2010 20:58:15 +0100 [thread overview]
Message-ID: <87aav3wug8.fsf@riseup.net> (raw)
In-Reply-To: <1266691783-25029-1-git-send-email-chris.nicholson@cnick.org.uk> (chris nicholson's message of "Sat, 20 Feb 2010 18:49:43 +0000")
[-- Attachment #1.1: Type: text/plain, Size: 1018 bytes --]
chris.nicholson@cnick.org.uk writes:
> From: Chris Nicholson <chris@port.cnick.org.uk>
>
> This is a patch to the nouveau_bios.c file that fixes up a
> buffer overflow
>
This bug was already fixed upstream (774baeb0ba92bcb082f9868726a27a015c9a0897).
In any case, thank you.
> Signed-off-by: Chris Nicholson <chris.nicholson@cnick.org.uk>
> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 0e9cd1d..c1cee91 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -762,7 +762,7 @@ static uint32_t get_tmds_index_reg(struct drm_device *dev, uint8_t mlv)
> dacoffset ^= 8;
> return 0x6808b0 + dacoffset;
> } else {
> - if (mlv > ARRAY_SIZE(pramdac_table)) {
> + if (mlv >= ARRAY_SIZE(pramdac_table)) {
> NV_ERROR(dev, "Magic Lookup Value too big (%02X)\n",
> mlv);
> return 0;
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Francisco Jerez <currojerez@riseup.net>
To: chris.nicholson@cnick.org.uk
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
bskeggs@redhat.com, dri-devel@lists.sourceforge.net,
tacconet@libero.it
Subject: Re: [PATCH] Gpu: drm: fix buffer overflow in nouveau_bios.c
Date: Sat, 20 Feb 2010 20:58:15 +0100 [thread overview]
Message-ID: <87aav3wug8.fsf@riseup.net> (raw)
In-Reply-To: <1266691783-25029-1-git-send-email-chris.nicholson@cnick.org.uk> (chris nicholson's message of "Sat, 20 Feb 2010 18:49:43 +0000")
[-- Attachment #1.1.1: Type: text/plain, Size: 1018 bytes --]
chris.nicholson@cnick.org.uk writes:
> From: Chris Nicholson <chris@port.cnick.org.uk>
>
> This is a patch to the nouveau_bios.c file that fixes up a
> buffer overflow
>
This bug was already fixed upstream (774baeb0ba92bcb082f9868726a27a015c9a0897).
In any case, thank you.
> Signed-off-by: Chris Nicholson <chris.nicholson@cnick.org.uk>
> ---
> drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
> index 0e9cd1d..c1cee91 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
> @@ -762,7 +762,7 @@ static uint32_t get_tmds_index_reg(struct drm_device *dev, uint8_t mlv)
> dacoffset ^= 8;
> return 0x6808b0 + dacoffset;
> } else {
> - if (mlv > ARRAY_SIZE(pramdac_table)) {
> + if (mlv >= ARRAY_SIZE(pramdac_table)) {
> NV_ERROR(dev, "Magic Lookup Value too big (%02X)\n",
> mlv);
> return 0;
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 345 bytes --]
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
next prev parent reply other threads:[~2010-02-20 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 18:49 [PATCH] Gpu: drm: fix buffer overflow in nouveau_bios.c chris.nicholson
2010-02-20 19:58 ` Francisco Jerez [this message]
2010-02-20 19:58 ` Francisco Jerez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aav3wug8.fsf@riseup.net \
--to=currojerez@riseup.net \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=chris.nicholson@cnick.org.uk \
--cc=dri-devel@lists.sourceforge.net \
--cc=koriakin@0x04.net \
--cc=linux-kernel@vger.kernel.org \
--cc=madman2003@gmail.com \
--cc=tacconet@libero.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.