[PATCH] parsecvs: produce tagger fields acceptable to newer git versions

[PATCH] parsecvs: produce tagger fields acceptable to newer git versions

[Lennert Buytenhek]

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>

diff --git a/git.c b/git.c
index da320d1..8f94d1b 100644
--- a/git.c
+++ b/git.c
@@ -371,11 +371,13 @@ git_mktag (rev_commit *commit, char *name)
 		"object %s\n"
 		"type commit\n"
 		"tag %s\n"
-		"tagger %s\n"
+		"tagger %s <%s> %lu +0000\n"
 		"\n",
 		commit->sha1,
 		name,
-		author ? author->full : commit->author);
+		author ? author->full : commit->author,
+		author ? author->email : commit->author,
+		commit->date);
     if (rv < 1) {
 	fprintf (stderr, "%s: %s\n", filename, strerror (errno));
 	fclose (f);

Re: [PATCH] parsecvs: produce tagger fields acceptable to newer git versions

[Jim Meyering]

Lennert Buytenhek <buytenh@wantstofly.org> wrote:

> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
>
> diff --git a/git.c b/git.c
> index da320d1..8f94d1b 100644
> --- a/git.c
> +++ b/git.c
> @@ -371,11 +371,13 @@ git_mktag (rev_commit *commit, char *name)
>  		"object %s\n"
>  		"type commit\n"
>  		"tag %s\n"
> -		"tagger %s\n"
> +		"tagger %s <%s> %lu +0000\n"
>  		"\n",
>  		commit->sha1,
>  		name,
> -		author ? author->full : commit->author);
> +		author ? author->full : commit->author,
> +		author ? author->email : commit->author,
> +		commit->date);
>      if (rv < 1) {
>  	fprintf (stderr, "%s: %s\n", filename, strerror (errno));
>  	fclose (f);

Hi Lennert,

I posted the same patch a while back.

    http://markmail.org/message/cebh7suc7ejpayos

However, I never heard back.
You'll also need the patch below, if you're building
against a newer version of git.


>From 93bc277dff113f1133ef25b8bb985af80f1fbe0e Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Thu, 6 Nov 2008 11:35:09 +0100
Subject: [PATCH 2/2] * tree.c (init_tree): Adapt to new git_config API.

---
 tree.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tree.c b/tree.c
index a76f27c..e2a041c 100644
--- a/tree.c
+++ b/tree.c
@@ -177,7 +177,7 @@ rev_commit *create_tree(rev_commit *leader)

 void init_tree(int n)
 {
-	git_config(git_default_config);
+	git_config(git_default_config, NULL);
 	strip = n;
 }

--
1.6.1.331.g9c367

Re: [PATCH] parsecvs: produce tagger fields acceptable to newer git versions

[Lennert Buytenhek]

On Mon, Jan 19, 2009 at 01:44:06PM +0100, Jim Meyering wrote:

> > Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
> >
> > diff --git a/git.c b/git.c
> > index da320d1..8f94d1b 100644
> > --- a/git.c
> > +++ b/git.c
> > @@ -371,11 +371,13 @@ git_mktag (rev_commit *commit, char *name)
> >  		"object %s\n"
> >  		"type commit\n"
> >  		"tag %s\n"
> > -		"tagger %s\n"
> > +		"tagger %s <%s> %lu +0000\n"
> >  		"\n",
> >  		commit->sha1,
> >  		name,
> > -		author ? author->full : commit->author);
> > +		author ? author->full : commit->author,
> > +		author ? author->email : commit->author,
> > +		commit->date);
> >      if (rv < 1) {
> >  	fprintf (stderr, "%s: %s\n", filename, strerror (errno));
> >  	fclose (f);
> 
> Hi Lennert,

Hey Jim,


> I posted the same patch a while back.
> 
>     http://markmail.org/message/cebh7suc7ejpayos
> 
> However, I never heard back.
> You'll also need the patch below, if you're building
> against a newer version of git.

Can you make your parsecvs repository available somewhere?


thanks,
Lennert