How to call a command from another one

How to call a command from another one

[adrian15]

Hi,

	I want to implement the pause command so that it is the same thing as
the echo command with all of its options and also that it stops.

	My first approach which I could not compile because I do not how to add
a new command to grub2 is the following one:


   char key;
   if (argc!=0)
     grub_cmd_echo(state,argc,args);
   key = grub_getkey ();

   return 0;



So my question is if it's an orthodox way of calling another command, if
I should call it in another way or if I should not call it in any way.

adrian15

Re: How to call a command from another one

[Robert Millan]

On Tue, Jun 12, 2007 at 01:57:11PM +0200, adrian15 wrote:
> Hi,
> 
> 	I want to implement the pause command so that it is the same thing as
> the echo command with all of its options and also that it stops.
> 
> 	My first approach which I could not compile because I do not how to 
> 	add
> a new command to grub2 is the following one:
> 
> 
>   char key;
>   if (argc!=0)
>     grub_cmd_echo(state,argc,args);
>   key = grub_getkey ();
> 
>   return 0;
> 
> 
> 
> So my question is if it's an orthodox way of calling another command, if
> I should call it in another way or if I should not call it in any way.

I don't know how to call other commands, but in this case, maybe grub_printf()
will be good enough?

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.

Re: How to call a command from another one

[adrian15]

Robert Millan escribió:
> On Tue, Jun 12, 2007 at 01:57:11PM +0200, adrian15 wrote:
>> Hi,
>>
>> 	I want to implement the pause command so that it is the same thing as
>> the echo command with all of its options and also that it stops.
> I don't know how to call other commands, but in this case, maybe grub_printf()
> will be good enough?

I agree with you but...

I think it would be a good idea to have a pause message that has the 
same options as the echo command because the echo command has some nice 
options and because I like to reuse code.

adrian15

Re: How to call a command from another one

[Marco Gerards]

adrian15 <adrian15@raulete.net> writes:

> Robert Millan escribió:
>> On Tue, Jun 12, 2007 at 01:57:11PM +0200, adrian15 wrote:
>>> Hi,
>>>
>>> 	I want to implement the pause command so that it is the same thing as
>>> the echo command with all of its options and also that it stops.
>> I don't know how to call other commands, but in this case, maybe grub_printf()
>> will be good enough?
>
> I agree with you but...
>
> I think it would be a good idea to have a pause message that has the
> same options as the echo command because the echo command has some
> nice options and because I like to reuse code.

Make them share the same file.  Call grub_cmd_echo with the same
arguments which are used for pause.  Before and after that you can do
whatever you want.  The disadvantage of this approach is that the set
of arguments should be the same.

--
Marco