Re: vesafb terminal for testing.

[Marco Gerards <metgerards@student.han.nl>]

Vesa Jääskeläinen <chaac@nic.fi> writes:

>> There are some long lines, can you please make them shorter so
>> the maximal line length is 78 characters?
>
> Hmm... I made another scan for those. Still I left some of those there
> because in my opinion it is much more readable in that way. But splitted
> some lines.

Can you should me which so I can come up with a suggestion?

>> You sometimes use C++ style comments.  Can you change your comments so
>> they match the style described in the GCS:
>> http://www.gnu.org/prep/standards/html_node/Comments.html#Comments
>
> I think there should not be anymore C++ style comments. It's hard to
> stay away from ooooold habits :)
>
> Fortunely I found GNU indentation mode from my editor :)... It makes
> this a bit easier.
>
> I will scan the code once more and then commit a bit different version
> to CVS as Okuji asked to commit it to there for easier testing.

Cool, fine for me. :)

Thanks,
Marco