From: Olaf Dietsche <olaf.dietsche#list.linux-kernel@t-online.de>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] 2.5.42: remove capable(CAP_SYS_RAWIO) check from open_kmem
Date: Sun, 13 Oct 2002 17:48:37 +0200 [thread overview]
Message-ID: <87adliuyp6.fsf@goat.bogus.local> (raw)
In-Reply-To: 3DA985E6.6090302@colorfullife.com
Manfred Spraul <manfred@colorfullife.com> writes:
>> In drivers/char/mem.c there's open_port(), which is used as open_mem()
>> and open_kmem() as well. I don't see the benefit of this, since
>> /dev/mem and /dev/kmem are already protected by filesystem
>> permissions.
>>
> capabilities can be stricter than filesystem permissions
Which means, it prevents me from giving access to /dev/kmem to an
otherwise unprivileged process.
> , and the call
> is needed to update the PF_SUPERPRIV process flag.
What exactly is PF_SUPERPRIV good for? I see no real use in the
source. There is exactly one test for this flag (kernel/acct.c:336),
then sets another flag (ASU), which in turn is used nowhere else.
So, I think we could get rid of this flag as well. Comments?
Regards, Olaf.
next parent reply other threads:[~2002-10-13 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3DA985E6.6090302@colorfullife.com>
2002-10-13 15:48 ` Olaf Dietsche [this message]
[not found] ` <3DA99A8B.5050102@colorfullife.com>
2002-10-13 16:45 ` [PATCH][RFC] 2.5.42: remove capable(CAP_SYS_RAWIO) check from open_kmem Olaf Dietsche
2002-10-13 17:04 ` Manfred Spraul
2002-10-13 22:05 ` Olaf Dietsche
2002-10-17 11:42 ` Andreas Steinmetz
2002-10-13 12:46 Olaf Dietsche
2002-10-17 11:00 ` Olaf Dietsche
2002-10-17 11:32 ` Chris Evans
2002-10-17 12:30 ` Chris Wright
2002-10-17 14:14 ` Olaf Dietsche
[not found] ` <200210171807.33178.oliver@neukum.name>
2002-10-17 17:00 ` Olaf Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87adliuyp6.fsf@goat.bogus.local \
--to=olaf.dietsche#list.linux-kernel@t-online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.