All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <mwalle@kernel.org>
Cc: "Itai Handler" <itai.handler@gmail.com>,  <pratyush@kernel.org>,
	<richard@nod.at>,  <vigneshr@ti.com>,
	 <takahiro.kuwano@infineon.com>, <tudor.ambarus@linaro.org>,
	 <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	 <stable@vger.kernel.org>
Subject: Re: [PATCH v5] mtd: spi-nor: take the flash lock around spi_nor_restore()
Date: Wed, 18 Nov 2026 15:23:09 +0100	[thread overview]
Message-ID: <87bj7mi5gy.fsf@bootlin.com> (raw)
In-Reply-To: <DMYDITU0H48Z.2LA5KF2TFNUY2@kernel.org> (Michael Walle's message of "Wed, 18 Nov 2026 14:33:44 +0100")


>> +static void spi_nor_lock_and_restore(struct spi_nor *nor)
>> +{
>> +	int ret;
>> +
>> +	ret = spi_nor_prep_and_lock(nor);
>> +	if (ret == -ESHUTDOWN)
>
> This is actually really hard to follow.

Yes, I tried to review this patch and eventually stopped. Please teach
your AI to not overengineer its solutions.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <mwalle@kernel.org>
Cc: "Itai Handler" <itai.handler@gmail.com>,  <pratyush@kernel.org>,
	<richard@nod.at>,  <vigneshr@ti.com>,
	 <takahiro.kuwano@infineon.com>, <tudor.ambarus@linaro.org>,
	 <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	 <stable@vger.kernel.org>
Subject: Re: [PATCH v5] mtd: spi-nor: take the flash lock around spi_nor_restore()
Date: Wed, 18 Nov 2026 15:23:09 +0100	[thread overview]
Message-ID: <87bj7mi5gy.fsf@bootlin.com> (raw)
In-Reply-To: <DMYDITU0H48Z.2LA5KF2TFNUY2@kernel.org> (Michael Walle's message of "Wed, 18 Nov 2026 14:33:44 +0100")


>> +static void spi_nor_lock_and_restore(struct spi_nor *nor)
>> +{
>> +	int ret;
>> +
>> +	ret = spi_nor_prep_and_lock(nor);
>> +	if (ret == -ESHUTDOWN)
>
> This is actually really hard to follow.

Yes, I tried to review this patch and eventually stopped. Please teach
your AI to not overengineer its solutions.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-18 14:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 21:01 [PATCH v5] mtd: spi-nor: take the flash lock around spi_nor_restore() Itai Handler
2026-10-29 21:01 ` Itai Handler
2026-11-10  8:27 ` Itai Handler
2026-11-10  8:27   ` Itai Handler
2026-11-18 13:33 ` Michael Walle
2026-11-18 13:33   ` Michael Walle
2026-11-18 14:23   ` Miquel Raynal [this message]
2026-11-18 14:23     ` Miquel Raynal
2026-11-18 17:13     ` Itai Handler
2026-11-18 17:13       ` Itai Handler
2026-11-18 17:12   ` Itai Handler
2026-11-18 17:12     ` Itai Handler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bj7mi5gy.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=itai.handler@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    --cc=takahiro.kuwano@infineon.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.