All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jussi Laako <jussi@sonarnerd.net>
Cc: Salvador Blaya <tiniebla6@gmail.com>,
	alsa-devel@alsa-project.org, regressions@lists.linux.dev
Subject: Re: [REGRESSION] snd-usb-audio: commit da3a7efff64e ("ALSA: usb-audio: Update for native DSD support quirks") breaks DSD playback on Musical Fidelity M6s DAC (2772:0502), plays ~8.8% fast
Date: Thu, 09 Jul 2026 09:33:10 +0200	[thread overview]
Message-ID: <87bjcg4nyh.wl-tiwai@suse.de> (raw)
In-Reply-To: <4A4C8B42-D8BB-44D1-BE0B-CB5B4617F29E@sonarnerd.net>

On Thu, 09 Jul 2026 00:28:00 +0200,
Jussi Laako wrote:
> 
> Hi,
> 
> I don’t think we currently have exclusion method for devices with buggy firmware, which claim to support native DSD, but do it incorrectly. And reverting with device specific white-listing is not a good approach for future maintenance. Having to device-specific white-list each new device appearing on the market from the manufacturer just because some old device is broken is not really a sustainable model.

While I fully agree that white-listing all needed devices won't scale,
blacklisting the broken device might work.  We can an empty quirk
entry for 2772:0502 for skipping the vendor match, something like
below, as an ad hoc fix.

Though, this blindly assumes that there aren't so many broken devices,
and there will be no firmware fix or another model that works with the
same ID.  If a model is relatively new and/or the vendor often updates
the firmware, such an entry can be risky, too.


thanks,

Takashi

-- 8< --
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2463,6 +2463,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_DSD_RAW),
 	DEVICE_FLG(0x2708, 0x0002, /* Audient iD14 */
 		   QUIRK_FLAG_IGNORE_CTL_ERROR),
+	DEVICE_FLG(0x2772, 0x0502, /* Musical Fidelity M6s DAC */
+		   0), /* for avoiding QUIRK_FLAG_DSD_RAW with vendor match */
 	DEVICE_FLG(0x2912, 0x30c8, /* Audioengine D1 */
 		   QUIRK_FLAG_GET_SAMPLE_RATE),
 	DEVICE_FLG(0x2a70, 0x1881, /* OnePlus Technology (Shenzhen) Co., Ltd. BE02T */

  parent reply	other threads:[~2026-07-09  7:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 16:33 [REGRESSION] snd-usb-audio: commit da3a7efff64e ("ALSA: usb-audio: Update for native DSD support quirks") breaks DSD playback on Musical Fidelity M6s DAC (2772:0502), plays ~8.8% fast Salvador Blaya
2026-07-08 22:28 ` Jussi Laako
2026-07-09  7:10   ` Salvador Blaya
2026-07-09  7:33   ` Takashi Iwai [this message]
2026-07-09  7:54     ` Salvador Blaya
2026-07-09  8:29       ` Jussi Laako
2026-07-09  8:34     ` Jussi Laako
2026-07-09  9:54       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjcg4nyh.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jussi@sonarnerd.net \
    --cc=regressions@lists.linux.dev \
    --cc=tiniebla6@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.