From: Peter Korsgaard <peter@korsgaard.com>
To: Sergey Bobrenok <bobrofon@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2024.02.x] package/sdbus-cpp: fix build failure on gcc14
Date: Sun, 09 Feb 2025 09:50:48 +0100 [thread overview]
Message-ID: <87bjvb8psn.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20250208180103.101825-1-bobrofon@gmail.com> (Sergey Bobrenok's message of "Sat, 8 Feb 2025 21:01:03 +0300")
>>>>> "Sergey" == Sergey Bobrenok <bobrofon@gmail.com> writes:
> The original commit [1] was merged [2] in sdbus-cpp v1.5.0.
> Fixes:
> https://autobuild.buildroot.org/results/bd0a9fe123956f01336462a31c3375a036744234/
> [1]
> https://github.com/Kistler-Group/sdbus-cpp/commit/f50e4676fe9289eec0744efae2216aa8795fa461
> [2] https://github.com/Kistler-Group/sdbus-cpp/pull/380
> Signed-off-by: Sergey Bobrenok <bobrofon@gmail.com>
> ---
> (2024.05.x, 2024.08.x, 2024.11.x and master are not affected as the
> version was bumped)
You missed the upstream: tag in the patch. Committed with that fixed to
2024.02.x, thanks!
> ---
> ...missing-algorithm-header-include-380.patch | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
> diff --git a/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch b/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
> new file mode 100644
> index 0000000000..df4b78edca
> --- /dev/null
> +++ b/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
> @@ -0,0 +1,29 @@
> +From f50e4676fe9289eec0744efae2216aa8795fa461 Mon Sep 17 00:00:00 2001
> +From: Alfred Wingate <parona@protonmail.com>
> +Date: Thu, 16 Nov 2023 21:26:42 +0000
> +Subject: [PATCH] fix: add missing algorithm header include (#380)
> +
> +* https://gcc.gnu.org/gcc-14/porting_to.html
> +
> +Using gcc 14 uncovers a missing include in Message.h
> +
> +Signed-off-by: Alfred Wingate <parona@protonmail.com>
> +---
> + include/sdbus-c++/Message.h | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/include/sdbus-c++/Message.h b/include/sdbus-c++/Message.h
> +index 915a071..9c85c01 100644
> +--- a/include/sdbus-c++/Message.h
> ++++ b/include/sdbus-c++/Message.h
> +@@ -42,6 +42,7 @@
> + #include <cassert>
> + #include <functional>
> + #include <sys/types.h>
> ++#include <algorithm>
> +
> + // Forward declarations
> + namespace sdbus {
> +--
> +2.48.1
> +
> --
> 2.48.1
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2025-02-09 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 18:01 [Buildroot] [PATCH 2024.02.x] package/sdbus-cpp: fix build failure on gcc14 Sergey Bobrenok
2025-02-09 8:50 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjvb8psn.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=bobrofon@gmail.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.