[Buildroot] [PATCH 2024.02.x] package/sdbus-cpp: fix build failure on gcc14

[Buildroot] [PATCH 2024.02.x] package/sdbus-cpp: fix build failure on gcc14

[Sergey Bobrenok]

The original commit [1] was merged [2] in sdbus-cpp v1.5.0.

Fixes:
https://autobuild.buildroot.org/results/bd0a9fe123956f01336462a31c3375a036744234/

[1]
https://github.com/Kistler-Group/sdbus-cpp/commit/f50e4676fe9289eec0744efae2216aa8795fa461
[2] https://github.com/Kistler-Group/sdbus-cpp/pull/380

Signed-off-by: Sergey Bobrenok <bobrofon@gmail.com>
---
(2024.05.x, 2024.08.x, 2024.11.x and master are not affected as the
version was bumped)
---
 ...missing-algorithm-header-include-380.patch | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch

diff --git a/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch b/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
new file mode 100644
index 0000000000..df4b78edca
--- /dev/null
+++ b/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
@@ -0,0 +1,29 @@
+From f50e4676fe9289eec0744efae2216aa8795fa461 Mon Sep 17 00:00:00 2001
+From: Alfred Wingate <parona@protonmail.com>
+Date: Thu, 16 Nov 2023 21:26:42 +0000
+Subject: [PATCH] fix: add missing algorithm header include (#380)
+
+* https://gcc.gnu.org/gcc-14/porting_to.html
+
+Using gcc 14 uncovers a missing include in Message.h
+
+Signed-off-by: Alfred Wingate <parona@protonmail.com>
+---
+ include/sdbus-c++/Message.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sdbus-c++/Message.h b/include/sdbus-c++/Message.h
+index 915a071..9c85c01 100644
+--- a/include/sdbus-c++/Message.h
++++ b/include/sdbus-c++/Message.h
+@@ -42,6 +42,7 @@
+ #include <cassert>
+ #include <functional>
+ #include <sys/types.h>
++#include <algorithm>
+ 
+ // Forward declarations
+ namespace sdbus {
+-- 
+2.48.1
+
-- 
2.48.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2024.02.x] package/sdbus-cpp: fix build failure on gcc14

[Peter Korsgaard]

>>>>> "Sergey" == Sergey Bobrenok <bobrofon@gmail.com> writes:

 > The original commit [1] was merged [2] in sdbus-cpp v1.5.0.
 > Fixes:
 > https://autobuild.buildroot.org/results/bd0a9fe123956f01336462a31c3375a036744234/

 > [1]
 > https://github.com/Kistler-Group/sdbus-cpp/commit/f50e4676fe9289eec0744efae2216aa8795fa461
 > [2] https://github.com/Kistler-Group/sdbus-cpp/pull/380

 > Signed-off-by: Sergey Bobrenok <bobrofon@gmail.com>
 > ---
 > (2024.05.x, 2024.08.x, 2024.11.x and master are not affected as the
 > version was bumped)

You missed the upstream: tag in the patch. Committed with that fixed to
2024.02.x, thanks!



> ---
 >  ...missing-algorithm-header-include-380.patch | 29 +++++++++++++++++++
 >  1 file changed, 29 insertions(+)
 >  create mode 100644 package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch

 > diff --git a/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch b/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
 > new file mode 100644
 > index 0000000000..df4b78edca
 > --- /dev/null
 > +++ b/package/sdbus-cpp/0001-fix-add-missing-algorithm-header-include-380.patch
 > @@ -0,0 +1,29 @@
 > +From f50e4676fe9289eec0744efae2216aa8795fa461 Mon Sep 17 00:00:00 2001
 > +From: Alfred Wingate <parona@protonmail.com>
 > +Date: Thu, 16 Nov 2023 21:26:42 +0000
 > +Subject: [PATCH] fix: add missing algorithm header include (#380)
 > +
 > +* https://gcc.gnu.org/gcc-14/porting_to.html
 > +
 > +Using gcc 14 uncovers a missing include in Message.h
 > +
 > +Signed-off-by: Alfred Wingate <parona@protonmail.com>
 > +---
 > + include/sdbus-c++/Message.h | 1 +
 > + 1 file changed, 1 insertion(+)
 > +
 > +diff --git a/include/sdbus-c++/Message.h b/include/sdbus-c++/Message.h
 > +index 915a071..9c85c01 100644
 > +--- a/include/sdbus-c++/Message.h
 > ++++ b/include/sdbus-c++/Message.h
 > +@@ -42,6 +42,7 @@
 > + #include <cassert>
 > + #include <functional>
 > + #include <sys/types.h>
 > ++#include <algorithm>
 > + 
 > + // Forward declarations
 > + namespace sdbus {
 > +-- 
 > +2.48.1
 > +
 > -- 

 > 2.48.1

 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot