Re: [RFC PATCH nand/next 1/4] mtd: nand: Create param.c to do CRC check and bitwise majority for Parameter & CASN page

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sky Huang <SkyLake.Huang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Daniel Golle <daniel@makrotopia.org>,
	 Chia-Lin Kao <acelan.kao@canonical.com>,
	 "Mika Westerberg" <mika.westerberg@linux.intel.com>,
	 Cheng Ming Lin <chengminglin@mxic.com.tw>,
	 <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	 <linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	 Steven Liu <Steven.Liu@mediatek.com>
Subject: Re: [RFC PATCH nand/next 1/4] mtd: nand: Create param.c to do CRC check and bitwise majority for Parameter & CASN page
Date: Mon, 18 Nov 2024 11:55:39 +0100	[thread overview]
Message-ID: <87bjyczu8k.fsf@bootlin.com> (raw)
In-Reply-To: <20241020132722.20565-2-SkyLake.Huang@mediatek.com> (Sky Huang's message of "Sun, 20 Oct 2024 21:27:19 +0800")

On 20/10/2024 at 21:27:19 +08, Sky Huang <SkyLake.Huang@mediatek.com> wrote:

> From: "Sky.Huang" <skylake.huang@mediatek.com>
>
> Create drivers/mtd/nand/param.c so ONFI parameter page & CASN page
> can both use nanddev_crc16() and nanddev_bit_wise_majority() directly
> like this:
> * For ONFI Parameter page:
> onfi_crc16() -> nanddev_crc16()
> * For CASN page: nanddev_crc16()
>
> nanddev_bit_wise_majority() is same as nand_bit_wise_majority().

Please use the same nanddev_ prefix.

> nanddev_crc16() is same as onfi_crc16(). But there are lots of
> onfi_crc16() call, so keep onfi_crc16() there and hook it to
> nanddev_crc16().
>
> Signed-off-by: Sky Huang <skylake.huang@mediatek.com>

Thanks,
Miquèl