From: Jonathan Corbet <corbet@lwn.net>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, backports@vger.kernel.org,
Vegard Nossum <vegard.nossum@oracle.com>,
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH v2] docs: add backporting and conflict resolution document
Date: Tue, 03 Oct 2023 09:19:11 -0600 [thread overview]
Message-ID: <87bkdfg2ds.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230824092325.1464227-1-vegard.nossum@oracle.com>
Vegard Nossum <vegard.nossum@oracle.com> writes:
> This is a new document based on my 2022 blog post:
>
> https://blogs.oracle.com/linux/post/backporting-patches-using-git
>
> Although this is aimed at stable contributors and distro maintainers,
> it does also contain useful tips and tricks for anybody who needs to
> resolve merge conflicts.
>
> By adding this to the kernel as documentation we can more easily point
> to it e.g. from stable emails about failed backports, as well as allow
> the community to modify it over time if necessary.
>
> I've added this under process/ since it also has
> process/applying-patches.rst. Another interesting document is
> maintainer/rebasing-and-merging.rst which maybe should eventually refer
> to this one, but I'm leaving that as a future cleanup.
>
> Thanks to Harshit Mogalapalli for helping with the original blog post
> as well as this updated document and Bagas Sanjaya for providing
> thoughtful feedback.
>
> v2: fixed heading style, link style, placeholder style, other comments
So this seems generally good and useful. I have a few small comments,
none of which necessarily block merging it in its current form:
- I would like to see an ack/reviewed-by tag by others with experience
with this task if possible. The lack of complaints is a good start,
but not always indicative of a lack of disagreement...:)
- Might this be better placed in Documentation/maintainer?
- Colordiff looks cool, but I'd at least drop in a mention of the Emacs
ediff mode, which offers (I believe) a lot of the same functionality.
Thanks,
jon
--
To unsubscribe from this list: send the line "unsubscribe backports" in
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, backports@vger.kernel.org,
Vegard Nossum <vegard.nossum@oracle.com>,
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH v2] docs: add backporting and conflict resolution document
Date: Tue, 03 Oct 2023 09:19:11 -0600 [thread overview]
Message-ID: <87bkdfg2ds.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230824092325.1464227-1-vegard.nossum@oracle.com>
Vegard Nossum <vegard.nossum@oracle.com> writes:
> This is a new document based on my 2022 blog post:
>
> https://blogs.oracle.com/linux/post/backporting-patches-using-git
>
> Although this is aimed at stable contributors and distro maintainers,
> it does also contain useful tips and tricks for anybody who needs to
> resolve merge conflicts.
>
> By adding this to the kernel as documentation we can more easily point
> to it e.g. from stable emails about failed backports, as well as allow
> the community to modify it over time if necessary.
>
> I've added this under process/ since it also has
> process/applying-patches.rst. Another interesting document is
> maintainer/rebasing-and-merging.rst which maybe should eventually refer
> to this one, but I'm leaving that as a future cleanup.
>
> Thanks to Harshit Mogalapalli for helping with the original blog post
> as well as this updated document and Bagas Sanjaya for providing
> thoughtful feedback.
>
> v2: fixed heading style, link style, placeholder style, other comments
So this seems generally good and useful. I have a few small comments,
none of which necessarily block merging it in its current form:
- I would like to see an ack/reviewed-by tag by others with experience
with this task if possible. The lack of complaints is a good start,
but not always indicative of a lack of disagreement...:)
- Might this be better placed in Documentation/maintainer?
- Colordiff looks cool, but I'd at least drop in a mention of the Emacs
ediff mode, which offers (I believe) a lot of the same functionality.
Thanks,
jon
next prev parent reply other threads:[~2023-10-03 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 9:23 [PATCH v2] docs: add backporting and conflict resolution document Vegard Nossum
2023-08-24 9:23 ` Vegard Nossum
2023-08-24 9:26 ` kernel test robot
2023-10-03 15:19 ` Jonathan Corbet [this message]
2023-10-03 15:19 ` Jonathan Corbet
2023-10-10 19:57 ` Jonathan Corbet
2023-10-10 19:57 ` Jonathan Corbet
2023-10-13 15:24 ` Vegard Nossum
2023-10-13 15:24 ` Vegard Nossum
2023-10-14 9:43 ` Willy Tarreau
2023-10-14 9:43 ` Willy Tarreau
2023-10-14 11:48 ` Vegard Nossum
2023-10-14 11:48 ` Vegard Nossum
2023-10-14 15:07 ` Willy Tarreau
2023-10-14 15:07 ` Willy Tarreau
2023-10-17 16:42 ` Ben Hutchings
2023-10-23 13:57 ` [PATCH v2.5] docs: backporting: address feedback Vegard Nossum
2023-10-26 17:50 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkdfg2ds.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=Jason@zx2c4.com \
--cc=backports@vger.kernel.org \
--cc=bagasdotme@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=stable@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.