All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Gonglei (Arei)" <arei.gonglei@huawei.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	virtio-fs@redhat.com,
	"Erik Schilling" <erik.schilling@linaro.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [Virtio-fs] [PATCH 08/12] qom: allow for properties to become "fixed"
Date: Mon, 17 Apr 2023 12:02:33 +0200	[thread overview]
Message-ID: <87bkjmddxi.fsf@pond.sub.org> (raw)
In-Reply-To: <20230414160433.2096866-9-alex.bennee@linaro.org> ("Alex Bennée"'s message of "Fri, 14 Apr 2023 17:04:29 +0100")

Alex Bennée <alex.bennee@linaro.org> writes:

> When specialising general purpose objects it is sometimes useful to
> "fix" some of the properties that were configurable by the base
> classes. We will use this facility when specialising
> vhost-user-device.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  qapi/qom.json           |  2 ++
>  include/qom/object.h    | 16 +++++++++++++++-
>  qom/object.c            | 14 ++++++++++++++
>  qom/object_interfaces.c |  9 ++++++---
>  qom/qom-qmp-cmds.c      |  1 +
>  softmmu/qdev-monitor.c  |  1 +
>  6 files changed, 39 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index a877b879b9..4cda191f00 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -33,12 +33,14 @@
>  # @description: if specified, the description of the property.
>  #
>  # @default-value: the default value, if any (since 5.0)
> +# @fixed: if specified if value has been fixed (since 8.1)

Wat?

>  #
>  # Since: 1.2
>  ##
>  { 'struct': 'ObjectPropertyInfo',
>    'data': { 'name': 'str',
>              'type': 'str',
> +            'fixed': 'bool',
>              '*description': 'str',
>              '*default-value': 'any' } }
>  

qom-list and qom-list-properties return a list of this.  Use cases for
the new member?

[...]

WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Gonglei (Arei)" <arei.gonglei@huawei.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	virtio-fs@redhat.com,
	"Erik Schilling" <erik.schilling@linaro.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH 08/12] qom: allow for properties to become "fixed"
Date: Mon, 17 Apr 2023 12:02:33 +0200	[thread overview]
Message-ID: <87bkjmddxi.fsf@pond.sub.org> (raw)
In-Reply-To: <20230414160433.2096866-9-alex.bennee@linaro.org> ("Alex Bennée"'s message of "Fri, 14 Apr 2023 17:04:29 +0100")

Alex Bennée <alex.bennee@linaro.org> writes:

> When specialising general purpose objects it is sometimes useful to
> "fix" some of the properties that were configurable by the base
> classes. We will use this facility when specialising
> vhost-user-device.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  qapi/qom.json           |  2 ++
>  include/qom/object.h    | 16 +++++++++++++++-
>  qom/object.c            | 14 ++++++++++++++
>  qom/object_interfaces.c |  9 ++++++---
>  qom/qom-qmp-cmds.c      |  1 +
>  softmmu/qdev-monitor.c  |  1 +
>  6 files changed, 39 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index a877b879b9..4cda191f00 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -33,12 +33,14 @@
>  # @description: if specified, the description of the property.
>  #
>  # @default-value: the default value, if any (since 5.0)
> +# @fixed: if specified if value has been fixed (since 8.1)

Wat?

>  #
>  # Since: 1.2
>  ##
>  { 'struct': 'ObjectPropertyInfo',
>    'data': { 'name': 'str',
>              'type': 'str',
> +            'fixed': 'bool',
>              '*description': 'str',
>              '*default-value': 'any' } }
>  

qom-list and qom-list-properties return a list of this.  Use cases for
the new member?

[...]



  reply	other threads:[~2023-04-17 10:02 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 16:04 [Virtio-fs] [PATCH 00/12] virtio: add vhost-user-generic and reduce copy and paste Alex Bennée
2023-04-14 16:04 ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 01/12] hw/virtio: fix typo in VIRTIO_CONFIG_IRQ_IDX comments Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 02/12] include/hw/virtio: document virtio_notify_config Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 03/12] include/hw/virtio: add kerneldoc for virtio_init Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 04/12] include/hw/virtio: document some more usage of notifiers Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 05/12] virtio: add generic vhost-user-device Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 06/12] virtio: add PCI stub for vhost-user-device Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-18  8:28   ` [Virtio-fs] " Erik Schilling
2023-04-18  8:28     ` Erik Schilling
2023-04-14 16:04 ` [Virtio-fs] [PATCH 07/12] include: attempt to document device_class_set_props Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 08/12] qom: allow for properties to become "fixed" Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-17 10:02   ` Markus Armbruster [this message]
2023-04-17 10:02     ` Markus Armbruster
2023-04-17 11:26     ` [Virtio-fs] " Alex Bennée
2023-04-17 11:26       ` Alex Bennée
2023-04-17 12:04       ` [Virtio-fs] " Peter Maydell
2023-04-17 12:04         ` Peter Maydell
2023-04-14 16:04 ` [Virtio-fs] [PATCH 09/12] hw/virtio: derive vhost-user-rng from vhost-user-device Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 10/12] hw/virtio: add config support to vhost-user-device Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 11/12] hw/virtio: derive vhost-user-gpio from vhost-user-device (!BROKEN) Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-14 16:04 ` [Virtio-fs] [PATCH 12/12] docs/system: add a basic enumeration of vhost-user devices Alex Bennée
2023-04-14 16:04   ` Alex Bennée
2023-04-17  4:26 ` [Virtio-fs] [PATCH 00/12] virtio: add vhost-user-generic and reduce copy and paste Viresh Kumar
2023-04-17  4:26   ` Viresh Kumar
2023-04-17  8:42   ` [Virtio-fs] " Alex Bennée
2023-04-17  8:42     ` Alex Bennée
2023-04-17 12:32 ` [Virtio-fs] " Stefan Hajnoczi
2023-04-17 12:32   ` Stefan Hajnoczi
2023-04-17 16:14   ` [Virtio-fs] " Alex Bennée
2023-04-17 16:14     ` Alex Bennée
2023-04-18 16:04     ` [Virtio-fs] " Stefan Hajnoczi
2023-04-18 16:04       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkjmddxi.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=arei.gonglei@huawei.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=erik.schilling@linaro.org \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=viresh.kumar@linaro.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.