From: Kalle Valo <kvalo@kernel.org>
To: Peter Lafreniere <peter@n8pjl.ca>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wifi: rsi: Avoid defines prefixed with CONFIG
Date: Wed, 18 Jan 2023 09:28:51 +0200 [thread overview]
Message-ID: <87bkmwxpvw.fsf@kernel.org> (raw)
In-Reply-To: <20230117122838.5006-1-peter@n8pjl.ca> (Peter Lafreniere's message of "Tue, 17 Jan 2023 07:28:38 -0500")
Peter Lafreniere <peter@n8pjl.ca> writes:
> That would work better, but to me it seems odd to have one define
> with a prefix and the others without. I could change them all, but
> that seems like excessive churn for the very minor 'issue' that
> it fixes.
>
> After rereadig rsi_load_9113_firmware(), it seems like just dropping
> the CONFIG_ would be a reasonable change that doesn't affect readability.
Yeah, removing CONFIG_ looks good as well.
But please add quotes into your email. We get A LOT of email so having
proper quotes is important, otherwise we don't know what you are
answering to.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-01-18 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 3:27 [PATCH] wifi: rsi: Avoid defines prefixed with CONFIG Peter Lafreniere
2023-01-17 6:44 ` Kalle Valo
2023-01-17 12:28 ` Peter Lafreniere
2023-01-18 7:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkmwxpvw.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter@n8pjl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.