From: Kalle Valo <kvalo@kernel.org>
To: Peter Lafreniere <peter@n8pjl.ca>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wifi: rsi: Avoid defines prefixed with CONFIG
Date: Tue, 17 Jan 2023 08:44:00 +0200 [thread overview]
Message-ID: <87mt6h8xu7.fsf@kernel.org> (raw)
In-Reply-To: <20230117032729.9578-1-peter@n8pjl.ca> (Peter Lafreniere's message of "Mon, 16 Jan 2023 22:27:29 -0500")
Peter Lafreniere <peter@n8pjl.ca> writes:
> To avoid confusion, it is best to only define CONFIG_* macros in Kconfig
> files. Here we change the name of one define, which causes no change to
> functionality.
>
> Signed-off-by: Peter Lafreniere <peter@n8pjl.ca>
> ---
[...]
> --- a/drivers/net/wireless/rsi/rsi_hal.h
> +++ b/drivers/net/wireless/rsi/rsi_hal.h
> @@ -69,7 +69,7 @@
> #define EOF_REACHED 'E'
> #define CHECK_CRC 'K'
> #define POLLING_MODE 'P'
> -#define CONFIG_AUTO_READ_MODE 'R'
> +#define CONFIGURE_AUTO_READ_MODE 'R'
I would prefer to add a prefix instead, for example
RSI_CONFIG_AUTO_READ_MODE or something like that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-01-17 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 3:27 [PATCH] wifi: rsi: Avoid defines prefixed with CONFIG Peter Lafreniere
2023-01-17 6:44 ` Kalle Valo [this message]
2023-01-17 12:28 ` Peter Lafreniere
2023-01-18 7:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt6h8xu7.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter@n8pjl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.