From: Marc Zyngier <maz@kernel.org>
To: Gavin Shan <gshan@redhat.com>
Cc: yuzhe@nfschina.com, linux-kernel@vger.kernel.org,
shan.gavin@gmail.com, will@kernel.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity_collection()
Date: Sat, 24 Sep 2022 12:56:59 +0100 [thread overview]
Message-ID: <87bkr5hto4.wl-maz@kernel.org> (raw)
In-Reply-To: <20220923065447.323445-1-gshan@redhat.com>
Gavin,
Side note: please make sure you always Cc all the KVM/arm64 reviewers
when sending patches (now added).
On Fri, 23 Sep 2022 07:54:47 +0100,
Gavin Shan <gshan@redhat.com> wrote:
>
> The ITS collection is guranteed to be !NULL when update_affinity_collection()
> is called. So we needn't check ITE's collection with NULL because the
> check has been included to the later one.
It took me a while to understand what you meant by this: the 'coll'
parameter to update_affinity_collection() is never NULL, so comparing
it with 'ite->collection' is enough to cover both the NULL case and
the "another collection" case.
If you agree with this, I can directly fix the commit message when
applying the patch.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Gavin Shan <gshan@redhat.com>
Cc: kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
will@kernel.org, eric.auger@redhat.com, yuzhe@nfschina.com,
oliver.upton@linux.dev, shan.gavin@gmail.com,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexandru Elisei <Alexandru.Elisei@arm.com>
Subject: Re: [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity_collection()
Date: Sat, 24 Sep 2022 12:56:59 +0100 [thread overview]
Message-ID: <87bkr5hto4.wl-maz@kernel.org> (raw)
In-Reply-To: <20220923065447.323445-1-gshan@redhat.com>
Gavin,
Side note: please make sure you always Cc all the KVM/arm64 reviewers
when sending patches (now added).
On Fri, 23 Sep 2022 07:54:47 +0100,
Gavin Shan <gshan@redhat.com> wrote:
>
> The ITS collection is guranteed to be !NULL when update_affinity_collection()
> is called. So we needn't check ITE's collection with NULL because the
> check has been included to the later one.
It took me a while to understand what you meant by this: the 'coll'
parameter to update_affinity_collection() is never NULL, so comparing
it with 'ite->collection' is enough to cover both the NULL case and
the "another collection" case.
If you agree with this, I can directly fix the commit message when
applying the patch.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-09-24 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 6:54 [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity_collection() Gavin Shan
2022-09-23 6:54 ` Gavin Shan
2022-09-24 11:56 ` Marc Zyngier [this message]
2022-09-24 11:56 ` Marc Zyngier
2022-09-25 23:21 ` Gavin Shan
2022-09-25 23:21 ` Gavin Shan
2022-09-26 9:45 ` Marc Zyngier
2022-09-26 9:45 ` Marc Zyngier
2022-09-26 9:59 ` Marc Zyngier
2022-09-26 9:59 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkr5hto4.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=gshan@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.