* [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.
@ 2022-07-24 6:29 ` wangjianli
0 siblings, 0 replies; 8+ messages in thread
From: wangjianli @ 2022-07-24 6:29 UTC (permalink / raw)
To: mpe, benh, paulus, Julia.Lawall, liubo03
Cc: wangjianli, linuxppc-dev, linux-kernel
Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
---
arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
index 514fd45c1994..73c6db20cd8a 100644
--- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
+++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
@@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
* is valid, it is written to the HPT as if an H_ENTER with the
* exact flag set was done. When the invalid count is non-zero
* in the header written to the stream, the kernel will make
- * sure that that many HPTEs are invalid, and invalidate them
+ * sure that many HPTEs are invalid, and invalidate them
* if not.
*/
--
2.36.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.
@ 2022-07-24 6:29 ` wangjianli
0 siblings, 0 replies; 8+ messages in thread
From: wangjianli @ 2022-07-24 6:29 UTC (permalink / raw)
To: mpe, benh, paulus, Julia.Lawall, liubo03
Cc: linuxppc-dev, linux-kernel, wangjianli
Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
---
arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
index 514fd45c1994..73c6db20cd8a 100644
--- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
+++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
@@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
* is valid, it is written to the HPT as if an H_ENTER with the
* exact flag set was done. When the invalid count is non-zero
* in the header written to the stream, the kernel will make
- * sure that that many HPTEs are invalid, and invalidate them
+ * sure that many HPTEs are invalid, and invalidate them
* if not.
*/
--
2.36.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.
2022-07-24 6:29 ` wangjianli
@ 2022-07-25 6:51 ` Michael Ellerman
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2022-07-25 6:51 UTC (permalink / raw)
To: wangjianli, benh, paulus, Julia.Lawall, liubo03
Cc: wangjianli, linuxppc-dev, linux-kernel
wangjianli <wangjianli@cdjrlc.com> writes:
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> index 514fd45c1994..73c6db20cd8a 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> * is valid, it is written to the HPT as if an H_ENTER with the
> * exact flag set was done. When the invalid count is non-zero
> * in the header written to the stream, the kernel will make
> - * sure that that many HPTEs are invalid, and invalidate them
> + * sure that many HPTEs are invalid, and invalidate them
> * if not.
The existing wording is correct:
"the kernel will make sure that ... that many HPTEs are invalid"
cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.
@ 2022-07-25 6:51 ` Michael Ellerman
0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2022-07-25 6:51 UTC (permalink / raw)
To: wangjianli, benh, paulus, Julia.Lawall, liubo03
Cc: linuxppc-dev, linux-kernel, wangjianli
wangjianli <wangjianli@cdjrlc.com> writes:
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> index 514fd45c1994..73c6db20cd8a 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> * is valid, it is written to the HPT as if an H_ENTER with the
> * exact flag set was done. When the invalid count is non-zero
> * in the header written to the stream, the kernel will make
> - * sure that that many HPTEs are invalid, and invalidate them
> + * sure that many HPTEs are invalid, and invalidate them
> * if not.
The existing wording is correct:
"the kernel will make sure that ... that many HPTEs are invalid"
cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.
2022-07-25 6:51 ` Michael Ellerman
@ 2022-07-25 7:14 ` Julia Lawall
-1 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2022-07-25 7:14 UTC (permalink / raw)
To: Michael Ellerman
Cc: linux-kernel, Julia.Lawall, paulus, liubo03, wangjianli,
linuxppc-dev
On Mon, 25 Jul 2022, Michael Ellerman wrote:
> wangjianli <wangjianli@cdjrlc.com> writes:
> > Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> > ---
> > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > index 514fd45c1994..73c6db20cd8a 100644
> > --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> > * is valid, it is written to the HPT as if an H_ENTER with the
> > * exact flag set was done. When the invalid count is non-zero
> > * in the header written to the stream, the kernel will make
> > - * sure that that many HPTEs are invalid, and invalidate them
> > + * sure that many HPTEs are invalid, and invalidate them
> > * if not.
>
> The existing wording is correct:
>
> "the kernel will make sure that ... that many HPTEs are invalid"
Maybe it would be better as "that the number of invalid HPTEs is the same
as the invalid count"?
julia
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.
@ 2022-07-25 7:14 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2022-07-25 7:14 UTC (permalink / raw)
To: Michael Ellerman
Cc: wangjianli, benh, paulus, Julia.Lawall, liubo03, linuxppc-dev,
linux-kernel
On Mon, 25 Jul 2022, Michael Ellerman wrote:
> wangjianli <wangjianli@cdjrlc.com> writes:
> > Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> > ---
> > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > index 514fd45c1994..73c6db20cd8a 100644
> > --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> > @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> > * is valid, it is written to the HPT as if an H_ENTER with the
> > * exact flag set was done. When the invalid count is non-zero
> > * in the header written to the stream, the kernel will make
> > - * sure that that many HPTEs are invalid, and invalidate them
> > + * sure that many HPTEs are invalid, and invalidate them
> > * if not.
>
> The existing wording is correct:
>
> "the kernel will make sure that ... that many HPTEs are invalid"
Maybe it would be better as "that the number of invalid HPTEs is the same
as the invalid count"?
julia
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.
2022-07-25 7:14 ` Julia Lawall
@ 2022-07-25 10:35 ` Michael Ellerman
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2022-07-25 10:35 UTC (permalink / raw)
To: Julia Lawall
Cc: linux-kernel, Julia.Lawall, paulus, liubo03, wangjianli,
linuxppc-dev
Julia Lawall <julia.lawall@inria.fr> writes:
> On Mon, 25 Jul 2022, Michael Ellerman wrote:
>> wangjianli <wangjianli@cdjrlc.com> writes:
>> > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > index 514fd45c1994..73c6db20cd8a 100644
>> > --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
>> > * is valid, it is written to the HPT as if an H_ENTER with the
>> > * exact flag set was done. When the invalid count is non-zero
>> > * in the header written to the stream, the kernel will make
>> > - * sure that that many HPTEs are invalid, and invalidate them
>> > + * sure that many HPTEs are invalid, and invalidate them
>> > * if not.
>>
>> The existing wording is correct:
>>
>> "the kernel will make sure that ... that many HPTEs are invalid"
>
> Maybe it would be better as "that the number of invalid HPTEs is the same
> as the invalid count"?
That doesn't read quite right, I think because if the number of invalid
HPTEs doesn't match the invalid count, the code will invalidate HPTEs so
that the number matches.
So maybe:
When the invalid count is non-zero in the header written to the stream,
the kernel will make sure that number of HPTEs are invalid, or
invalidate them if not.
cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that'.
@ 2022-07-25 10:35 ` Michael Ellerman
0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2022-07-25 10:35 UTC (permalink / raw)
To: Julia Lawall
Cc: wangjianli, benh, paulus, Julia.Lawall, liubo03, linuxppc-dev,
linux-kernel
Julia Lawall <julia.lawall@inria.fr> writes:
> On Mon, 25 Jul 2022, Michael Ellerman wrote:
>> wangjianli <wangjianli@cdjrlc.com> writes:
>> > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > index 514fd45c1994..73c6db20cd8a 100644
>> > --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
>> > * is valid, it is written to the HPT as if an H_ENTER with the
>> > * exact flag set was done. When the invalid count is non-zero
>> > * in the header written to the stream, the kernel will make
>> > - * sure that that many HPTEs are invalid, and invalidate them
>> > + * sure that many HPTEs are invalid, and invalidate them
>> > * if not.
>>
>> The existing wording is correct:
>>
>> "the kernel will make sure that ... that many HPTEs are invalid"
>
> Maybe it would be better as "that the number of invalid HPTEs is the same
> as the invalid count"?
That doesn't read quite right, I think because if the number of invalid
HPTEs doesn't match the invalid count, the code will invalidate HPTEs so
that the number matches.
So maybe:
When the invalid count is non-zero in the header written to the stream,
the kernel will make sure that number of HPTEs are invalid, or
invalidate them if not.
cheers
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-25 10:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-24 6:29 [PATCH] powerpc/kvm: fix repeated words in comments Delete the redundant word 'that' wangjianli
2022-07-24 6:29 ` wangjianli
2022-07-25 6:51 ` Michael Ellerman
2022-07-25 6:51 ` Michael Ellerman
2022-07-25 7:14 ` Julia Lawall
2022-07-25 7:14 ` Julia Lawall
2022-07-25 10:35 ` Michael Ellerman
2022-07-25 10:35 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.